- 31 1月, 2014 2 次提交
-
-
由 Washington Luiz 提交于
-
由 Yves Senn 提交于
-
- 30 1月, 2014 37 次提交
-
-
由 Yves Senn 提交于
Replace Post model with Article model in getting started guide [ci skip]
-
由 Rafael Mendonça França 提交于
Add `travel_back` to remove stubs from `travel` and `travel_to` and remove auto-rollback after each test case
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
This behavior is only work out-of-box with minitest and also add a downside to run after each test case, even if we don't used the travel or travel_to methods
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
find_in_batches should not mutate its argument
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
There is no gain in `referencing` tables that are not used for preloading. Furthermore it will break if polymorphic associations are invloved. This is because `references_eager_loaded_tables?` uses all `reference_values` to decide wether to `eager_load` or `preload`.
-
由 Godfrey Chan 提交于
Modify the session serializer implementation
-
由 Guillermo Iguaran 提交于
Rename allowed options to :marshal and :json, for custom serializers only allow the use of custom classes.
-
由 Marc-Andre Lafortune 提交于
-
由 Rafael Mendonça França 提交于
Alternative implementation to make time travel not dependent on mocha
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Enhance errors while retrieving database config
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Fixing issue with activerecord serialization not being able to dump a record after loading it from YAML - fixes #13861
-
由 Rafael Mendonça França 提交于
Added some style changes in asset pipeline documentation
-
由 Mauricio Linhares 提交于
Fixing issue with activerecord serialization not being able to dump a record after loading it from YAML - fixes #13861
-
由 Robin Dupret 提交于
Fix documentation of filters api with classes [ci skip]
-
由 Kassio Borges 提交于
The api for filters with classes change and the guides weren't updated. Now the class must respond for methods with the same name as the filter, so the `before_action` calls a `before` method, and so on. The method `#filter` has been deprecated in 4.0.0 and has been removed in 4.1.0: #7560
-
由 sowjanya 提交于
-
由 schneems 提交于
Right now if there is an error retrieving database configuration the intent of the error (what the code was trying to do while you got the error) could be more explicit. Instead of this error: ``` Invalid DATABASE_URL: nil (erb):9:in `rescue in <main>' (erb):6:in `<main>' /Users/schneems/.rbenv/versions/2.1.0/lib/ruby/2.1.0/erb.rb:850:in `eval' /Users/schneems/.rbenv/versions/2.1.0/lib/ruby/2.1.0/erb.rb:850:in `result' /Users/schneems/Documents/projects/rails/railties/lib/rails/application/configuration.rb:98:in `database_configuration' /Users/schneems/Documents/projects/rails/activerecord/lib/active_record/railtie.rb:41:in `block in <class:Railtie>' /Users/schneems/Documents/projects/rails/railties/lib/rails/railtie.rb:237:in `instance_exec' /Users/schneems/Documents/projects/rails/railties/lib/rails/railtie.rb:237:in `block in run_tasks_blocks' /Users/schneems/Documents/projects/rails/railties/lib/rails/railtie.rb:237:in `each' /Users/schneems/Documents/projects/rails/railties/lib/rails/railtie.rb:237:in `run_tasks_blocks' /Users/schneems/Documents/projects/rails/railties/lib/rails/application.rb:339:in `block in run_tasks_blocks' /Users/schneems/Documents/projects/rails/railties/lib/rails/engine/railties.rb:13:in `each' ``` I propose we issue this error: ``` Cannot load `Rails.application.database_configuration`: Invalid DATABASE_URL: nil (erb):9:in `rescue in <main>' (erb):6:in `<main>' /Users/schneems/.rbenv/versions/2.1.0/lib/ruby/2.1.0/erb.rb:850:in `eval' /Users/schneems/.rbenv/versions/2.1.0/lib/ruby/2.1.0/erb.rb:850:in `result' /Users/schneems/Documents/projects/rails/railties/lib/rails/application/configuration.rb:98:in `database_configuration' /Users/schneems/Documents/projects/rails/activerecord/lib/active_record/railtie.rb:41:in `block in <class:Railtie>' /Users/schneems/Documents/projects/rails/railties/lib/rails/railtie.rb:237:in `instance_exec' /Users/schneems/Documents/projects/rails/railties/lib/rails/railtie.rb:237:in `block in run_tasks_blocks' /Users/schneems/Documents/projects/rails/railties/lib/rails/railtie.rb:237:in `each' /Users/schneems/Documents/projects/rails/railties/lib/rails/railtie.rb:237:in `run_tasks_blocks' /Users/schneems/Documents/projects/rails/railties/lib/rails/application.rb:339:in `block in run_tasks_blocks' /Users/schneems/Documents/projects/rails/railties/lib/rails/engine/railties.rb:13:in `each' ```
-
由 Rafael Mendonça França 提交于
`find_in_batches` now returns an `Enumerator` Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/relation/batches.rb
-
由 Rafael Mendonça França 提交于
Mention find_each in find_in_batches doc [ci skip]
-
由 Marc-Andre Lafortune 提交于
-
由 Godfrey Chan 提交于
Raise an error if `scope` or `enum` is about to add a conflicting method to the class Fixed #13389
-
由 Godfrey Chan 提交于
Dangerous name conflicts includes instance or class method conflicts with methods defined within `ActiveRecord::Base` but not its ancestors, as well as conflicts with methods generated by other enums on the same class. Fixes #13389.
-
由 Godfrey Chan 提交于
Similar to dangerous attribute methods, a scope name conflict is dangerous if it conflicts with an existing class method defined within `ActiveRecord::Base` but not its ancestors. See also #13389. *Godfrey Chan*, *Philippe Creux*
-
由 Godfrey Chan 提交于
Before: >> ActiveRecord::Base.respond_to?(:find_by_something) NoMethodError: undefined method `abstract_class?' for Object:Class After: >> ActiveRecord::Base.respond_to?(:find_by_something) => false
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
Allow session serializer key in config.session_store
-
由 Lukasz Sarnacki 提交于
MessageEncryptor has :serializer option, where any serializer object can be passed. This commit make it possible to set this serializer from configuration level. There are predefined serializers (:marshal_serializer, :json_serialzier) and custom serializer can be passed as String, Symbol (camelized and constantized in ActionDispatch::Session namepspace) or serializer object. Default :json_serializer was also added to generators to provide secure defalt.
-
- 29 1月, 2014 1 次提交
-
-
由 Yves Senn 提交于
Correctly send the string given to lock! and reload(:lock) to the lock scope - fixes #13788
-