1. 08 8月, 2016 1 次提交
    • S
      Modify LogSubscriber for single partial's cache message. · ab2af4df
      Stan Lo 提交于
      Implement naive partial caching mechanism.
      
      Add test for LogSubscriber
      
      Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it.
      
      Fixed tests
      
      Remove useless settings
      
      Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute
      
      Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload.
      
      Update test's hash syntax
      
      Add configuration to enable/disable fragment caching logging
      
      Remove unless test and add new test to ensure cache info won't effect next rendering's log
      
      Move :enable_fragment_cache_logging config from ActionView to ActionPack
      
      Apply new config to tests
      
      Update actionview's changelog
      
      Update configuration guide
      
      Improve actionview's changelog
      
      Refactor PartialRenderer#render and log tests
      
      Mute subscriber's log instead of disabling instrumentation.
      
      Fix typo, remove useless comment and use new hash syntax
      
      Improve actionpack's log_subscriber test
      
      Fix rebase mistake
      
      Apply new config to all caching intstrument actions
      ab2af4df
  2. 07 8月, 2016 6 次提交
  3. 26 7月, 2016 2 次提交
  4. 25 7月, 2016 1 次提交
  5. 20 7月, 2016 1 次提交
  6. 17 7月, 2016 1 次提交
  7. 29 6月, 2016 1 次提交
  8. 28 6月, 2016 2 次提交
  9. 22 6月, 2016 3 次提交
  10. 16 6月, 2016 5 次提交
  11. 08 6月, 2016 1 次提交
    • S
      Delete bad test · e6bb1a1b
      Sean Griffin 提交于
      This test was broken by f650e032. It was
      added by https://github.com/rails/rails/pull/17978, and is adequately
      tested elsewhere. The reason that this breaks is that
      `Controller#process` is not going to set a new response object, and we
      now terminate in callbacks if the response has been sent. The only
      reason that this test was calling `get` in the first place was because
      the controller under test blows up if `request` was `nil`. The point
      being that the failure is invalid, and I don't think we need to fix the
      test in this location.
      e6bb1a1b
  12. 05 6月, 2016 1 次提交
  13. 02 6月, 2016 1 次提交
  14. 21 5月, 2016 2 次提交
  15. 19 5月, 2016 1 次提交
  16. 18 5月, 2016 2 次提交
  17. 10 5月, 2016 2 次提交
  18. 20 4月, 2016 1 次提交
    • J
      Ensure Cache#inspect doesn't block concurrent cache writes · 9918118a
      Jeremy Daer 提交于
      Object#inspect recursively inspects instance variables, exposing all
      internal state, including sensitive internal cache objects. Override
      Cache#inspect to give a high-level summary that never interferes with
      concurrent cache writes.
      9918118a
  19. 17 4月, 2016 1 次提交
  20. 05 4月, 2016 1 次提交
    • N
      date_select helper with_css_classes option also accept a hash · d7b60544
      neumayr 提交于
      `date_select` helper `:with_css_classes` option now accepts a hash of strings
      for `:year`, `:month`, `:day`, `:hour`, `:minute`, `:second` that will extend
      the select type with the given css class value.
      
      ```erb
      <%= f.date_select :birthday, with_css_classes: { month: "my-month", year: "my-year" } %>
      ```
      
      ```html
      <select id="user_birthday_3i" name="user[birthday(3i)]">…</select>
      <select id="user_birthday_2i" name="user[birthday(2i)]" class="my-month">…</select>
      <select id="user_birthday_1i" name="user[birthday(1i)]" class="my-year">…</select>
      ```
      
      Optional, add global `html_options` to modify every select tag in the set.
      
      ```erb
      <%= f.date_select :birthday, with_css_classes: { month: "my-month", year: "my-year" }, { class: "my-date optional" } %>
      ```
      
      Supported DateHelper methods: `select_day`, `select_month`, `select_year`,
      `select_hour`, `select_minute`, `select_second`, `select_datetime`, `select_time`,
      `time_select`, `date_select` and `datetime_select`.
      
      `:with_css_classes` option was added to the `date_select` with #7975.
      d7b60544
  21. 01 4月, 2016 1 次提交
  22. 16 3月, 2016 1 次提交
  23. 13 3月, 2016 1 次提交
  24. 07 3月, 2016 1 次提交