- 07 1月, 2014 5 次提交
-
-
由 Yves Senn 提交于
Make change_table use object of current database adapter
-
由 Nishant Modak 提交于
- Earlier, change_table was creating database-agnostic object. - After this change, it will create correct object based on current database adapter. - This will ensure that create_table and change_table will get same objects. - This makes update_table_definition method public and nodoc. - Fixes #13577 and #13503
-
由 Carlos Antonio da Silva 提交于
Also improve changelog entries related to secure password to proper highlight.
-
由 Rafael Mendonça França 提交于
Add 'e' var on rescue DalliError, in order to log it
-
由 Arthur Neves 提交于
-
- 06 1月, 2014 24 次提交
-
-
由 Rafael Mendonça França 提交于
Remove warnings in test suite
-
由 Matthias Zirnstein 提交于
lib/active_record/store.rb:79: warning: method redefined; discarding old color= lib/active_record/store.rb:79: warning: previous definition of color= was here lib/active_record/store.rb:83: warning: method redefined; discarding old color lib/active_record/store.rb:83: warning: previous definition of color was here
-
由 Yves Senn 提交于
Fix: ActiveRecord::Store TypeError conversion when using YAML coder
-
由 Thales Oliveira 提交于
Renaming the test accordingly to its behaviour Adding 'Fixes' statement to changelog Improving tests legibility & changelog Undoing mistakenly removed empty line & further improving changelog
-
由 Yves Senn 提交于
/cc @pixeltrix
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
Wrapping symbols with + does not work, we must use <tt> instead.
-
由 Yves Senn 提交于
Add missing tests for invalid names in `rails plugin new` generator
-
由 Carlos Antonio da Silva 提交于
-
由 Robin Böning 提交于
* Test for: Invalid plugin name, because of reserved rails word. * Test for: Invalid plugin name because of constant name that is already in use.
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
-
由 Guillermo Iguaran 提交于
Require actionview/version
-
由 Washington Luiz 提交于
just like all the other modules do require their version file
-
由 Rafael Mendonça França 提交于
Ruby is a proper noun here, not part of code fragment [ci skip]
-
由 Soon Van 提交于
Last line of note also relates heavily to first part and parenthesis broke reading flow.
-
由 Andrew White 提交于
Fixes #12777
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Maintain proleptic gregorian in Time#advance
-
由 Rafael Mendonça França 提交于
Remove method redefined warnings for test suite Closes #13526
-
由 Matthias Zirnstein 提交于
has_many definitions with "name" as singular and as plural e.g. has_many :welcome_posts_with_comment has_many :welcome_posts_with_comments Ruby mentions it with: lib/active_record/associations/builder/collection_association.rb:65: warning: method redefined; discarding old welcome_posts_with_comment_ids lib/active_record/associations/builder/collection_association.rb:65: warning: previous definition of welcome_posts_with_comment_ids was here lib/active_record/associations/builder/collection_association.rb:75: warning: method redefined; discarding old welcome_posts_with_comment_ids= lib/active_record/associations/builder/collection_association.rb:75: warning: previous definition of welcome_posts_with_comment_ids= was here
-
由 Gaelian Ditchburn 提交于
The use of `display:inline` with the content_tag call in the extra_tags_for_form method potentially causes display issues with some browsers, namely Internet Explorer. IE's behaviour of not collapsing the line height on divs with ostensibly no content means that the automatically added div containing the hidden authenticity_token, utf8 and _method form input tags may interfere with other visible form elements in certain circumstances. The use of `display:none` rather than `display:inline` fixes this problem. Fixes #6403
-
- 05 1月, 2014 7 次提交
-
-
由 Andrew White 提交于
In Rails 3.2 you only needed pass an argument for dynamic segment once so unique the segment keys array to match the number of args. Since the number of args is less than required parts the non-optimized code path is selected. This means to benefit from optimized url generation the arg needs to be specified as many times as it appears in the path. Fixes #12808
-
由 Andrew White 提交于
When an optimized helper fails to generate, show the full route constraints in the error message. Previously it would only show the contraints that were required as part of the path. Fixes #13592
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Using a Regexp to replace dynamic segments in a path string is fraught with difficulty and can lead to odd edge cases like #13349. Since we already have a parsed representation of the path it makes sense to use that to generate an array of segments that can be used to build an optimized route's path quickly. Tests on a simple route (e.g. /posts/:id) show a speedup of 35%: https://gist.github.com/pixeltrix/8261932 Calculating ------------------------------------- Current Helper: 5274 i/100ms New Helper: 8050 i/100ms ------------------------------------------------- Current Helper: 79263.6 (±3.7%) i/s - 395550 in 4.997252s New Helper: 153464.5 (±4.9%) i/s - 772800 in 5.047834s Tests on a more complex route show even an greater performance boost: https://gist.github.com/pixeltrix/8261957 Calculating ------------------------------------- Current Helper: 2367 i/100ms New Helper: 5382 i/100ms ------------------------------------------------- Current Helper: 29506.0 (±3.2%) i/s - 149121 in 5.059294s New Helper: 78815.5 (±4.1%) i/s - 398268 in 5.062161s It also has the added benefit of fixing the edge cases described above. Fixes #13349
-
由 Rafael Mendonça França 提交于
provide correct example of `datetime_select` helper [ci skip]
-
由 Andrew White 提交于
Only config.autoload_paths is frozen, so add the preview_path to ActiveSupport::Dependencies.autoload_paths directly in an after_initialize block. Also protect against a blank preview_path being added to autoload_paths which can cause a serious slowdown as Dir[] tries to load all *_preview.rb files under / Fixes #13372
-
由 Kuldeep Aggarwal 提交于
-
- 04 1月, 2014 4 次提交
-
-
由 Robin Dupret 提交于
Fixed truncate documentation. [ci skip]
-
由 Konstantin Wlasow 提交于
-
由 Jon Leighton 提交于
The line was duplicated
-
由 Jon Leighton 提交于
-