- 27 12月, 2013 11 次提交
-
-
由 Robin Dupret 提交于
Define Minitest::Test in case we are running the gist under Minitest 4 and avoid relying on MiniTest::Unit::TestCase to avoid displaying warning on version five. [ci skip]
-
由 Yves Senn 提交于
Adding missing backslashes in active_model files so as to avoid unwanted [ci skip]
-
由 Yves Senn 提交于
-
由 aditya-kapoor 提交于
-
由 Yves Senn 提交于
rbconfig is not used in these files remove unused requires
-
由 Guillermo Iguaran 提交于
Minitest::Unit::TestCase is Minitest::Test [ci skip]
-
由 Arun Agrawal 提交于
-
由 Arun Agrawal 提交于
remove unused requires
-
由 Jeremy Kemper 提交于
Use String#scrub when available to tidy bytes
-
由 Arun Agrawal 提交于
Fixed typo in Rails 4.1 Release Notes [CI skip]
-
由 Semenyk Dmitriy 提交于
-
- 26 12月, 2013 15 次提交
-
-
由 Norman Clarke 提交于
-
由 Xavier Noria 提交于
Improve font of some code in API documentation [ci skip]
-
由 Chun-wei Kuo 提交于
* Add "<tt>" or "+" to improve font of some code and filenames in API documentation * Does not contain wording changes
-
由 Godfrey Chan 提交于
Updated documentation for Attribute Methods [ci skip]
-
由 Guillermo Iguaran 提交于
Partial fix of database url tests
-
由 schneems 提交于
-
由 schneems 提交于
-
由 schneems 提交于
Right now `db:drop` depends on `load_config` since so when `db:drop` gets executed `load_config` gets run. `db:structure:load` depends on `[:environment, :load_config]`. So before it runs, it executes `environment` but because `load_config` has already executed it is skipped. Note `db:load_config` is "invoke"-d twice, but only "execute"-d once: ``` ** Invoke db:drop (first_time) ** Invoke db:load_config (first_time) ** Execute db:load_config ** Execute db:drop ** Invoke db:structure:load (first_time) ** Invoke environment (first_time) ** Execute environment ** Invoke db:load_config ** Execute db:structure:load ``` The fix for this is making sure that the environment is run before any `load_config`: ``` ** Invoke environment (first_time) ** Execute environment ** Invoke db:drop (first_time) ** Invoke db:load_config (first_time) ** Execute db:load_config ** Execute db:drop ** Invoke db:structure:load (first_time) ** Invoke environment ** Invoke db:load_config ** Execute db:structure:load ```
-
由 schneems 提交于
Prior to #13463 when `DATABASE_URL` was set, Rails automagically used that value instead of the database.yml. There are tests in dbs_test that expect this to still be true. After that PR, `RAILS_DATABASE_URL` is expected to be read into the YAML file via ERB, this PR fixes that behavior. Note: this does not entirely fix the tests. It seems that `ActiveRecord::Tasks::DatabaseTasks.current_config` does not process the url string correctly (convert it into a hash), and ` ActiveRecord::Tasks::DatabaseTasks.structure_load(current_config, filename)` as well as other methods in `DatabaseTasks` expect a hash. It seems like we should involve the resolver somewhere in this process to correctly convert the database url, I do not know the best place for that /cc @josevalim
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
Fix railties warnings
-
由 Łukasz Strzałkowski 提交于
Warning: DEPRECATION WARNING: Passing a string to ActiveRecord::Base.establish_connection for a configuration lookup is deprecated, please pass a symbol (:development) instead.
-
由 Łukasz Strzałkowski 提交于
Warning: ~/projects/rails/activerecord/lib/active_record/railtie.rb:140: warning: method redefined; discarding old extend_message ~/projects/rails/activerecord/lib/active_record/errors.rb:104: warning: previous definition of extend_message was here
-
由 Guillermo Iguaran 提交于
Move mysql2 test for when adapter will be loaded
-
由 Guillermo Iguaran 提交于
-
- 25 12月, 2013 14 次提交
-
-
由 aditya-kapoor 提交于
Added Backslashes to ActiveModel::AttributeMethods to prevent unwanted links in the rdoc + some other doc fixes.[ci skip]
-
由 Arun Agrawal 提交于
Typo rectified commom => common[ci skip]
-
由 Aayush khandelwal 提交于
-
由 José Valim 提交于
using symbol instead of string in establish_connection
-
由 Kuldeep Aggarwal 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 schneems 提交于
When run with only the Mysql adapter, we get this failure: https://travis-ci.org/rails/rails/jobs/15937907#L2416 Porting the test over to only run when mysql2 is loaded
-
由 José Valim 提交于
A better solution has been pushed to master. This reverts commit 959cfcef.
-
由 José Valim 提交于
Fix railties tests in master
-
由 José Valim 提交于
Better missing `secret_key_base` error message
-
由 José Valim 提交于
Raise NoDatabaseError when db does not exist
-
由 schneems 提交于
Tests are failing due to missing env var on master https://travis-ci.org/rails/rails/jobs/15930622#L641 This adds an environment variable `ENV['RAILS_SECRET_KEY_BASE']` so these tests will pass.
-
由 schneems 提交于
Previously the error was: ``` RuntimeError: You must set secret_key_base in your app's config ``` Will now be: ``` RuntimeError: Missing `secret_key_base` for 'production' environment, set this value in `config/secrets.yml` ```
-