1. 21 10月, 2015 1 次提交
  2. 14 10月, 2015 1 次提交
    • Y
      applies new doc guidelines to Active Record. · 428d47ad
      Yves Senn 提交于
      The focus of this change is to make the API more accessible.
      References to method and classes should be linked to make it easy to
      navigate around.
      
      This patch makes exzessiv use of `rdoc-ref:` to provide more readable
      docs. This makes it possible to document `ActiveRecord::Base#save` even
      though the method is within a separate module
      `ActiveRecord::Persistence`. The goal here is to bring the API closer to
      the actual code that you would write.
      
      This commit only deals with Active Record. The other gems will be
      updated accordingly but in different commits. The pass through Active
      Record is not completely finished yet. A follow up commit will change
      the spots I haven't yet had the time to update.
      
      /cc @fxn
      428d47ad
  3. 13 10月, 2015 1 次提交
  4. 26 9月, 2015 1 次提交
  5. 23 9月, 2015 2 次提交
    • Y
      remove warning from Calculations#sum · 908d6871
      yuuji.yaginuma 提交于
      This removes the following warning.
      ```
      activerecord/lib/active_record/relation/calculations.rb:74: warning: `&' interpreted as argument prefix
      ```
      908d6871
    • Y
      Fix arguments of `AR::Calculations#sum` · 0f6d47d8
      yui-knk 提交于
      Arguments of `#sum` does not match with other shortcuts methods
      (count, average, minimum, and maximum).
      This commit fix these two points:
      
      * call `super` with only block arguments
        First argument of `super` method, `Enumerable#sum`, is `identity`
        and first argument of `AR::Calculations#sum` is `column_name`.
        `Enumerable#sum` does not expect `column_name` to be passed.
      * Change first argument of `sum` from array arguemnt to single
        argument to match other shortcuts methods. When `sum` accept
        array arguemnt, user can pass multi arguments and an exception is
        raised from `calculate`.
      0f6d47d8
  6. 03 7月, 2015 1 次提交
    • J
      [skip ci] #distinct instead of #uniq · 64401610
      Jon Atack 提交于
      as #uniq will be removed from Rails 5.0 as per the Active Support
      exception raised:
      
      ActiveSupport::DeprecationException: DEPRECATION WARNING: uniq is
      deprecated and will be removed from Rails 5.0 (use distinct instead).
      64401610
  7. 27 6月, 2015 1 次提交
  8. 20 6月, 2015 2 次提交
    • S
      Include `Enumerable` in `ActiveRecord::Relation` · b644964b
      Sean Griffin 提交于
      After discussing, we've decided it makes more sense to include it. We're
      already forwarding every conflicting method to `to_a`, and there's no
      conflation of concerns. `Enumerable` has no mutating methods, and it
      just allows us to simplify the code. No existing methods will have a
      change in behavior. Un-overridden Enumerable methods will simply
      delegate to `each`.
      
      [Sean Griffin & bogdan]
      b644964b
    • S
      Use `Enumerable#sum` on `ActiveRecord::Relation` when a block is given · 7d14bd3f
      Sean Griffin 提交于
      This matches our behavior in other cases where useful enumerable methods
      might have a different definition in `Relation`. Wanting to actually
      enumerate over the records in this case is completely reasonable, and
      wanting `.sum` is reasonable for the same reason it is on `Enumerable`
      in the first place.
      7d14bd3f
  9. 29 5月, 2015 1 次提交
    • K
      Allow Enumerable#pluck to take a splat. · 777fa257
      Kevin Deisz 提交于
      This allows easier integration with ActiveRecord, such that
      AR#pluck will now use Enumerable#pluck if the relation is loaded,
      without needing to hit the database.
      777fa257
  10. 13 4月, 2015 1 次提交
  11. 17 3月, 2015 1 次提交
  12. 28 2月, 2015 1 次提交
  13. 18 2月, 2015 1 次提交
  14. 01 2月, 2015 1 次提交
    • S
      Attribute assignment and type casting has nothing to do with columns · 70ac0729
      Sean Griffin 提交于
      It's finally finished!!!!!!! The reason the Attributes API was kept
      private in 4.2 was due to some publicly visible implementation details.
      It was previously implemented by overloading `columns` and
      `columns_hash`, to make them return column objects which were modified
      with the attribute information.
      
      This meant that those methods LIED! We didn't change the database
      schema. We changed the attribute information on the class. That is
      wrong! It should be the other way around, where schema loading just
      calls the attributes API for you. And now it does!
      
      Yes, this means that there is nothing that happens in automatic schema
      loading that you couldn't manually do yourself. (There's still some
      funky cases where we hit the connection adapter that I need to handle,
      before we can turn off automatic schema detection entirely.)
      
      There were a few weird test failures caused by this that had to be
      fixed. The main source came from the fact that the attribute methods are
      now defined in terms of `attribute_names`, which has a clause like
      `return [] unless table_exists?`. I don't *think* this is an issue,
      since the only place this caused failures were in a fake adapter which
      didn't override `table_exists?`.
      
      Additionally, there were a few cases where tests were failing because a
      migration was run, but the model was not reloaded. I'm not sure why
      these started failing from this change, I might need to clear an
      additional cache in `reload_schema_from_cache`. Again, since this is not
      normal usage, and it's expected that `reset_column_information` will be
      called after the table is modified, I don't think it's a problem.
      
      Still, test failures that were unrelated to the change are worrying, and
      I need to dig into them further.
      
      Finally, I spent a lot of time debugging issues with the mutex used in
      `define_attribute_methods`. I think we can just remove that method
      entirely, and define the attribute methods *manually* in the call to
      `define_attribute`, which would simplify the code *tremendously*.
      
      Ok. now to make this damn thing public, and work on moving it up to
      Active Model.
      70ac0729
  15. 29 1月, 2015 1 次提交
  16. 28 1月, 2015 2 次提交
    • S
      Remove Relation#bind_params · b06f64c3
      Sean Griffin 提交于
      `bound_attributes` is now used universally across the board, removing
      the need for the conversion layer. These changes are mostly mechanical,
      with the exception of the log subscriber. Additional, we had to
      implement `hash` on the attribute objects, so they could be used as a
      key for query caching.
      b06f64c3
    • S
      Unify access to bind values on Relation · 16ce2eec
      Sean Griffin 提交于
      The bind values can come from four places. `having`, `where`, `joins`,
      and `from` when selecting from a subquery that contains binds. These
      need to be kept in a specific order, since the clauses will always
      appear in that order. Up until recently, they were not.
      
      Additionally, `joins` actually did keep its bind values in a separate
      location (presumably because it's the only case that people noticed was
      broken). However, this meant that anything accessing just `bind_values`
      was broken (which most places were). This is no longer possible, there
      is only a single way to access the bind values, and it includes joins in
      the proper location. The setter was removed yesterday, so breaking `+=`
      cases is not possible.
      
      I'm still not happy that `joins` is putting it's bind values on the
      Arel AST, and I'm planning on refactoring it further, but this removes a
      ton of bug cases.
      16ce2eec
  17. 27 1月, 2015 1 次提交
    • S
      Change `having_values` to use the `WhereClause` class · 39f2c3b3
      Sean Griffin 提交于
      This fixed an issue where `having` can only be called after the last
      call to `where`, because it messes with the same `bind_values` array.
      With this change, the two can be called as many times as needed, in any
      order, and the final query will be correct. However, once something
      assigns `bind_values`, that stops. This is because we have to move all
      of the bind values from the having clause over to the where clause since
      we can't differentiate the two, and assignment was likely in the form
      of:
      
      `relation.bind_values += other.bind_values`
      
      This will go away once we remove all places that are assigning
      `bind_values`, which is next on the list.
      
      While this fixes a bug that was present in at least 4.2 (more likely
      present going back as far as 3.0, becoming more likely in 4.1 and later
      as we switched to prepared statements in more cases), I don't think this
      can be easily backported. The internal changes to `Relation` are
      non-trivial, anything that involves modifying the `bind_values` array
      would need to change, and I'm not confident that we have sufficient test
      coverage of all of those locations (when `having` was called with a hash
      that could generate bind values).
      
      [Sean Griffin & anthonynavarre]
      39f2c3b3
  18. 02 1月, 2015 1 次提交
  19. 11 12月, 2014 1 次提交
  20. 02 11月, 2014 1 次提交
  21. 31 10月, 2014 1 次提交
    • S
      Don't require calculations to be aliased to a column · 53ec0bc0
      Sean Griffin 提交于
      Arel has changed so that `.sum` no longer aliases `SUM(the_column)` to
      `sum_id`. This means the type returned by the adapter will be at the key
      `"SUM(the_column)"`. Longer term, we should eventually be able to retain
      type information from the AR::Base subclasses used in joined queries
      53ec0bc0
  22. 20 9月, 2014 1 次提交
  23. 03 7月, 2014 1 次提交
  24. 22 6月, 2014 1 次提交
  25. 18 6月, 2014 1 次提交
  26. 17 6月, 2014 1 次提交
  27. 12 6月, 2014 1 次提交
  28. 10 6月, 2014 1 次提交
    • S
      Rename `type_cast` to `type_cast_from_database` · d24e6407
      Sean Griffin 提交于
      In some cases there is a difference between the two, we should always
      be doing one or the other. For convenience, `type_cast` is still a
      private method on type, so new types that do not need different behavior
      don't need to implement two methods, but it has been moved to private so
      it cannot be used accidentally.
      d24e6407
  29. 04 6月, 2014 1 次提交
    • E
      reuse available belongs_to? method · 3ef8d536
      eileencodes 提交于
      Reflection has a `belongs_to?` method. Instead of checking for
      `macro == :belongs_to` throughout the source reuse existing
      method.
      
      I also bumped `foreign_key_present?` method onto on line because
      the `belongs_to?` makes it shorter than other longer lines in
      the same class.
      3ef8d536
  30. 03 6月, 2014 1 次提交
  31. 25 5月, 2014 1 次提交
  32. 13 5月, 2014 1 次提交
  33. 03 5月, 2014 1 次提交
  34. 15 4月, 2014 1 次提交
    • L
      Make sure the column_name is different from 'all'. · a9416a40
      Lauro Caetano 提交于
      968c581e have fixed the EagerLoadTest, but
      not in the correct way.
      
      The problem was when `empty?` or `size` was called on relation. It was
      triggering `count(:all)`, which was passing `:all` as the column name to `count`
      on Calculations.
      
      On the other hand, the method `calculate` on Calculations was calling
      `construct_relation_for_association_calculations` instead of `perform_calculation`,
      because `has_include?` was returning `true` since `column_name` was present.
      
      To prevent calling the wrong method to perform the calculation, we have to check
      if the `column_name` is present and if it is different from `:all` (which is now used
      to correctly do `count` with `select`).
      
      More information here: https://github.com/rails/rails/commit/968c581ea34b5236af14805e6a77913b1cb36238#commitcomment-6006135
      a9416a40
  35. 07 4月, 2014 1 次提交
  36. 14 1月, 2014 1 次提交
  37. 11 12月, 2013 1 次提交