- 10 1月, 2015 19 次提交
-
-
由 Yves Senn 提交于
-
由 Carlos Antonio da Silva 提交于
The last supported plugin on the list was protected_attributes, which is not going to be supported anymore on Rails 5. [ci skip]
-
由 Carlos Antonio da Silva 提交于
Related to #10690.
-
由 Guillermo Iguaran 提交于
Switching SecureTokens to Base58
-
由 robertomiranda 提交于
Update Secure Token Doc [ci skip] remove require securerandom, core_ext/securerandom already do that ref 7e006057
-
由 Guillermo Iguaran 提交于
Remove attributes_protected_by_default reference
-
由 Guillermo Iguaran 提交于
-
由 robertomiranda 提交于
Remove attributes_protected_by_default reference, since MassAssignmentSecurity was removed from ActiveModel f8c9a4d3
-
由 Guillermo Iguaran 提交于
-
由 Godfrey Chan 提交于
Copy records to parent transaction should happen on TransactionManager
-
由 Arthur Neves 提交于
It is up to the TransactionManager keep the state of current transaction, so after it commits it needs to copy any remaning record to the next current transaction
-
由 Rafael Mendonça França 提交于
Use keyword args on committed! and rolledback!
-
由 Arthur Neves 提交于
As discussed before, those methods should receive a keyword args instead of just parameters
-
由 Sean Griffin 提交于
This is cropping up all over the place. After a brief dive, I'm really not sure why we have `arel.bind_values` at all. A cursory grep didn't reveal where they're actually being assigned (it's definitely in AR, not in Arel). I'd like to dig further into it, as I'm fairly certain we don't actually need it, we just need a way for the predicate builder to communicate merged binds upstream. Fixes #18414
-
由 Sean Griffin 提交于
The reason this bug occured is that we never actually check to see if this column has changed from it's default, since it was never assigned and is not mutable. It appears I was wrong in b301c402, with my statement of "there is no longer a case where a given value would differ from the default, but would not already be marked as changed." However, I chose not to revert the deletion of `initialize_internals_callback` from that commit, as I think a solution closer to where the problem lies is less likely to get erroneously removed. I'm not super happy with this solution, but it mirrors what is being done in `_update_record`, and a fix for one should work for the other. I toyed with the idea of changing the definition of `changed?` on the type to `changed_in_place?`. If we type cast the raw value, it'll break a test about updating not modifying the lock column if nothing else was changed. We could have the definition check if `raw_old_value` is `nil`, but this feels fragile and less intention revealing. It would, however, have the benefit of cleaning up old data that incorrectly persisted as `nil`. Fixes #18422
-
由 Rafael Mendonça França 提交于
Use parallel bundler install.
-
由 David Heinemeier Hansson 提交于
Correctly count methods when using declarative `#test` in minitest
-
由 Guo Xiang Tan 提交于
Travis recommends a default of 3. See: http://docs.travis-ci.com/user/languages/ruby/#Default-Test-Script
-
由 Yves Senn 提交于
Default headers, removed in controller actions, will not be reapplied to the test response
-
- 09 1月, 2015 18 次提交
-
-
由 Jonas Baumann 提交于
-
由 Rafael Mendonça França 提交于
Add _mailer suffix to i18n path
-
由 Sean Griffin 提交于
ActiveRecord: release connection on reconnect failure.
-
由 brainopia 提交于
- test/functional - test/unit
-
由 brainopia 提交于
-
由 Yoshioka Tsuneo 提交于
When trying to checkout connection from connection pool, checkout()(and checkout_and_verify) verify whether the connection is active or not. And, if the connection is not active, connection adapters try to reconnect to server. And, if database is down at this moment, reconnect fails and exception is raised. (Ex: Mysql2::Error: Can't connect to local MySQL server through socket xxx) But, ConnectionPool does not catch the exception, but leaks current disconnected connection to @connection. So, if database's temporary down happens several times and exceeds the number of connection pool(5 by default), activerecord will be no more available, even if database server is already recovered. This patch fix it by catching exception and releasing connection.
-
由 Carlos Souza 提交于
For mailers created via generators Follow up to #18074
-
由 Rafael Mendonça França 提交于
remove *_filter
-
由 Abdelkader Boudih 提交于
-
由 Rafael Mendonça França 提交于
Add test case and documentation for skip_before_filter.
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
Add prepend option to protect_from_forgery.
-
由 Josef Šimánek 提交于
-
由 David Heinemeier Hansson 提交于
Remove ActionController::HideActions (closes #18336)
-
由 claudiob 提交于
The new test/docs further explain the conflicts that can happen when mixing `:if`/`:unless` options with `:only`/`:except` options in `skip_before_action`. The gist is that "positive" filters always have priority over negative ones. The previous commit already showed that `:only` has priority over `:if`. This commit shows that `:if` has priority over `:except`. For instance, the following snippets are equivalent: ```ruby skip_before_action :some_callback, if: -> { condition }, except: action ``` ```ruby skip_before_action :some_callback, if: -> { condition } ```
-
由 Lauro Caetano 提交于
Test case for using skip_before_filter with the options :only and :if both present. In this case, the :if option will be ignored and :only will be executed. Closes #14549 (the commit was cherry-picked from there).
-
- 08 1月, 2015 3 次提交
-
-
由 David Heinemeier Hansson 提交于
Enqueued email assertions
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-