- 29 5月, 2015 1 次提交
-
-
由 Sean Griffin 提交于
This is a variant implementation of the changes proposed in #19914. Unlike that PR, the change in behavior is isolated in its own class. This is to prevent wonky behavior if a Proc is assigned outside of the default, and it is a natural place to place the behavior required by #19921 as well. Close #19914. [Sean Griffin & Kir Shatrov]
-
- 28 5月, 2015 4 次提交
-
-
由 Washington Luiz 提交于
Couldn't find other way to get the association name from a given class other than looping through `reflect_on_all_associations` reflections .. Noticed this one while looking at this example: ```ruby class Product < ActiveRecord::Base has_many :variants has_many :translations end class Translation < ActiveRecord::Base belongs_to :product end class Variant < ActiveRecord::Base belongs_to :product end class BugTest < Minitest::Test def test_merge_stuff product = Product.create! name: 'huhu' variant = Variant.create! product_id: product.id Translation.create! locale: 'en', product_id: product.id product_relation = Product.all .preload(:translations) .joins(:translations) .merge(Translation.where(locale: 'en')) .where(name: 'huhu') assert_equal variant, Variant.joins(:product).merge(product_relation).first end end ```
-
由 Jordan Raine 提交于
-
由 Akshay Vishnoi 提交于
-
由 George Claghorn 提交于
Currently, values for columns backing Active Record enums must be specified as integers in test fixtures: awdr: title: "Agile Web Development with Rails" status: 2 rfr: title: "Ruby for Rails" status: <%= Book.statuses[:proposed] %> This is potentially confusing, since enum values are typically specified as symbols or strings in application code. To resolve the confusion, this change permits the use of symbols or strings to specify enum values: awdr: status: :published It is compatible with fixtures that specify enum values as integers.
-
- 27 5月, 2015 1 次提交
-
-
由 Ryuta Kamizono 提交于
Related with #17370.
-
- 26 5月, 2015 2 次提交
-
-
由 keepcosmos 提交于
-
由 Yves Senn 提交于
See #9683 for the reasons we switched to `distinct`. Here is the discussion that triggered the actual deprecation #20198. `uniq`, `uniq!` and `uniq_value` are still around. They will be removed in the next minor release after Rails 5.
-
- 24 5月, 2015 1 次提交
-
-
由 Akshay Vishnoi 提交于
-
- 23 5月, 2015 1 次提交
-
-
由 Jonathan Worek 提交于
-
- 22 5月, 2015 1 次提交
-
-
由 Waynn Lue 提交于
-
- 20 5月, 2015 8 次提交
-
-
由 karanarora 提交于
-
由 amitkumarsuroliya 提交于
-
由 Ronak Jangir 提交于
-
由 Aaron Patterson 提交于
we should ask the reflection for its name rather than storing the reflection name in two places (an array and a reflection object)
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
This line introduced by the commit fd398475 for using `Arel::Visitors::BindVisitor`. Currently it is not used.
-
由 Ryuta Kamizono 提交于
Related with #20028.
-
由 Ryuta Kamizono 提交于
-
- 19 5月, 2015 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
- 18 5月, 2015 3 次提交
- 17 5月, 2015 1 次提交
-
-
由 Eugene Kenny 提交于
Active Record detects when the process has forked and automatically creates a new connection pool to avoid sharing file descriptors. If the existing connection pool had a schema cache associated with it, the new pool should copy it to avoid unnecessarily querying the database for its schema. The code to detect that the process has forked is in ConnectionHandler, but the existing test for it was in the ConnectionManagement test file. I moved it to the right place while I was writing the new test for this change.
-
- 15 5月, 2015 1 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
-
- 14 5月, 2015 3 次提交
-
-
由 thedarkone 提交于
Renamed `@reserved_connections` -> `@thread_cached_conns`. New name clearly conveys the purpose of the cache, which is to speed-up `#connection` method. The new `@thread_cached_conns` now also uses `Thread` objects as keys (instead of previously `Thread.current.object_id`). Since there is no longer any synchronization around `@thread_cached_conns`, `disconnect!` and `clear_reloadable_connections!` methods now pre-emptively obtain ownership (via `checkout`) of all existing connections, before modifying internal data structures. A private method `release` has been renamed `thread_conn_uncache` to clear-up its purpose. Fixed some brittle `thread.status == "sleep"` tests (threads can go into sleep even without locks).
-
由 thedarkone 提交于
-
由 thedarkone 提交于
Move post checkout connection verification out of mutex.synchronize.
-
- 13 5月, 2015 5 次提交
-
-
由 Yves Senn 提交于
This can resolve confusing situation when a top level constant exists but a namespaced version is identified. Related to #19531.
-
由 Tony Miller 提交于
-
由 Alex Coomans 提交于
Add full set of MySQL CLI options to support SSL authentication when using db:structure dump and load
-
由 Mehmet Emin İNAÇ 提交于
fix minor problems
-
由 Mehmet Emin İNAÇ 提交于
-
- 12 5月, 2015 3 次提交
-
-
由 Matthew Rudy Jacobs 提交于
-
由 Matthew Rudy Jacobs 提交于
This method has already been removed.
-
由 claudiob 提交于
Stems from https://github.com/rails/rails/pull/20105#issuecomment-100900939 where @senny said: > From my point of view, all the docs (guides, API) are version bound. > They should describe that version and continue to be available when newer versions are released. > The cross referencing can be done by the interested user.
-
- 11 5月, 2015 3 次提交
-
-
由 claudiob 提交于
-
由 Alex Robbin 提交于
If your STI class looks like this: ```ruby class Company < ActiveRecord::Base self.store_full_sti_class = false class GoodCo < Company end class BadCo < Company end end ``` The expectation (which is valid) is that the `type` in the database is saved as `GoodCo` or `BadCo`. However, another expectation should be that setting `type` to `GoodCo` would correctly instantiate the object as a `Company::GoodCo`. That second expectation is what this should fix.
-
由 claudiob 提交于
Now that master points at Rails 5, we might not need to explain how things used to work in Rails 3. Or we might… up to you
😁
-