- 12 6月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
`split(/\s*,\s*/)` to order args and then `permit.match?` one by one is much slower than `permit.match?` once.
-
- 07 6月, 2019 4 次提交
-
-
由 Eileen M. Uchitelle 提交于
Add forgotten nodoc to dump_schema method.
-
由 Ryuta Kamizono 提交于
Allow quoted identifier string as safe SQL string
-
由 Ryuta Kamizono 提交于
Fix preloading on AR::Relation where records are duplicated by a join
-
由 Rafael França 提交于
Include warning in docs about polymorphism in underlying tables
-
- 06 6月, 2019 2 次提交
-
-
由 Steiley 提交于
fix typo in CHANGELOGs.
-
由 Eileen M. Uchitelle 提交于
Move schema cache to pool
-
- 05 6月, 2019 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fixed db:prepare task for multiple databases.
-
由 Eileen M. Uchitelle 提交于
Treat ActiveRecord::Base and ApplicationRecord as "primary"
-
由 Yuji Yaginuma 提交于
Extract default log file open operation to method
-
由 Ryuta Kamizono 提交于
Fix sqlite3 collation parsing when using decimal columns.
-
由 John Hawthorn 提交于
Don't call listen with empty directory list
-
由 Kasper Timm Hansen 提交于
Fix EventedFileUpdateChecker through a symlink
-
- 04 6月, 2019 3 次提交
-
-
由 Eileen M. Uchitelle 提交于
Do not clear deprecated initializer dependencies if using classic autoloader
-
由 Cliff Pruitt 提交于
`Rails::Application::Finisher` defines a `:let_zeitwerk_take_over` initializer. This initializer is always run but it's statements are wrapped in a guard: `config.autoloader == :zeitwerk`. `Finisher` also defines a `initializer :warn_if_autoloaded` initializer with a `before: :let_zeitwerk_take_over` option which also always runs. This initializer unloads any constants autoloaded during initialization and displays a deprecation warning. This initializer does not account for `config.autoloader` being set to `:classic`. The problem is that this initializer changes the behavior of the classic autoloader. Constant autoloading from initializers is deprecated but the deprecation should not break existing applications which currently depend on autoloaded constants in initializers. This commit prevents the dependencies from being unloaded if the autoloader is not Zeitwerk. It also updates the deprecation warning, if the classic autoloader is enabled, to indicate that the constants would have been unloaded if Zeitwerk had been used.
-
由 Yuji Yaginuma 提交于
Only clear cache when view paths are specified
-
- 03 6月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Fix invalid schema dump when primary key column has a comment
-
- 02 6月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
Avoid making extra 5 arrays in each `save`
-
由 Ryuta Kamizono 提交于
Fix table comment also being applied to the primary key column
-
- 01 6月, 2019 2 次提交
-
-
由 Yuji Yaginuma 提交于
Change `ActionDispatch::Response#content_type` returning Content-Type header as it is
-
由 John Hawthorn 提交于
Fail parallel tests if workers exit early
-
- 29 5月, 2019 4 次提交
-
-
由 yuuji.yaginuma 提交于
The other template files do not add `frozen_string_literal`, so should behave the same. Ref: #30342, #30348.
-
由 Rafael França 提交于
Use WeakRef in Reaper to avoid leaking connection pools
-
由 Aaron Patterson 提交于
Use a single thread for all ConnectionPool Reapers
-
- 28 5月, 2019 7 次提交
-
-
由 Ryuta Kamizono 提交于
This reverts commit a1ee4a9f. Even if a1ee4a9f is applied, CI is still flakiness. https://buildkite.com/rails/rails/builds/61252#2c090afa-aa84-4a2b-8b81-9f09219222c6/994-1005 https://buildkite.com/rails/rails/builds/61252#2e55bf83-1bde-44a2-a4f1-b5c3f6820fb4/929-938 Failing tests by whether schema cache is filled or not, it actually means that whether SCHEMA SQLs are executed or not is not target for the tests. So I've reverted commit a1ee4a9f which filling schema cache before `assert_no_queries`, and replace `assert_no_queries` to `assert_queries(0)`.
-
由 Eileen M. Uchitelle 提交于
Fix unexpected select_tag delete behavior when include_blank is present
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Don't round off subseconds unless necessary
-
由 Ryuta Kamizono 提交于
Allow symbol (i.e. quoted identifier) as safe SQL string
-
由 Ryuta Kamizono 提交于
[documentation][ci skip] stringify_keys and symbolize_keys have stable results.
- 27 5月, 2019 1 次提交
-
-
由 Akira Matsuda 提交于
The initializer receives `nil` for these options when no cofigurations were given: https://github.com/rails/rails/blob/v6.0.0.rc1/activerecord/lib/active_record/railtie.rb#L91-L97
-
- 26 5月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Change comments [ci skip]
-
- 24 5月, 2019 2 次提交
-
-
由 Rafael França 提交于
Wrap ActionView cache expiry in a mutex
-
由 Rafael França 提交于
Bump Gemfile entry jbuilder version
-
- 23 5月, 2019 1 次提交
-
-
由 Rafael França 提交于
Remove compatibility module from docs [ci skip]
-
- 22 5月, 2019 2 次提交
-
-
由 Rafael França 提交于
[CI skip] Put :nodoc: on method that raises NoMethodError
-
由 Ryuta Kamizono 提交于
Testing the result of `capture_sql` is fragile, it is due to whether SCHEMA SQLs are executed or not depends on whether schema cache is filled or not. https://buildkite.com/rails/rails/builds/61248#a5b9dc59-ff0c-40c0-b56e-0895662fbc4c/993-1004 https://buildkite.com/rails/rails/builds/61248#1157b389-f2c7-4554-b6e5-a37624a0e74a/996-1005 I've confirmed all `capture_sql` use cases in our code base, all cases won't expect SCHEMA SQLs are included. ``` % git grep -n capture_sql test/cases/associations/belongs_to_associations_test.rb:202: sql = capture_sql { comment.post } test/cases/associations/belongs_to_associations_test.rb:204: assert_not_equal sql, capture_sql { comment.post } test/cases/associations/has_many_associations_test.rb:169: sql = capture_sql { post.comments.to_a } test/cases/associations/has_many_associations_test.rb:171: assert_not_equal sql, capture_sql { post.comments.to_a } test/cases/associations/has_many_associations_test.rb:276: expected_sql = capture_sql { author.thinking_posts.delete_all } test/cases/associations/has_many_associations_test.rb:281: loaded_sql = capture_sql { author.thinking_posts.delete_all } test/cases/associations/has_many_associations_test.rb:289: expected_sql = capture_sql { author.posts.delete_all } test/cases/associations/has_many_associations_test.rb:294: loaded_sql = capture_sql { author.posts.delete_all } test/cases/associations/left_outer_join_association_test.rb:22: queries = capture_sql do test/cases/associations/left_outer_join_association_test.rb:49: queries = capture_sql { Author.left_outer_joins(:posts).to_a } test/cases/associations/left_outer_join_association_test.rb:54: queries = capture_sql { Author.joins(:posts).left_outer_joins(:posts).to_a } test/cases/associations/left_outer_join_association_test.rb:60: queries = capture_sql { Author.left_outer_joins({}).to_a } test/cases/associations/left_outer_join_association_test.rb:65: queries = capture_sql { Author.left_outer_joins([]).to_a } test/cases/associations/left_outer_join_association_test.rb:78: queries = capture_sql { Author.left_outer_joins(:essays).to_a } test/cases/associations_test.rb:384: log = capture_sql do test/cases/associations_test.rb:399: log = capture_sql do test/cases/associations_test.rb:414: log = capture_sql do test/cases/associations_test.rb:429: log = capture_sql do test/cases/associations_test.rb:444: log = capture_sql do test/cases/associations_test.rb:459: log = capture_sql do test/cases/reflection_test.rb:307: expected_sql = capture_sql { hotel.recipes.to_a } test/cases/reflection_test.rb:312: loaded_sql = capture_sql { hotel.recipes.to_a } test/cases/relation_test.rb:212: queries = capture_sql { Author.joins(:posts).merge(Post.joins(:comments)).to_a } test/cases/relation_test.rb:232: queries = capture_sql { Post.joins(:author, :categorizations).merge(Author.select(:id)).merge(categorizations_with_authors).to_a } test/cases/relation_test.rb:347: log = capture_sql do test/cases/scoping/relation_scoping_test.rb:146: log = capture_sql do test/cases/scoping/relation_scoping_test.rb:159: log = capture_sql do test/cases/test_case.rb:33: def capture_sql test/cases/test_case.rb:41: capture_sql { yield } ```
-