- 10 10月, 2018 12 次提交
-
-
由 Ryuta Kamizono 提交于
Generate delegation methods to named scope in the definition time
-
由 Ryuta Kamizono 提交于
Fix inconsistent behavior by clearing QueryCache when reloading associations
-
由 Ryuta Kamizono 提交于
Follow up 45be690f. `predicate_builder.build` in `where` requires `load_schema` for `type_for_attribute`.
-
由 Christophe Maximin 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Before: ``` Pet Destroy (0.8ms) DELETE FROM `pets` WHERE `pets`.`pet_id` IN (SELECT `pet_id` FROM (SELECT DISTINCT `pets`.`pet_id` FROM `pets` LEFT OUTER JOIN `toys` ON `toys`.`pet_id` = `pets`.`pet_id` WHERE `toys`.`name` = ?) AS __active_record_temp) [["name", "Bone"]] ``` After: ``` Pet Destroy (1.0ms) DELETE `pets` FROM `pets` LEFT OUTER JOIN `toys` ON `toys`.`pet_id` = `pets`.`pet_id` WHERE `toys`.`name` = ? [["name", "Bone"]] ```
-
由 Eileen M. Uchitelle 提交于
Add `skip-webpack-install` option
-
由 Gannon McGibbon 提交于
Change contributing guide to suggest using safer force push
-
由 Eileen M. Uchitelle 提交于
Move db:migrate:status to DatabaseTasks method
-
由 Gannon McGibbon 提交于
clarify role of unique_id in ActiveSupport::Notifications [ci skip]
-
由 Ryuta Kamizono 提交于
Add docs to ActiveRecord::Persistence#belongs_to_touch_method [ci skip]
-
- 09 10月, 2018 6 次提交
-
-
由 Ryuta Kamizono 提交于
The delegation methods to named scope are defined when `method_missing` is invoked on the relation. Since #29301, the receiver in the named scope is changed to the relation like others (e.g. `default_scope`, etc) for consistency. Most named scopes would be delegated from relation by `method_missing`, since we don't allow scopes to be defined which conflict with instance methods on `Relation` (#31179). But if a named scope is defined with the same name as any method on the `superclass` (e.g. `Kernel.open`), the `method_missing` on the relation is not invoked. To address the issue, make the delegation methods to named scope is generated in the definition time. Fixes #34098.
-
由 yuuji.yaginuma 提交于
To remove extra `--no-skip-javascript` tests.
-
由 yuuji.yaginuma 提交于
`webpacker:install` also includes execution of yarn, it takes time to execute, so avoid unnecessary tests.
-
由 yuuji.yaginuma 提交于
This option is useful when want to check only the files generated by `rails new`, or if want to do something before `webpacker:install`.
-
由 Ryuta Kamizono 提交于
Follow up 45be690f. Somehow calling `define_attribute_methods` in `build`/`new` sometimes causes the `table_exists?` query. To address CI flakiness due to `assert_no_queries` failure, ensure `define_attribute_methods` before `assert_no_queries`.
-
由 Gannon McGibbon 提交于
-
- 08 10月, 2018 12 次提交
-
-
由 Ryuta Kamizono 提交于
fix broken link in Action Cable guides and readme [ci skip]
-
由 Donnie Propst 提交于
-
由 George Claghorn 提交于
When Content-Type is "application/x-gzip", request.content_type resolves to "application/gzip", because application/x-gzip is a synonym of application/gzip by default. This causes the acceptable_content? check in ActiveStorage::DiskController to fail, because the direct upload token contains application/x-gzip, which is not equal to application/gzip. Fix by comparing the token content type with the request content type *and its synonyms*.
-
由 Greg Molnar 提交于
-
由 Graham Conzett 提交于
-
由 Ryuta Kamizono 提交于
respect only_path option when an array is passed into url_for
-
由 Ryuta Kamizono 提交于
Deprecate ActionDispatch::Http::ParameterFilter in favor of ActiveSup…
-
由 Arun Agrawal 提交于
[ci skip] Fix typo
-
由 Francesco Rodríguez 提交于
-
由 Yoshiyuki Kinjo 提交于
-
由 Chris Fung 提交于
[ci skip]
-
由 Graham Conzett 提交于
Fix an issue in ActiveStorage where a direct upload to disk storage would fail due to a content type mismatch if the file was uploaded using a mime-type synonym.
-
- 07 10月, 2018 8 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Since #31575, `set_inverse_instance` replaces the foreign key by the current owner immediately to make it happen when a record is added to collection association. But `set_inverse_instance` is not only called when a record is added, but also when a record is loaded from queries. And also, that loaded records are not always associated records for some reason (using `or`, `unscope`, `rewhere`, etc). It is hard to distinguish whether or not we should invoke `set_inverse_instance`, but at least we should avoid the undesired side-effect which was brought from #31575. Fixes #34108.
-
由 Eileen M. Uchitelle 提交于
Fixtures refactor
-
由 Eileen M. Uchitelle 提交于
getting started page rails version update to 5.2.1
-
由 Madogiwa 提交于
-
由 Richard Schneeman 提交于
add test for cache_version precision
-
由 Lachlan Sylvester 提交于
-
- 06 10月, 2018 2 次提交
-
-
由 Yuji Yaginuma 提交于
ActiveStorage guide: Add instruction for test environment
-
由 Richard Schneeman 提交于
Array with single item correctly uses cache_key
-