1. 27 2月, 2018 1 次提交
    • A
      Don't enforce UTF-8 by default · 96eeea53
      Andrew White 提交于
      With the disabling of TLS 1.0 by most major websites, continuing to run
      IE8 or lower becomes increasingly difficult so default to not enforcing
      UTF-8 encoding as it's not relevant to other browsers.
      96eeea53
  2. 20 2月, 2018 1 次提交
  3. 13 2月, 2018 2 次提交
  4. 12 2月, 2018 1 次提交
    • C
      Respect --force option for config/master.key · 24284fd3
      claudiob 提交于
      This is similar to #30700 which ensures the `--quiet` option of `rails new`
      is respected by the `MasterKeyGenerator` (missing from #30067).
      
      Before this commit, running `rails new app --force` would still prompt the
      user what to do with the conflict in `config/master.key`:
      
      ```
                    …
         identical  config/locales/en.yml
          conflict  config/master.key
      Overwrite /Users/claudiob/Desktop/pizza/config/master.key? (enter "h" for help) [Ynaqdh]
      ```
      
      After this commit, `config/master.key` is overwritten:
      
      ```
                 …
      identical  config/locales/en.yml
          force  config/master.key
         append  .gitignore
      ```
      
      The newly added test generates an app and then generates it again with
      `--force`. Without this commit, the test would just wait forever for user
      input.
      24284fd3
  5. 11 1月, 2018 1 次提交
  6. 10 1月, 2018 1 次提交
    • B
      Clean up railties tests · b6ed9a7f
      bogdanvlviv 提交于
        Remove `AppGeneratorTest#test_active_storage_install`.
        The test is added by 67db41aa,
        since #31534 this test doesn't test anything.
      
        Remove redundant assertions in `SharedGeneratorTests`.
        These assertions is added by 4a835aa3.
        Follows 67db41aa, #31534.
      b6ed9a7f
  7. 26 12月, 2017 1 次提交
  8. 24 12月, 2017 1 次提交
  9. 19 12月, 2017 1 次提交
  10. 16 12月, 2017 1 次提交
    • Y
      Add `skip_bootsnap` option · 838b40da
      yuuji.yaginuma 提交于
      `bootsnap` is a useful gem normally. However, `bootsnap` is unnecessary
      when generating a Rails application to be used only for testing.
      So I want to control whether use this or not by option.
      838b40da
  11. 15 12月, 2017 1 次提交
  12. 05 12月, 2017 2 次提交
  13. 04 12月, 2017 1 次提交
  14. 03 12月, 2017 1 次提交
    • C
      Fix typo in test error message · a71bbed7
      claudiob 提交于
      With the current code, a failing test shows this error, which is missing
      the number of times called and has two periods at the end.
      
      ```
      /railties$ be ruby -Itest test/generators/app_generator_test.rb -n test_active_storage_install
      
      Failure:
      AppGeneratorTest#test_active_storage_install [test/generators/app_generator_test.rb:313]:
      active_storage:install expected to be called once, but was called  times..
      Expected: 1
        Actual: 2
      ```
      
      After the fix, the error message looks correct:
      
      ```
      /railties$ be ruby -Itest test/generators/app_generator_test.rb -n test_active_storage_install
      
      Failure:
      AppGeneratorTest#test_active_storage_install [test/generators/app_generator_test.rb:313]:
      active_storage:install expected to be called once, but was called 2 times.
      Expected: 1
        Actual: 2
      ```
      a71bbed7
  15. 28 11月, 2017 1 次提交
  16. 27 11月, 2017 2 次提交
  17. 16 11月, 2017 1 次提交
    • Y
      Add master key to `gitignore` on `rails new` · f27319a7
      yuuji.yaginuma 提交于
      We generate master key on `rails new`.
      Therefore, if do not add master key to `.gitginore` on `rails new`as
      well, there is a possibility that the master key will be committed
      accidentally.
      f27319a7
  18. 09 11月, 2017 1 次提交
  19. 08 11月, 2017 1 次提交
  20. 07 11月, 2017 2 次提交
    • B
      `rails new` runs `rails active_storage:install` · 0835527d
      bogdanvlviv 提交于
      Omit `rails activestorage:install` for jdbcmysql, jdbc and shebang tests
      
      AppGeneratorTest#test_config_jdbcmysql_database
      
        rails aborted!
        LoadError: Could not load 'active_record/connection_adapters/mysql_adapter'.
        Make sure that the adapter in config/database.yml is valid.
        If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add
        the necessary adapter gem to the Gemfile.
        (compressed)
        bin/rails:4:in `<main>'
        Tasks: TOP => activestorage:install => environment
        (See full trace by running task with --trace)
      
      AppGeneratorTest#test_config_jdbc_database
      
        rails aborted!
        LoadError: Could not load 'active_record/connection_adapters/jdbc_adapter'.
        Make sure that the adapter in config/database.yml is valid.
        If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add
        the necessary adapter gem to the Gemfile.
        (compressed)
        bin/rails:4:in `<main>'
        Tasks: TOP => activestorage:install => environment
        (See full trace by running task with --trace)
      
      AppGeneratorTest#test_shebang_is_added_to_rails_file
      
        /home/ubuntu/.rbenv/versions/2.4.1/bin/ruby: no Ruby script found in input (LoadError)
      
      Prevent PendingMigrationError in tests
      
       * Run `bin/rails db:migrate RAILS_ENV=test` in test_cases before start tests to prevent PendingMigrationError
       * FileUtils.rm_r("db/migrate")
       * --skip-active-storage
      
      Fix failed tests in `railties/test/railties/engine_test.rb`
      
      Related to #30111
      
      Imporve `SharedGeneratorTests#test_default_frameworks_are_required_when_others_are_removed`
      
       - Explicitly skip active_storage
       - Ensure that skipped frameworks are commented
       - Ensure that default frameworks are not commented
      
      Fix error `Errno::ENOSPC: No space left on device - sendfile`
      
      Since `rails new` runs `rails active_storage:install`
      that boots an app.
      
      Since adding Bootsnap 0312a5c6
      during booting an app, it creates the cache:
      
         264K    tmp/cache/bootsnap-load-path-cache
         27M     tmp/cache/bootsnap-compile-cache
      
      * teardown_app must remove app
      0835527d
    • B
      Add --skip-active-storage and do so automatically when --skip-active-record is used · 4a835aa3
      bogdanvlviv 提交于
      Closes #30102
      
      Revert part 787fe90d
      
      --skip-active-storage pass throughs `rails plugin new`
      
      Add changelog entry about default initialization of Active Storage
      4a835aa3
  21. 18 10月, 2017 1 次提交
  22. 25 9月, 2017 1 次提交
  23. 12 9月, 2017 1 次提交
    • D
      Add credentials using a generic EncryptedConfiguration class (#30067) · 69f976b8
      David Heinemeier Hansson 提交于
      * WIP: Add credentials using a generic EncryptedConfiguration class
      
      This is sketch code so far.
      
      * Flesh out EncryptedConfiguration and test it
      
      * Better name
      
      * Add command and generator for credentials
      
      * Use the Pathnames
      
      * Extract EncryptedFile from EncryptedConfiguration and add serializers
      
      * Test EncryptedFile
      
      * Extract serializer validation
      
      * Stress the point about losing comments
      
      * Allow encrypted configuration to be read without parsing for display
      
      * Use credentials by default and base them on the master key
      
      * Derive secret_key_base in test/dev, source it from credentials in other envs
      
      And document the usage.
      
      * Document the new credentials setup
      
      * Stop generating the secrets.yml file now that we have credentials
      
      * Document what we should have instead
      
      Still need to make it happen, tho.
      
      * [ci skip] Keep wording to `key base`; prefer defaults.
      
      Usually we say we change defaults, not "spec" out a release.
      
      Can't use backticks in our sdoc generated documentation either.
      
      * Abstract away OpenSSL; prefer MessageEncryptor.
      
      * Spare needless new when raising.
      
      * Encrypted file test shouldn't depend on subclass.
      
      * [ci skip] Some woordings.
      
      * Ditch serializer future coding.
      
      * I said flip it. Flip it good.
      
      * [ci skip] Move require_master_key to the real production.rb.
      
      * Add require_master_key to abort the boot process.
      
      In case the master key is required in a certain environment
      we should inspect that the key is there and abort if it isn't.
      
      * Print missing key message and exit immediately.
      
      Spares us a lengthy backtrace and prevents further execution.
      
      I've verified the behavior in a test app, but couldn't figure the
      test out as loading the app just exits immediately with:
      
      ```
      /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `load': marshal data too short (ArgumentError)
      	from /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `run'
      	from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest.rb:830:in `run_one_method'
      	from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest/parallel.rb:32:in `block (2 levels) in start'
      ```
      
      It's likely we need to capture and prevent the exit somehow.
      Kernel.stub(:exit) didn't work. Leaving it for tomorrow.
      
      * Fix require_master_key config test.
      
      Loading the app would trigger the `exit 1` per require_master_key's
      semantics, which then aborted the test.
      
      Fork and wait for the child process to finish, then inspect the
      exit status.
      
      Also check we aborted because of a missing master key, so something
      else didn't just abort the boot.
      
      Much <3 to @tenderlove for the tip.
      
      * Support reading/writing configs via methods.
      
      * Skip needless deep symbolizing.
      
      * Remove save; test config reader elsewhere.
      
      * Move secret_key_base check to when we're reading it.
      
      Otherwise we'll abort too soon since we don't assign the secret_key_base
      to secrets anymore.
      
      * Add missing string literal comments; require unneeded yaml require.
      
      * ya ya ya, rubocop.
      
      * Add master_key/credentials after bundle.
      
      Then we can reuse the existing message on `rails new bc4`.
      
      It'll look like:
      
      ```
      Using web-console 3.5.1 from https://github.com/rails/web-console.git (at master@ce985eb)
      Using rails 5.2.0.alpha from source at `/Users/kasperhansen/Documents/code/rails`
      Using sass-rails 5.0.6
      Bundle complete! 16 Gemfile dependencies, 72 gems now installed.
      Use `bundle info [gemname]` to see where a bundled gem is installed.
      Adding config/master.key to store the master encryption key: 97070158c44b4675b876373a6bc9d5a0
      
      Save this in a password manager your team can access.
      
      If you lose the key, no one, including you, can access anything encrypted with it.
      
            create  config/master.key
      ```
      
      And that'll be executed even if `--skip-bundle` was passed.
      
      * Ensure test app has secret_key_base.
      
      * Assign secret_key_base to app or omit.
      
      * Merge noise
      
      * Split options for dynamic delegation into its own method and use deep symbols to make it work
      
      * Update error to point to credentials instead
      
      * Appease Rubocop
      
      * Validate secret_key_base when reading it.
      
      Instead of relying on the validation in key_generator move that into
      secret_key_base itself.
      
      * Fix generator and secrets test.
      
      Manually add config.read_encrypted_secrets since it's not there by default
      anymore.
      
      Move mentions of config/secrets.yml to config/credentials.yml.enc.
      
      * Remove files I have no idea how they got here.
      
      * [ci skip] swap secrets for credentials.
      
      * [ci skip] And now, changelogs are coming.
      69f976b8
  24. 17 8月, 2017 1 次提交
  25. 16 8月, 2017 2 次提交
  26. 15 8月, 2017 2 次提交
  27. 13 8月, 2017 1 次提交
  28. 12 8月, 2017 1 次提交
  29. 10 8月, 2017 3 次提交
  30. 02 8月, 2017 1 次提交
  31. 01 8月, 2017 2 次提交