- 12 11月, 2017 2 次提交
-
-
由 Ryuta Kamizono 提交于
Remove unused require
-
由 yuuji.yaginuma 提交于
-
- 11 11月, 2017 4 次提交
-
-
由 Ryuta Kamizono 提交于
Follow up of #30360.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Attribute modules (`Attribute`, `Attributes`, `AttributeSet`) uses `Type`, but referencing `Type` before the modules still fail. ``` % ./bin/test -w test/cases/attribute_test.rb -n test_with_value_from_user_validates_the_value Run options: -n test_with_value_from_user_validates_the_value --seed 31876 E Error: ActiveModel::AttributeTest#test_with_value_from_user_validates_the_value: NameError: uninitialized constant ActiveModel::AttributeTest::Type /Users/kamipo/src/github.com/rails/rails/activemodel/test/cases/attribute_test.rb:233:in `block in <class:AttributeTest>' bin/test test/cases/attribute_test.rb:232 Finished in 0.002985s, 335.0479 runs/s, 335.0479 assertions/s. 1 runs, 1 assertions, 0 failures, 1 errors, 0 skips ``` Probably we need more autoloading at least `Type`.
-
由 Ryuta Kamizono 提交于
`joins_values.partition` will break joins values order. It should be kept as user intended order. Fixes #15488.
-
- 10 11月, 2017 32 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Fixes #21577.
-
由 Ryuta Kamizono 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
-
由 Andrew White 提交于
Remove code duplication in ActiveSupport::Cache
-
由 Ryuta Kamizono 提交于
Add missing requires
-
由 yuuji.yaginuma 提交于
Currently, executing the test with only `attribute_test.rb` results in an error. ``` ./bin/test -w test/cases/attribute_test.rb Run options: --seed 41205 # Running: ....E Error: ActiveModel::AttributeTest#test_attributes_do_not_equal_attributes_with_different_types: NameError: uninitialized constant ActiveModel::AttributeTest::Type rails/activemodel/test/cases/attribute_test.rb:159:in `block in <class:AttributeTest>' bin/test test/cases/attribute_test.rb:158 ``` Added a missing require to fix this.
-
由 Ryuta Kamizono 提交于
They are only different by one line of code which doesn't deserve a hierarchy of 7 classes. Closes #31079. [Ryuta Kamizono & Bogdan Gusiev]
-
由 Akira Matsuda 提交于
Fix RDoc and Rake URL
-
由 aycabta 提交于
-
由 aycabta 提交于
-
由 Ryuta Kamizono 提交于
Fix ruby warnings in Active Model
-
由 yuuji.yaginuma 提交于
-
由 Ryuta Kamizono 提交于
Use `-e` option to specify the environment in console command [ci skip]
-
由 Ryuta Kamizono 提交于
Add missing requires
-
由 Ryuta Kamizono 提交于
Remove unused require
-
由 yuuji.yaginuma 提交于
This is no longer used since fd6aaaa0.
-
由 yuuji.yaginuma 提交于
Currently, executing the test with only `attribute_set_test.rb` results in an error. ``` ./bin/test -w test/cases/attribute_set_test.rb Run options: --seed 33470 # Running: E Error: ActiveModel::AttributeSetTest#test_#map_returns_a_new_attribute_set_with_the_changes_applied: NameError: uninitialized constant ActiveModel::AttributeSetTest::AttributeSet Did you mean? ActiveModel::Attributes ActiveModel::Attribute activemodel/test/cases/attribute_set_test.rb:235:in `block in <class:AttributeSetTest>' bin/test test/cases/attribute_set_test.rb:234 ``` Added a missing require to fix this. Also, I suspect that this is the cause of failures in CI. Ref: https://travis-ci.org/rails/rails/jobs/299994708
-
由 yuuji.yaginuma 提交于
-
由 yuuji.yaginuma 提交于
Passing the environment's name as a regular argument is deprecated in 48b24992.
-
由 Guillermo Iguaran 提交于
Bump RuboCop to 0.51.0
-
由 Koichi ITO 提交于
## Summary RuboCop 0.51.0 was released. https://github.com/bbatsov/rubocop/releases/tag/v0.51.0 And rubocop-0-51 channel is available in Code Climate. https://github.com/codeclimate/codeclimate-rubocop/issues/109 This PR will bump RuboCop to 0.51.0 and fixes the following new offenses. ```console % bundle exec rubocop Inspecting 2358 files (snip) Offenses: actionpack/lib/action_controller/metal/http_authentication.rb:251:59: C: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. [key.strip, value.to_s.gsub(/^"|"$/, "").delete('\'')] ^^^^ activesupport/test/core_ext/load_error_test.rb:8:39: C: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. assert_raise(LoadError) { require 'no_this_file_don\'t_exist' } ^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2358 files inspected, 2 offenses detected ```
-
由 Rafael França 提交于
Fixed typo in test for activesupport parameterize
-
由 Rafael França 提交于
Simplify implementation of `MySQLDatabaseTasks`
-
由 Rafael França 提交于
Set counter caches to correct values in fixtures
-
由 Rafael França 提交于
Move Attribute and AttributeSet to ActiveModel
-
由 Lisa Ugray 提交于
Use these to back the attributes API. Stop automatically including ActiveModel::Dirty in ActiveModel::Attributes, and make it optional.
-
由 Rafael França 提交于
field_error_proc wrap form select optgroup and separator option
-
由 Rafael Mendonça França 提交于
Use `Tempfile.create`
-
由 neumayr 提交于
### Summary The [`:field_error_proc`](https://github.com/rails/rails/blob/master/actionview/lib/action_view/base.rb#L145) is responsible for decorating input tags that refer to attributes with errors. This default build-in rails feature wrap invalid form elements with additional markup: `<div class="field_with_errors">[…]</div>`. * Fix for `field_error_proc` wraps form select `optgroup` * Fix for `field_error_proc` wraps form select divider `option` * Add tests for uncovered elements with errors [Fixes #31088] #### Test coverage * `test_select_grouped_options_with_errors` * `test_time_zone_select_with_priority_zones_and_errors` #### Extend test coverage * `test_collection_select_with_errors` * `test_label_with_errors` * `test_check_box_with_errors` * `test_check_boxes_with_errors` * `test_radio_button_with_errors` * `test_radio_buttons_with_errors` * `test_collection_check_boxes_with_errors` * `test_collection_radio_buttons_with_errors`
- 09 11月, 2017 2 次提交
-
-
由 Bogdan Gusiev 提交于
-
由 Andrew White 提交于
Allow `Range#include?` on TWZ ranges
-