1. 06 1月, 2014 5 次提交
    • A
      Add CHANGELOG entry for #10634 [ci skip] · a1564d47
      Andrew White 提交于
      a1564d47
    • A
      Merge pull request #10634 from teleological/time_advance_gregorian · ffc27357
      Andrew White 提交于
      Maintain proleptic gregorian in Time#advance
      ffc27357
    • R
      Merge pull request #13598 from zirni/remove_ar_warnings · 6e867a4d
      Rafael Mendonça França 提交于
      Remove method redefined warnings for test suite
      
      Closes #13526
      6e867a4d
    • M
      Remove method redefined warnings for test suite · bf556880
      Matthias Zirnstein 提交于
      has_many definitions with "name" as singular and as plural e.g.
        has_many :welcome_posts_with_comment
        has_many :welcome_posts_with_comments
      
      Ruby mentions it with:
      
      lib/active_record/associations/builder/collection_association.rb:65:
        warning: method redefined; discarding old welcome_posts_with_comment_ids
      lib/active_record/associations/builder/collection_association.rb:65:
        warning: previous definition of welcome_posts_with_comment_ids was here
      lib/active_record/associations/builder/collection_association.rb:75:
        warning: method redefined; discarding old welcome_posts_with_comment_ids=
      lib/active_record/associations/builder/collection_association.rb:75:
        warning: previous definition of welcome_posts_with_comment_ids= was here
      bf556880
    • G
      Switched to use `display:none` in extra_tags_for_form method. · 7a085dac
      Gaelian Ditchburn 提交于
      The use of `display:inline` with the content_tag call in the
      extra_tags_for_form method potentially causes display issues with some
      browsers, namely Internet Explorer. IE's behaviour of not collapsing
      the line height on divs with ostensibly no content means that the
      automatically added div containing the hidden authenticity_token, utf8
      and _method form input tags may interfere with other visible form
      elements in certain circumstances. The use of `display:none` rather
      than `display:inline` fixes this problem.
      
      Fixes #6403
      7a085dac
  2. 05 1月, 2014 7 次提交
    • A
      Unique the segment keys array for non-optimized url helpers · 6b548830
      Andrew White 提交于
      In Rails 3.2 you only needed pass an argument for dynamic segment once so
      unique the segment keys array to match the number of args. Since the number
      of args is less than required parts the non-optimized code path is selected.
      This means to benefit from optimized url generation the arg needs to be
      specified as many times as it appears in the path.
      
      Fixes #12808
      6b548830
    • A
      Show full route constraints in error message · 892c5395
      Andrew White 提交于
      When an optimized helper fails to generate, show the full route constraints
      in the error message. Previously it would only show the contraints that were
      required as part of the path.
      
      Fixes #13592
      892c5395
    • A
      Simplify arg parameterization · b9efc74f
      Andrew White 提交于
      b9efc74f
    • A
      Use a custom route vistor for optimized route generation · d017e92e
      Andrew White 提交于
      Using a Regexp to replace dynamic segments in a path string is fraught
      with difficulty and can lead to odd edge cases like #13349. Since we
      already have a parsed representation of the path it makes sense to use
      that to generate an array of segments that can be used to build an
      optimized route's path quickly.
      
      Tests on a simple route (e.g. /posts/:id) show a speedup of 35%:
      https://gist.github.com/pixeltrix/8261932
      
      Calculating -------------------------------------
          Current Helper:       5274 i/100ms
          New Helper:           8050 i/100ms
      -------------------------------------------------
          Current Helper:     79263.6 (±3.7%) i/s -     395550 in   4.997252s
          New Helper:        153464.5 (±4.9%) i/s -     772800 in   5.047834s
      
      Tests on a more complex route show even an greater performance boost:
      https://gist.github.com/pixeltrix/8261957
      
      Calculating -------------------------------------
          Current Helper:       2367 i/100ms
          New Helper:           5382 i/100ms
      -------------------------------------------------
          Current Helper:     29506.0 (±3.2%) i/s -     149121 in   5.059294s
          New Helper:         78815.5 (±4.1%) i/s -     398268 in   5.062161s
      
      It also has the added benefit of fixing the edge cases described above.
      
      Fixes #13349
      d017e92e
    • R
      Merge pull request #13590 from kuldeepaggarwal/fix-date-helper-doc · 339ce7fe
      Rafael Mendonça França 提交于
      provide correct example of `datetime_select` helper [ci skip]
      339ce7fe
    • A
      Add preview_path to autoload_paths in after_initialize · 3713e433
      Andrew White 提交于
      Only config.autoload_paths is frozen, so add the preview_path
      to ActiveSupport::Dependencies.autoload_paths directly in an
      after_initialize block. Also protect against a blank preview_path
      being added to autoload_paths which can cause a serious slowdown
      as Dir[] tries to load all *_preview.rb files under /
      
      Fixes #13372
      3713e433
    • K
      e9bfeb0c
  3. 04 1月, 2014 16 次提交
  4. 03 1月, 2014 5 次提交
  5. 02 1月, 2014 7 次提交