- 06 1月, 2014 5 次提交
-
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Maintain proleptic gregorian in Time#advance
-
由 Rafael Mendonça França 提交于
Remove method redefined warnings for test suite Closes #13526
-
由 Matthias Zirnstein 提交于
has_many definitions with "name" as singular and as plural e.g. has_many :welcome_posts_with_comment has_many :welcome_posts_with_comments Ruby mentions it with: lib/active_record/associations/builder/collection_association.rb:65: warning: method redefined; discarding old welcome_posts_with_comment_ids lib/active_record/associations/builder/collection_association.rb:65: warning: previous definition of welcome_posts_with_comment_ids was here lib/active_record/associations/builder/collection_association.rb:75: warning: method redefined; discarding old welcome_posts_with_comment_ids= lib/active_record/associations/builder/collection_association.rb:75: warning: previous definition of welcome_posts_with_comment_ids= was here
-
由 Gaelian Ditchburn 提交于
The use of `display:inline` with the content_tag call in the extra_tags_for_form method potentially causes display issues with some browsers, namely Internet Explorer. IE's behaviour of not collapsing the line height on divs with ostensibly no content means that the automatically added div containing the hidden authenticity_token, utf8 and _method form input tags may interfere with other visible form elements in certain circumstances. The use of `display:none` rather than `display:inline` fixes this problem. Fixes #6403
-
- 05 1月, 2014 7 次提交
-
-
由 Andrew White 提交于
In Rails 3.2 you only needed pass an argument for dynamic segment once so unique the segment keys array to match the number of args. Since the number of args is less than required parts the non-optimized code path is selected. This means to benefit from optimized url generation the arg needs to be specified as many times as it appears in the path. Fixes #12808
-
由 Andrew White 提交于
When an optimized helper fails to generate, show the full route constraints in the error message. Previously it would only show the contraints that were required as part of the path. Fixes #13592
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Using a Regexp to replace dynamic segments in a path string is fraught with difficulty and can lead to odd edge cases like #13349. Since we already have a parsed representation of the path it makes sense to use that to generate an array of segments that can be used to build an optimized route's path quickly. Tests on a simple route (e.g. /posts/:id) show a speedup of 35%: https://gist.github.com/pixeltrix/8261932 Calculating ------------------------------------- Current Helper: 5274 i/100ms New Helper: 8050 i/100ms ------------------------------------------------- Current Helper: 79263.6 (±3.7%) i/s - 395550 in 4.997252s New Helper: 153464.5 (±4.9%) i/s - 772800 in 5.047834s Tests on a more complex route show even an greater performance boost: https://gist.github.com/pixeltrix/8261957 Calculating ------------------------------------- Current Helper: 2367 i/100ms New Helper: 5382 i/100ms ------------------------------------------------- Current Helper: 29506.0 (±3.2%) i/s - 149121 in 5.059294s New Helper: 78815.5 (±4.1%) i/s - 398268 in 5.062161s It also has the added benefit of fixing the edge cases described above. Fixes #13349
-
由 Rafael Mendonça França 提交于
provide correct example of `datetime_select` helper [ci skip]
-
由 Andrew White 提交于
Only config.autoload_paths is frozen, so add the preview_path to ActiveSupport::Dependencies.autoload_paths directly in an after_initialize block. Also protect against a blank preview_path being added to autoload_paths which can cause a serious slowdown as Dir[] tries to load all *_preview.rb files under / Fixes #13372
-
由 Kuldeep Aggarwal 提交于
-
- 04 1月, 2014 16 次提交
-
-
由 Robin Dupret 提交于
Fixed truncate documentation. [ci skip]
-
由 Konstantin Wlasow 提交于
-
由 Jon Leighton 提交于
The line was duplicated
-
由 Jon Leighton 提交于
-
由 Xavier Noria 提交于
Change all "can not"s to the correct "cannot"
-
由 T.J. Schuck 提交于
-
由 Guillermo Iguaran 提交于
mem_cache_store requires dalli, so only accept dalli/client
-
由 Arthur Neves 提交于
:mem_cache_store should receive a list of hosts or a dalli client, otherwise raise it. Also adding a changelog.
-
由 Robin Dupret 提交于
-
由 Rafael Mendonça França 提交于
Change CollectionProxy#select to take the same arguments as ActiveRecord::select
-
由 Arthur Neves 提交于
:mem_cache_store require dalli, rescue Dalli exceptions, and follow Dalli API. Memcached gem, for instance, doesnt work anymore, as the API are different. As we already require one client, we should make sure that client works, and not accept others, and if someone wants to use another memcache client they can write their own store adapter.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Fix documentation for end_year option of date_helper [ci skip]
-
由 Rafael Mendonça França 提交于
-
由 Godfrey Chan 提交于
Previously, this would give an `ArgumentError`: class Issue < ActiveRecord::Base enum :status, [:open, :finished] end Issue.open.build # => ArgumentError: '0' is not a valid status Issue.open.create # => ArgumentError: '0' is not a valid status PR #13542 muted the error, but the issue remains. This commit fixes the issue by allowing the enum value to be written directly via the setter: Issue.new.status = 0 # This now sets status to :open Assigning a value directly via the setter like this is not part of the documented public API, so users should not rely on this behavior. Closes #13530.
-
由 Prathamesh Sonpatki 提交于
- While editing an existing record, end_year is equal to current selected year plus 5 by default. - While editing an existing record, start_year is equal to current selected year value minus 5 by default. - Fixes #13552 Acked-by: NPrathamesh Sonpatki <csonpatki@gmail.com> Acked-by: NPrathamesh Sonpatki <csonpatki@gmail.com>
-
- 03 1月, 2014 5 次提交
-
-
由 Yves Senn 提交于
These methods were only used for the `IdentityMap` which was removed. They are no longer used internally and should be removed without replacement. As they were not `:nodoc:`'ed it's better to deprecate them before removal.
-
由 Rafael Mendonça França 提交于
Use DATABASE_URL by default
-
由 schneems 提交于
See https://github.com/rails/rails/pull/13463#issuecomment-31480799 for full conversation.
-
由 Rafael Mendonça França 提交于
provide correct information [ci skip]
-
由 Jon Leighton 提交于
Automatically maintain test database schema
-
- 02 1月, 2014 7 次提交
-
-
由 Kuldeep Aggarwal 提交于
-
由 Jon Leighton 提交于
* Move check from generated helper to test_help.rb, so that all applications can benefit * Rather than just raising when the test schema has pending migrations, try to load in the schema and only raise if there are pending migrations afterwards * Opt out of the check by setting config.active_record.maintain_test_schema = false * Deprecate db:test:* tasks. The test helper is now fully responsible for maintaining the test schema, so we don't need rake tasks for this. This is also a speed improvement since we're no longer reloading the test database on every call to "rake test".
-
由 Andrew White 提交于
Ruby 2.1.0 includes the json gem 1.8.1 by default so we need bundler 1.5.1 for `bundle install` to work. To fix this reverse the downgrade to 1.3.5 and wrap the `run_generator` call with a block that resets `THOR_DEBUG`.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Since rbx and jruby builds are being allowed to fail lets receive the build information early enabling this option See http://about.travis-ci.org/blog/2013-11-27-fast-finishing-builds/
-
由 Rafael Mendonça França 提交于
Move default production database to URL sub key
-
由 Andrew White 提交于
Bundler sets the THOR_DEBUG environment variable causing Thor to re-raise exceptions on exit. This is breaking the railties tests for generators where we are trying to capture error output. The PR bundler/bundler#2794 fixes this by adding a per-instance config `:debug` but this has not been released yet so to prevent errors going unnoticed downgrade bundler to 1.3.5 until such a time that 1.5.2 has been released.
-