1. 24 6月, 2018 1 次提交
  2. 21 6月, 2018 1 次提交
  3. 31 5月, 2018 1 次提交
  4. 28 5月, 2018 1 次提交
  5. 23 5月, 2018 1 次提交
  6. 02 5月, 2018 1 次提交
  7. 29 4月, 2018 1 次提交
    • U
      Make Railties CI log for Ruby 2.6 accessible again · f4eca1d6
      utilum 提交于
      Pending the next release of Thor which [fixes](https://github.com/erikhuda/thor/commit/006832ea32480618791f89bb7d9e67b22fc814b9) calls to `ERB.new`, Railties CI log for Ruby 2.6 is flooded with so many warnings it is too long for Travis to handle:
      
      ```
      /home/travis/.rvm/gems/ruby-head/gems/thor-0.20.0/lib/thor/actions/file_manipulation.rb:120: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
      /home/travis/.rvm/gems/ruby-head/gems/thor-0.20.0/lib/thor/actions/file_manipulation.rb:120: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
      /home/travis/.rvm/gems/ruby-head/gems/thor-0.20.0/lib/thor/actions/file_manipulation.rb:120: warning: Passing eoutvar with the 4th argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, eoutvar: ...) instead.
      
      The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).
      
      The job has been terminated
      ```
      
      https://travis-ci.org/rails/rails/jobs/372623604#L10000
      https://api.travis-ci.org/v3/job/372623604/log.txt
      
      This patch forces installation of fixed Thor, and enables us to look at the the log.
      f4eca1d6
  8. 25 4月, 2018 1 次提交
  9. 22 4月, 2018 1 次提交
    • B
      Rubocop 0.54 · e236454a
      Bart de Water 提交于
      Fix `.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout` warning
      e236454a
  10. 18 4月, 2018 1 次提交
    • J
      Use ImageProcessing gem for ActiveStorage variants · ca129685
      Janko Marohnić 提交于
      ImageProcessing gem is a wrapper around MiniMagick and ruby-vips, and
      implements an interface for common image resizing and processing. This
      is the canonical image processing gem recommended in [Shrine], and
      that's where it developed from. The initial implementation was extracted
      from Refile, which also implements on-the-fly transformations.
      
      Some features that ImageProcessing gem adds on top of MiniMagick:
      
        * resizing macros
          - #resize_to_limit
          - #resize_to_fit
          - #resize_to_fill
          - #resize_and_pad
        * automatic orientation
        * automatic thumbnail sharpening
        * avoids the complex and inefficient MiniMagick::Image class
        * will use "magick" instead of "convert" on ImageMagick 7
      
      However, the biggest feature of the ImageProcessing gem is that it has
      an alternative implementation that uses libvips. Libvips is an
      alternative to ImageMagick that can process images very rapidly (we've
      seen up 10x faster than ImageMagick).
      
      What's great is that the ImageProcessing gem provides the same interface
      for both implementations. The macros are named the same, and the libvips
      implementation does auto orientation and thumbnail sharpening as well;
      only the operations/options specific to ImageMagick/libvips differ. The
      integration provided by this PR should work for both implementations.
      
      The plan is to introduce the ImageProcessing backend in Rails 6.0 as the
      default backend and deprecate the MiniMagick backend, then in Rails 6.1
      remove the MiniMagick backend.
      ca129685
  11. 11 4月, 2018 3 次提交
  12. 07 4月, 2018 2 次提交
  13. 06 4月, 2018 1 次提交
  14. 28 3月, 2018 1 次提交
  15. 23 3月, 2018 1 次提交
  16. 22 3月, 2018 2 次提交
    • R
      Fix `test_config_another_database` failure · 958c5ad9
      Ryuta Kamizono 提交于
      Somehow `test_config_another_database` didn't fail on CI, but it will
      fail locally.
      
      https://travis-ci.org/rails/rails/jobs/356212950#L2474-L2482
      
      ```
      % bundle exec ruby -w -Itest test/generators/app_generator_test.rb -n test_config_another_database
      Run options: -n test_config_another_database --seed 7260
      
      # Running:
      
      F
      
      Failure:
      AppGeneratorTest#test_config_another_database [test/generators/app_generator_test.rb:417]:
      Expected /^\s*gem\s+["']mysql2["'], '~> 0.4.4'$*/ to match "source 'https://rubygems.org'\ngit_source(:github) { |repo| \"https://github.com/\#{repo}.git\" }\n\nruby '2.5.0'\n\n# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'\ngem 'rails', '~> 6.0.0.alpha'\n# Use mysql as the database for Active Record\ngem 'mysql2', '>= 0.4.4', '< 0.6.0'\n# Use Puma as the app server\ngem 'puma', '~> 3.11'\n# Use SCSS for stylesheets\ngem 'sass-rails', '~> 5.0'\n# Use Uglifier as compressor for JavaScript assets\ngem 'uglifier', '>= 1.3.0'\n# See https://github.com/rails/execjs#readme for more supported runtimes\n# gem 'mini_racer', platforms: :ruby\n\n# Use CoffeeScript for .coffee assets and views\ngem 'coffee-rails', '~> 4.2'\n# Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks\ngem 'turbolinks', '~> 5'\n# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder\ngem 'jbuilder', '~> 2.5'\n# Use Redis adapter to run Action Cable in production\n# gem 'redis', '~> 4.0'\n# Use ActiveModel has_secure_password\n# gem 'bcrypt', '~> 3.1.7'\n\n# Use ActiveStorage variant\n# gem 'mini_magick', '~> 4.8'\n\n# Use Capistrano for deployment\n# gem 'capistrano-rails', group: :development\n\n# Reduces boot times through caching; required in config/boot.rb\ngem 'bootsnap', '>= 1.1.0', require: false\n\ngroup :development, :test do\n  # Call 'byebug' anywhere in the code to stop execution and get a debugger console\n  gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]\nend\n\ngroup :development do\n  # Access an interactive console on exception pages or by calling 'console' anywhere in the code.\n  gem 'web-console', '>= 3.3.0'\n  gem 'listen', '>= 3.0.5', '< 3.2'\n  # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring\n  gem 'spring'\n  gem 'spring-watcher-listen', '~> 2.0.0'\nend\n\ngroup :test do\n  # Adds support for Capybara system testing and selenium driver\n  gem 'capybara', '>= 2.15', '< 4.0'\n  gem 'selenium-webdriver'\n  # Easy installation and use of chromedriver to run system tests with Chrome\n  gem 'chromedriver-helper'\nend\n\n# Windows does not include zoneinfo files, so bundle the tzinfo-data gem\ngem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]\n".
      
      bin/rails test test/generators/app_generator_test.rb:411
      
      Finished in 0.174681s, 5.7247 runs/s, 34.3483 assertions/s.
      1 runs, 6 assertions, 1 failures, 0 errors, 0 skips
      ```
      958c5ad9
    • A
      Update loofah to mitigate CVE-2018-8048 · 627ef063
      Andrew White 提交于
      See flavorjones/loofah#144
      627ef063
  17. 20 3月, 2018 1 次提交
  18. 15 3月, 2018 1 次提交
  19. 10 3月, 2018 1 次提交
  20. 06 3月, 2018 2 次提交
  21. 23 2月, 2018 1 次提交
  22. 21 2月, 2018 1 次提交
  23. 16 2月, 2018 1 次提交
  24. 15 2月, 2018 1 次提交
  25. 14 2月, 2018 1 次提交
  26. 07 2月, 2018 3 次提交
  27. 31 1月, 2018 1 次提交
  28. 27 1月, 2018 1 次提交
    • D
      Relax minitest version · defa880f
      Daniel Colson 提交于
      We locked Minitest to 5.11.1 in #31799
      because 5.11.2 included a breaking change.
      The change was fixed in 5.11.3, so we no
      longer need to lock in the version.
      defa880f
  29. 26 1月, 2018 1 次提交
  30. 19 1月, 2018 2 次提交
  31. 16 1月, 2018 1 次提交
  32. 12 1月, 2018 1 次提交