- 03 7月, 2018 7 次提交
-
-
由 alpaca-tc 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Currently, the seen object cache is shared if join nodes have the same target class. But it is a wrong assumption, we can't share the seen object cache between different join nodes (e.g. `:readonly_account` and `:accounts` have the same target class `Account`, but the instances have the different state `readonly`). Fixes #26805. Closes #27737.
-
由 Kasper Timm Hansen 提交于
Change location for running copy migrations command
-
由 Ryuta Kamizono 提交于
Support readonly option in SQLite3Adapter
-
由 Carl Brasic 提交于
Readonly sqlite database files are very useful as a data format for storing configuration/lookup data that is too complicated for YAML files. But since such files would typically be committed to a source control repository, it's important to ensure that they are truly safe from being inadvertently modified. Unfortunately using unix permissions isn't enough, as sqlite will "helpfully" add the write bit to a database file whenever it's written to. sqlite3-ruby has supported a `:readonly` option since version 1.3.2 (see https://github.com/sparklemotion/sqlite3-ruby/commit/c20c9f5dd2990042) This simply passes that option through to the adapter if present in the config hash. I think this is best considered an adapter-specific option since no other supported database has an identical concept.
-
- 02 7月, 2018 3 次提交
-
-
由 Kasper Timm Hansen 提交于
[ci skip] fix error of a file name
-
由 sohopro 提交于
-
由 Kasper Timm Hansen 提交于
Fix app:update when hyphenated name is given
-
- 01 7月, 2018 5 次提交
-
-
由 Kasper Timm Hansen 提交于
It breaks Active Job when run in isolation. E.g. bin/test test/cases/logging_test.rb: https://travis-ci.org/rails/rails/jobs/398779028 Consider Rafaels suggestion of reviewing the eager loading instead: https://github.com/rails/rails/pull/33234#issuecomment-401027419 This reverts commit cb0fdaac, reversing changes made to a0a1abb3.
-
由 Kasper Timm Hansen 提交于
Firstly, increment and decrement shouldn't care about the particulars of key expiry. They should only know that they have to pass that responsibility on to somewhere else. Secondly, it moves the key normalization back inside the instrumentation like it was originally. I think that matches the original design intention or at the very least it lets users catch haywire key truncation. Thirdly, it moves the changelog entry to the top of the file, where new entries go. I couldn't understand what the entry was saying so I tried to rewrite it.
-
由 Kasper Timm Hansen 提交于
Fix assignment of TESTOPTS in railties test task
-
由 Ryuta Kamizono 提交于
Allow `queue` option to `assert_no_enqueued_jobs`
-
- 30 6月, 2018 9 次提交
-
-
由 bogdanvlviv 提交于
It can be asserted that no jobs are enqueued to a specific queue: ```ruby def test_no_logging assert_no_enqueued_jobs queue: 'default' do LoggingJob.set(queue: :some_queue).perform_later end end ```
-
由 Ryuta Kamizono 提交于
Fix Ruby warnings tickled by the test suite
-
由 Ryuta Kamizono 提交于
Clarify activejob/lib/active_job/test_helper.rb
-
由 Ryuta Kamizono 提交于
Remove erroneous remove_column option from example [ci skip]
-
由 utilum 提交于
-
由 Ryuta Kamizono 提交于
Fix Cache :redis_store increment/decrement ttl check and add more tests.
-
由 Jason Lee 提交于
-
由 bogdanvlviv 提交于
Rename `in_block_job` to `enqueued_job` since this variable can refer not only to jobs that were created in the block. See #33258. Return back accidentally removed test to activejob/test/cases/test_helper_test.rb See #33258. Fix name of tests.
-
由 George Semenov 提交于
-
- 29 6月, 2018 11 次提交
-
-
由 Rafael França 提交于
Fix docs of `assert_no_emails` [ci skip]
-
由 bogdanvlviv 提交于
`assert_no_emails` is shortcut for `assert_emails 0, &block`.
-
由 Rafael França 提交于
Allow call `assert_enqueued_with` and `assert_enqueued_email_with` with no block
-
由 bogdanvlviv 提交于
Example of `assert_enqueued_with` with no block ```ruby def test_assert_enqueued_with MyJob.perform_later(1,2,3) assert_enqueued_with(job: MyJob, args: [1,2,3], queue: 'low') MyJob.set(wait_until: Date.tomorrow.noon).perform_later assert_enqueued_with(job: MyJob, at: Date.tomorrow.noon) end ``` Example of `assert_enqueued_email_with` with no block: ```ruby def test_email ContactMailer.welcome.deliver_later assert_enqueued_email_with ContactMailer, :welcome end def test_email_with_arguments ContactMailer.welcome("Hello", "Goodbye").deliver_later assert_enqueued_email_with ContactMailer, :welcome, args: ["Hello", "Goodbye"] end ``` Related to #33243
-
由 Rafael França 提交于
Note deliver_later_queue_name gotcha in ActionMailer guide
-
由 Rafael França 提交于
Incompatibility of Direct Uploads & Mirror Service
-
由 Stanislas Boyet 提交于
[ci skip] It adds a note to the Active Storage documentation regarding the use of Mirror Service not being compatible with the use of the Direct Uploads as described later on in the documentation, as described in issue #32732
-
由 Rafael França 提交于
Merge pull request #33254 from huacnlee/add-expires-in-option-support-for-redis-cache-store-increment-method Add :expires_in option support for RedisCacheStore increment/decrement method
-
由 Jason Lee 提交于
-
由 Matthew Draper 提交于
Refactor Previewer::PopplerPDFPreviewer#pdftoppm_exists?
-
由 utilum 提交于
Does not warn `instance variable @pdftoppm_exists not initialized`.
-
- 28 6月, 2018 5 次提交
-
-
由 Rafael França 提交于
Improve wording for form_with in Getting Started Guide
-
由 Rafael Mendonça França 提交于
This reverts commit 9d6bbf4e, reversing changes made to 5a1ea090. This method only works with block.
-
由 Anthony Crumley 提交于
[ci skip] Improved wording by making it clear the form_with helper method was being referenced in the first paragraph and that the second paragraph is a continuation of the form_with train of thought. Additionally, a connection was made to examples of the form_with usage being described.
-
由 Rafael Mendonça França 提交于
Allow configurable attribute name on `#has_secure_password`
-
由 Rafael França 提交于
Break guides menu 'Digging Deeper' section in two
-