This fixes following warnings:

```
test/dependencies_test.rb:287: warning: possibly useless use of :: in void context
test/dependencies_test.rb:300: warning: possibly useless use of a constant in void context
```

If you require `nokogiri` from `app/models/user.rb`, dependencies.rb
does not mark `Nokogiri` as an autoloaded constant, as expected.
But the logic to detect these non-autoloaded constants is incomplete.
See the tests defined in the patch for some cases incorrectly handled.

Closes #32885.

Follow up of #32605.

This autocorrects the violations after adding a custom cop in
3305c78dcd.

73e7aab behaved as expected on codeship, failing the build with
exactly these RuboCop violations. Hopefully `rubocop -a` will
have been enough to get a passing build!

Add failing test for infinite loop when unloading autoloaded modules when an error occured during the load.

This reverts commit 3420a145, reversing
changes made to afb66a5a.

".. with __dir__ we can restore order in the Universe." - by @fxn

Related to 5b8738c2

```
go get -u github.com/client9/misspell/cmd/misspell
misspell  -w -error -source=text .
```

This behavior used to warn until 2.4, and raises since 2.5.
The test here was intentinally named not to start with "test_" and so it used not to be executed because this never passes,
but now is should pass in trunk.

https://bugs.ruby-lang.org/issues/11547
https://github.com/ruby/ruby/commit/44a2576f798b07139adde2d279e48fdbe71a0148

closes #19897

`assert_raise` does not check error message. However, in some tests,
it seems like expecting error message checking with `assert_raise`.
Instead of specifying an error message in `assert_raise`, modify to use
another assert to check the error message.

assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message

assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong

Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces

Fix all violations in the repository.

The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.

References #24205.

Cleans up four items I came across in ActiveSupport::Dependencies:

- DependenciesTest#
  test_dependency_which_raises_exception_isnt_added_to_loaded_set:
  Fixes current implementation which will pass no matter what since the
  filepath is never added to "loaded" or "history" without being
  expanded first.
- Remove DependenciesTest#test_unhook. Seems leftover from when
  alias_method_chain was used in Loadable and ModuleConstMissing.
  The test will always pass since Module never responds to those methods
- WatchStack#new_constants documentation: update self to @stack.
  Looks like self was leftover from when WatchStack inherited from Hash
- Remove ActiveSupport namespace from call to
  Dependencies.constant_watch_stack.watching? since the namespace is not
  needed, Dependencies is called two other times in the same method
  without it (even on the same line) and it brings the line to within
  80 characters

Minitest sets an E constant to an empty string to save GC time.
This clashes with autoloading tests which define an E constant.

Now that Rails requires Ruby >= 2.0 there is need to skip the
`test_depend_on_path` test.

The check for circular loading should depend on a stack of files being
loaded at the moment, rather than the collection of loaded files.

This showed up indirectly in #16468, where a misspelled helper would
incorrectly result in a circularity error message.

References #16468

Fixes https://github.com/rails/rails/issues/9933.