- 04 9月, 2012 2 次提交
-
-
由 Yves Senn 提交于
All tests with a custom inheritance_column use the `Vegtable` model. The field ruby_type on the Company models is no longer needed
-
由 Yves Senn 提交于
previously the tests with and without a custom `inheritance_column` used the same models. Since the model then has both fields this can lead to false positives.
-
- 03 9月, 2012 2 次提交
-
-
由 Rafael Mendonça França 提交于
#becomes works with configured inheritance_column
-
由 Yves Senn 提交于
I had to create a new table because I needed an STI table, which does not have both a "type" and a "custom_type" the test fails with: 1) Error: test_alt_becomes_works_with_sti(InheritanceTest): NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber"> /Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb:100:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes' test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti' test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'
-
- 02 9月, 2012 13 次提交
-
-
由 Carlos Antonio da Silva 提交于
Fixed markup in Upgrading RoR guide [ci skip]
-
由 Carlos Antonio da Silva 提交于
Fix example code: use tasks instead of comments [ci skip]
-
由 Erik Behrends 提交于
-
由 Aldo "xoen" Giambelluca 提交于
There are two changes: - Using <ruby> syntax for unicode character routes example instead of <tt> since it causes single quotes to be transformed into inverted commas. This makes this required change more eye-catching. - Using <tt> for the j alias and related helpers as written in the documentation guidelines.
-
由 Aaron Patterson 提交于
Properly reset the session on reset_session
-
由 Andreas Loupasakis 提交于
Use load_for_write! to ensure a refresh of the session object. This way the new session_id and the empty data will be stored properly. E.g. in the case of the session cookie store this means that a new digest will be returned to the user.
-
由 Andreas Loupasakis 提交于
-
由 Andreas Loupasakis 提交于
-
由 Vijay Dev 提交于
-
由 Vijay Dev 提交于
-
由 Xavier Noria 提交于
The app generator is not generally run under bundler, but the Bundler constant is used here. In particular you cannot create --dev apps without this.
-
由 Piotr Sarnacki 提交于
-
- 01 9月, 2012 11 次提交
-
-
由 Piotr Sarnacki 提交于
ActionView decoupling and sprockets-rails tests fail
-
由 Dmitry Vorotilin 提交于
Method invalid_asset_host! was delegated to controller but sprockets compile assets in their own scope without controller. And if we set asset_host with second parameter it should raise error through invalid_asset_host!. But since controller is nil it cannot be reached.
-
由 Sven Kraeuter | 5v3n 提交于
-
由 Steve Klabnik 提交于
Fixes #7478
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
Option to run `bundle install` after generating new appplication was added recently to rails. Since introduction, it contained a subtle bug that caused it to use `Gemfile` from current directory (if it exists) rather than from generated directory. This also accidentaly caused railties tests to work without any problems - after generating test app it just used `Gemfile` from the repository, rather than the one in generated app. After fixing the bug mentioned above, this of course broke. The easiest way to bypass that is to not generate a `Gemfile` for test application - with such setup Bundler will just use first available `Gemfile` in one of the parent directories.
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
The cause of the previous revert was bug in bundler that made it hard to make railties test work. Fix for bundler was recently pushed to github, so now we can safely get back to the original commit. This reverts commit 0f5cc34a.
-
由 Steve Klabnik 提交于
SessionHash isn't a thing, and tenses are wrong.
-
由 Pratik Naik 提交于
-
由 Jon Leighton 提交于
This is purely a performance optimisation. See https://gist.github.com/3552829
-
- 31 8月, 2012 12 次提交
-
-
由 Jon Leighton 提交于
This is a performance/GC optimisation. In theory, this could be optimised by the implementation (last time I checked, this would have no effect on JRuby). But in practise, this make attribute access faster.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
We don't need separate @class_to_pool and @connection_pool hashes.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
* Loop rather than recurse in retrieve_connection_pool * Key the hash by class rather than class name. This avoids creating unnecessary strings.
-
由 Jon Leighton 提交于
This reverts commit 7256cb53, reversing changes made to 6ebe22c3. Reason: A test was failing.
-
由 Jon Leighton 提交于
This reverts commit e4b33b08. https://github.com/rails/rails/pull/7452#issuecomment-8094302
-
由 Sven Kräuter 提交于
Fixed little mistake in the docs
-
由 Sven Kräuter 提交于
-
由 Xavier Noria 提交于
the example for contraint( :ip => XXXX) has an invalid regex
-
由 Aldo "xoen" Giambelluca 提交于
The example is about a Person model, say that "params[:model] would usually be a hash of all the attributes for the person to create" could be confusing. I changed to params[:person] since the example is about a Person creation.
-
由 Jeff Shantz 提交于
Added a bullet for :enable_starttls_auto in the smtp_settings table
-