- 24 12月, 2013 6 次提交
-
-
由 Carlos Antonio da Silva 提交于
Always pass in the column for quote_bound_value and quote using it in case it exists there.
-
由 Tadas Tamosauskas 提交于
Fixes #12261. Closes #12395. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/adapters/postgresql/array_test.rb activerecord/test/cases/adapters/postgresql/json_test.rb
-
由 Carlos Antonio da Silva 提交于
The code uses these checks in several places to know what to do with a particular column, for instance AR attribute query methods has a branch like this: if column.number? !value.zero? end This should never be true for array columns, since it would be the same as running [].zero?, which results in a NoMethodError exception. Fixing this by ensuring that array columns in PostgreSQL never return true for number?/text? checks. Since most of the array support was based on the postgres_ext lib, it's worth noting it does the same thing for numeric array columns too: https://github.com/dockyard/postgres_ext/blob/v1.0.0/lib/postgres_ext/active_record/connection_adapters/postgres_adapter.rb#L72 This extended the same logic for text columns to ensure consistency.
-
由 Carlos Antonio da Silva 提交于
TLDR: always return an object that responds to the query methods from request.format, and do not touch Mime::Type[] lookup to avoid bugs. --- Long version: The initial issue was about being able to do checks like request.format.html? for request with an unknown format, where request.format would be nil. This is where the issue came from at first in #7837 and #8085 (merged in cba05887), but the implementation went down the path of adding this to the mime type lookup logic. This unfortunately introduced subtle bugs, for instance in the merged commit a test related to send_file had to be changed to accomodate the introduction of the NullType. Later another bug was found in #13064, related to the content-type being shown as #<Mime::NullType:...> for templates with localized extensions but no format included. This one was fixed in #13133, merged in 43962d6e. Besides that, custom handlers were not receiving the proper template formats anymore when passing through the rendering process, because of the NullType addition. That was found while migrating an application from 3.2 to 4.0 that uses the Markerb gem (a custom handler that generates both text and html emails from a markdown template). --- This changes the implementation moving away from returning this null object from the mime lookup, and still fixes the initial issue where request.format.zomg? would raise an exception for unknown formats due to request.format being nil.
-
由 Godfrey Chan 提交于
[ci skip] a destroy action in controller, not delete [getting_stated.md].
-
由 Juanito Fatas 提交于
-
- 23 12月, 2013 12 次提交
-
-
由 Yves Senn 提交于
Tell how to Create a Database in Error Message
-
由 schneems 提交于
Currently if you attempt to use a database that does not exist you get an error: ``` PG::ConnectionBad FATAL: database "db_error" does not exist ``` The solution is easy, create and migrate your database however new developers may not know these commands by memory. Instead of requiring the developer to search for a solution, tell them how to fix the problem in the error message: ``` ActiveRecord::NoDatabase: FATAL: database "db_error" does not exist Run `$ bin/rake db:create db:migrate` to create your database ``` Active Record should not know about `rake db:migrate` so this additional information needs to come from the railtie. Potential alternative implementation suggestions are welcome.
-
由 Carlos Antonio da Silva 提交于
-
由 Yves Senn 提交于
On destroying do not touch destroyed belongs to association.
-
由 Paul Nikitochkin 提交于
Fixes: #13445
-
由 Yves Senn 提交于
Resolver test cases
-
由 Kuldeep Aggarwal 提交于
-
由 José Valim 提交于
Add missing av/railtie require
-
由 Łukasz Strzałkowski 提交于
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Fix typecasting array of integers
-
由 Damien Mathieu 提交于
Closes #13444
-
- 22 12月, 2013 10 次提交
-
-
由 Godfrey Chan 提交于
-
由 Andrew White 提交于
-
由 Guillermo Iguaran 提交于
Fix DB Console tests
-
由 schneems 提交于
-
由 schneems 提交于
The build is broken: https://travis-ci.org/rails/rails/builds/15824530 This commit fixes it. The problem: Sqlite expects the `database` part to be an absolute path. That prompted this change to be committed to master: https://github.com/rails/rails/commit/fbb79b517f3127ba620fedd01849f9628b78d6ce This change provides correct behavior. Unfortunately tests were introduced in https://github.com/rails/rails/commit/971d5107cd4cd08c22a85d34546f4ba03ed5c925 that were relying on the incorrect behavior. We can avoid the fix by changing to another database url such as `mysql` or `postgresql` In addition to fixing the failure, the assertions are changed so that the "expected" value comes before "actual" value.
-
由 Guillermo Iguaran 提交于
Enable memcached service on travis for running cache tests.
-
由 Guillermo Iguaran 提交于
Add missing changelog entries and fix few typos
-
由 Vipul A M 提交于
-
由 Robin Dupret 提交于
-
由 Carlos Antonio da Silva 提交于
-
- 21 12月, 2013 9 次提交
-
-
由 Robin Dupret 提交于
-
由 Xavier Noria 提交于
-
由 Robin Dupret 提交于
-
由 Xavier Noria 提交于
AC::Parameters#fetch was refactored in 7171111d to prevent self mutation, but in doing so it hardcodes logic #convert_hashes_to_parameters is supposed to encapsulate. Better leave the delegation, and add a way to avoid mutating self in there.
-
由 Guillermo Iguaran 提交于
-
由 David Heinemeier Hansson 提交于
Generates html and text templates for mailers by default.
-
由 Xavier Noria 提交于
-
由 Aaron Patterson 提交于
-
由 Kassio Borges 提交于
-
- 20 12月, 2013 3 次提交
-
-
由 Rafael Mendonça França 提交于
Bump Jbuilder version to 2.0.0
-
由 Pavel Pravosud 提交于
-
由 Yves Senn 提交于
Do not expect database user with app name to exist
-