- 29 5月, 2019 1 次提交
-
-
由 Petrik 提交于
-
- 27 5月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Kasper Timm Hansen 提交于
-
- 26 5月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Change comments [ci skip]
-
- 25 5月, 2019 3 次提交
-
-
由 Edu Depetris 提交于
-
由 Kasper Timm Hansen 提交于
Fix EventedFileUpdateChecker through a symlink
-
由 Kasper Timm Hansen 提交于
-
- 24 5月, 2019 8 次提交
-
-
由 Rafael França 提交于
Wrap ActionView cache expiry in a mutex
-
由 Rafael França 提交于
Delete evented_file_update_checker existing_parent
-
由 John Hawthorn 提交于
On MacOS, Dir.tmpdir gives me a folder inside "/var/folders/". However, /var is a symlink to /private/var. Previously, the nonexistent directory test would fail because it was initialized with /var/folders/... but the filenames from listen would be the realpaths. This commit normalizes the dirs by calling realpath on them if they exist. This is done on boot!, so it will work with newly directories through the symlink.
-
由 John Hawthorn 提交于
The common include of this test creates a tmpdir, we should use that for consistency.
-
由 John Hawthorn 提交于
This is no longer used as of caa3cc88
-
由 Rafael França 提交于
Bump Gemfile entry jbuilder version
-
由 George Claghorn 提交于
Add :allow_nil option to delegate_missing_to
-
由 Matt Tanous 提交于
attachment
-
- 23 5月, 2019 8 次提交
-
-
由 Anton Rieder 提交于
jbuilder 2.6.4 is the first version that relaxes the version constraint to allow Rails 6. I also did some more tests in #25183, although not with 2.6.4 explicitly. To simplify the version requirement, I went for 2.7. https://github.com/rails/jbuilder/blob/v2.6.4/jbuilder.gemspec https://github.com/rails/rails/issues/25183#issuecomment-494342406
-
由 Gannon McGibbon 提交于
Keep part when scope option has value
-
由 Alberto Almagro 提交于
After @kamipo CR feedback we realized `Route#build` wasn't used. As it is also private API being able to create Routes both with `#new` and `#build` was redundant.
-
由 Alberto Almagro 提交于
This commit changes from constructor's argument list to keyword arguments in order to remove the dependency of remember parameters' positions. It also unifies all parameters extracted from the `scope` into `scope_params`, which also takes care of providing the default values for them.
-
由 Alberto Almagro 提交于
This commit changes from constructor's argument list to keyword arguments in order to remove the dependency of remember parameters' positions. The constructor already provided a default value for `internal`, this commits takes the chance to also add default values for `precedence` and `scope_options`.
-
由 Alberto Almagro 提交于
When a route was defined within an optional scope, if that route didn't take parameters the scope was lost when using path helpers. This patch ensures scope is kept both when the route takes parameters or when it doesn't. Fixes #33219
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
Remove compatibility module from docs [ci skip]
-
- 22 5月, 2019 9 次提交
-
-
由 Alan Wu 提交于
This module exists to warn old users. I think we should remove it from the docs so we don't advertise it.
-
由 Rafael França 提交于
Added deep_transform_keys to StrongParameters
-
由 Gustavo Gutierrez 提交于
-
由 प्रथमेश Sonpatki 提交于
- This hook was added in 90296674
-
由 Rafael França 提交于
[CI skip] Put :nodoc: on method that raises NoMethodError
-
由 John Hawthorn 提交于
-
由 Ryuta Kamizono 提交于
And no longer need to except SCHEMA SQLs manually since 0810c076.
-
由 Alan Wu 提交于
This method is not intended to be used so I think we should remove it from the docs.
-
由 Ryuta Kamizono 提交于
This reverts commit a1ee4a9f. Even if a1ee4a9f is applied, CI is still flakiness. https://buildkite.com/rails/rails/builds/61252#2c090afa-aa84-4a2b-8b81-9f09219222c6/994-1005 https://buildkite.com/rails/rails/builds/61252#2e55bf83-1bde-44a2-a4f1-b5c3f6820fb4/929-938 Failing tests by whether schema cache is filled or not, it actually means that whether SCHEMA SQLs are executed or not is not target for the tests. So I've reverted commit a1ee4a9f which filling schema cache before `assert_no_queries`, and replace `assert_no_queries` to `assert_queries(0)`.
-
- 21 5月, 2019 7 次提交
-
-
由 Ryuta Kamizono 提交于
Almost all database statements methods except `explain` was moved into `DatabaseStatements` at #35922. This moves the last one method.
-
由 Ryuta Kamizono 提交于
Fall back to type casting from the connection adapter
-
由 Ryuta Kamizono 提交于
Unfortunately, a11a8ff7 had no effect as long as using bind param, and was not tested. This ensures making the intent of a11a8ff7, which fall back to type casting from the connection adapter. Fixes #35205. ``` % ARCONN=postgresql bundle exec ruby -w -Itest test/cases/relation/where_test.rb -n test_type_casting_nested_joins Using postgresql Run options: -n test_type_casting_nested_joins --seed 55730 # Running: E Error: ActiveRecord::WhereTest#test_type_casting_nested_joins: ActiveRecord::StatementInvalid: PG::InvalidTextRepresentation: ERROR: invalid input syntax for integer: "2-foo" rails test test/cases/relation/where_test.rb:30 Finished in 0.245778s, 4.0687 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips ```
-
由 Ryuta Kamizono 提交于
Testing the result of `capture_sql` is fragile, it is due to whether SCHEMA SQLs are executed or not depends on whether schema cache is filled or not. https://buildkite.com/rails/rails/builds/61248#a5b9dc59-ff0c-40c0-b56e-0895662fbc4c/993-1004 https://buildkite.com/rails/rails/builds/61248#1157b389-f2c7-4554-b6e5-a37624a0e74a/996-1005 I've confirmed all `capture_sql` use cases in our code base, all cases won't expect SCHEMA SQLs are included. ``` % git grep -n capture_sql test/cases/associations/belongs_to_associations_test.rb:202: sql = capture_sql { comment.post } test/cases/associations/belongs_to_associations_test.rb:204: assert_not_equal sql, capture_sql { comment.post } test/cases/associations/has_many_associations_test.rb:169: sql = capture_sql { post.comments.to_a } test/cases/associations/has_many_associations_test.rb:171: assert_not_equal sql, capture_sql { post.comments.to_a } test/cases/associations/has_many_associations_test.rb:276: expected_sql = capture_sql { author.thinking_posts.delete_all } test/cases/associations/has_many_associations_test.rb:281: loaded_sql = capture_sql { author.thinking_posts.delete_all } test/cases/associations/has_many_associations_test.rb:289: expected_sql = capture_sql { author.posts.delete_all } test/cases/associations/has_many_associations_test.rb:294: loaded_sql = capture_sql { author.posts.delete_all } test/cases/associations/left_outer_join_association_test.rb:22: queries = capture_sql do test/cases/associations/left_outer_join_association_test.rb:49: queries = capture_sql { Author.left_outer_joins(:posts).to_a } test/cases/associations/left_outer_join_association_test.rb:54: queries = capture_sql { Author.joins(:posts).left_outer_joins(:posts).to_a } test/cases/associations/left_outer_join_association_test.rb:60: queries = capture_sql { Author.left_outer_joins({}).to_a } test/cases/associations/left_outer_join_association_test.rb:65: queries = capture_sql { Author.left_outer_joins([]).to_a } test/cases/associations/left_outer_join_association_test.rb:78: queries = capture_sql { Author.left_outer_joins(:essays).to_a } test/cases/associations_test.rb:384: log = capture_sql do test/cases/associations_test.rb:399: log = capture_sql do test/cases/associations_test.rb:414: log = capture_sql do test/cases/associations_test.rb:429: log = capture_sql do test/cases/associations_test.rb:444: log = capture_sql do test/cases/associations_test.rb:459: log = capture_sql do test/cases/reflection_test.rb:307: expected_sql = capture_sql { hotel.recipes.to_a } test/cases/reflection_test.rb:312: loaded_sql = capture_sql { hotel.recipes.to_a } test/cases/relation_test.rb:212: queries = capture_sql { Author.joins(:posts).merge(Post.joins(:comments)).to_a } test/cases/relation_test.rb:232: queries = capture_sql { Post.joins(:author, :categorizations).merge(Author.select(:id)).merge(categorizations_with_authors).to_a } test/cases/relation_test.rb:347: log = capture_sql do test/cases/scoping/relation_scoping_test.rb:146: log = capture_sql do test/cases/scoping/relation_scoping_test.rb:159: log = capture_sql do test/cases/test_case.rb:33: def capture_sql test/cases/test_case.rb:41: capture_sql { yield } ```
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
Correct human file size examples [ci skip]
-
由 Alexander Graul 提交于
The `number_to_human_size` helpers in Action View and Active Support calculate the "human size" with a base of 1024. The examples should reflect that so they don't confuse the reader. The updated documentations use the values from: helper.number_to_human_size(1500)
-
- 20 5月, 2019 1 次提交
-
-
由 Kasper Timm Hansen 提交于
Make rescues layout responsive
-