- 28 11月, 2017 1 次提交
-
-
由 Francis Go 提交于
-
- 25 11月, 2017 9 次提交
-
-
由 Francis Go 提交于
-
由 Atul Shimpi 提交于
* [ci skip] SecureRandom should mentioned Win32 CryptoAPI functions instead of Win32 * Remove functions word
-
由 Matthew Draper 提交于
Improve AR connection fork safety
-
由 Rafael França 提交于
Rubocop style: Missing magic comment
-
由 Vipul A M 提交于
Update documentation to lead with ajax param `event.detail` [ci skip]
-
由 Dimitri Roche 提交于
-
由 Vipul A M 提交于
[ci skip] Rails Associations examples contains ActiveRecord::Base ref…
-
由 Vipul A M 提交于
Fix tld_length documentation in ActionDispatch::Cookies [ci skip]
-
由 Atul Shimpi 提交于
[ci skip] Rails Associations examples contains ActiveRecord::Base reference instead of ApplicationRecord in images
-
- 24 11月, 2017 3 次提交
-
-
由 Dixit Patel 提交于
-
由 Avneet Singh Malhotra 提交于
Correct render method's response header's content type for option(:body) from text/html to text/plain. (#31212)
-
由 George Claghorn 提交于
-
- 23 11月, 2017 10 次提交
-
-
由 Ryuta Kamizono 提交于
Fix unstable test test_delegate_socket_errors_to_on_error_handler
-
由 Fumiaki MATSUSHIMA 提交于
I often face the following error when running test/connection/client_socket_test.rb: ``` $ bin/test test/connection/client_socket_test.rb:38 Run options: --seed 44035 # Running: F Failure: ActionCable::Connection::ClientSocketTest#test_delegate_socket_errors_to_on_error_handler [/app/actioncable/test/connection/client_socket_test.rb:47]: --- expected +++ actual @@ -1 +1 @@ -["foo"] +["Broken pipe", "Broken pipe", "Broken pipe", "foo"] ``` It can be reproduced easily by applying the following patch: ``` diff --git a/actioncable/test/connection/client_socket_test.rb b/actioncable/test/connection/client_socket_test.rb index 2051216010..6bb9f13ea7 100644 --- a/actioncable/test/connection/client_socket_test.rb +++ b/actioncable/test/connection/client_socket_test.rb @@ -34,7 +34,8 @@ def on_error(message) @server.config.allowed_request_origins = %w( http://rubyonrails.com ) end - test "delegate socket errors to on_error handler" do + 1000.times do |i| + test "delegate socket errors to on_error handler #{i}" do run_in_eventmachine do connection = open_connection @@ -47,6 +48,7 @@ def on_error(message) assert_equal %w[ foo ], connection.errors end end + end test "closes hijacked i/o socket at shutdown" do run_in_eventmachine do ``` The cause is writing io from different thread at the same time. `connection.process` sends handshake message from [StreamEventLoop's thread][] whereas `connection.handle_open` sends welcome message from current thread. [StreamEventLoop's thread]: https://github.com/rails/rails/blob/067fc779c4560fff4812614a2f78f9248f3e55f8/actioncable/lib/action_cable/connection/stream_event_loop.rb#L75
-
由 Yuji Yaginuma 提交于
No difference between JRuby and CRuby at test_read_attributes_before_…
-
由 Rafael França 提交于
Update Action Cable Overview Guide [ci skip]
-
由 Ryuta Kamizono 提交于
Fix CustomUrls#direct doc formatting
-
由 T.J. Schuck 提交于
Particularly, the bulleted list was getting formatted as a code block because of the extra level of indentation. Pulling it back to the left makes it render properly as a list instead. [ci skip]
-
由 Rafael França 提交于
Update incorrect backtick usage in RDoc to teletype
-
由 T.J. Schuck 提交于
[ci skip]
-
由 Chris LaRose 提交于
-
由 Francis Go 提交于
-
- 22 11月, 2017 6 次提交
-
-
由 Yuji Yaginuma 提交于
Fix generator suggestion raise error when I18n.available_locales don’t include :en
-
由 willnet 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 Joe Marty 提交于
Change recommendation for tld_length (for sharing cookies across subdomains of a 2-token TLD), to 2 instead of 1.
-
由 Yasuo Honda 提交于
https://github.com/jruby/activerecord-jdbc-adapter ActiveRecord JDBC Adapter is actively developed and it supports Rails 5.1 now. This pull request addresses one of the failure when running ActiveRecord unit tests with ActiveRecord JDBC Adapter. As of right now, ActiveRecord JDBC Adapter supports Rails 5.1, not master branch then this test only can run on `5-1-stable` branch. But I have opened this pull request to `master` branch since this type cast should be going to work in the future versions of ActiveRecord JDBC Adapter . ```ruby $ ARCONN=jdbcmysql bin/test test/cases/attribute_methods_test.rb:203 Using jdbcmysql Run options: --seed 8874 F Finished in 0.709120s, 1.4102 runs/s, 1.4102 assertions/s. 1) Failure: AttributeMethodsTest#test_read_attributes_before_type_cast_on_a_boolean [/home/yahonda/git/rails/activerecord/test/cases/attribute_methods_test.rb:203]: Expected: "0" Actual: 0 1 runs, 1 assertions, 1 failures, 0 errors, 0 skips $ ```
-
- 21 11月, 2017 5 次提交
-
-
由 Yuji Yaginuma 提交于
FIX: `rack-test` 0.7.1 probably got yanked.
-
由 Guo Xiang Tan 提交于
-
由 yuuji.yaginuma 提交于
`em-hiredis` is unused since 48766e32
-
由 George Claghorn 提交于
Permit creating a record and attaching files in a single step. # Before: User.create!(user_params.except(:avatar)).tap do |user| user.avatar.attach(user_params[:avatar]) end # After: User.create!(user_params) [Yoshiyuki Hirano & George Claghorn]
-
由 Takumasa Ochi 提交于
Support `expires_in` in `ActiveSupport::Cache::MemCacheStore#increment` and `#decrement`. Closes #30716.
-
- 20 11月, 2017 6 次提交
-
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
Disable CSRF protection for ActiveStorage::DiskController#update. The local disk service is intended to imitate a third-party service like S3 or GCS, so we don't care where direct uploads originate: they’re authorized by signed tokens. Closes #30290. [Shinichi Maeshima & George Claghorn]
-
由 Vipul A M 提交于
Pass over Execution guide[ci skip]
-
由 Vipul A M 提交于
-
由 Matthew Draper 提交于
[ci skip] Added example for using headless_chrome with SystemTest
-
由 George Claghorn 提交于
Closes #31164.
-