- 20 7月, 2015 14 次提交
-
-
由 Sean Griffin 提交于
Add missing method name to exception description
-
由 Sean Griffin 提交于
fix doc about ActiveRecord::Transactions::ClassMethods#transaction [ci skip]
-
由 Sean Griffin 提交于
grammar fix to content_for method documentation in capture_helper.rb [ci skip]
-
由 David Heinemeier Hansson 提交于
Use digest cache in development.
-
由 Mehmet Emin İNAÇ 提交于
-
由 Mehmet Emin İNAÇ 提交于
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
Freeze string literals when not mutated.
-
由 schneems 提交于
I wrote a utility that helps find areas where you could optimize your program using a frozen string instead of a string literal, it's called [let_it_go](https://github.com/schneems/let_it_go). After going through the output and adding `.freeze` I was able to eliminate the creation of 1,114 string objects on EVERY request to [codetriage](codetriage.com). How does this impact execution? To look at memory: ```ruby require 'get_process_mem' mem = GetProcessMem.new GC.start GC.disable 1_114.times { " " } before = mem.mb after = mem.mb GC.enable puts "Diff: #{after - before} mb" ``` Creating 1,114 string objects results in `Diff: 0.03125 mb` of RAM allocated on every request. Or 1mb every 32 requests. To look at raw speed: ```ruby require 'benchmark/ips' number_of_objects_reduced = 1_114 Benchmark.ips do |x| x.report("freeze") { number_of_objects_reduced.times { " ".freeze } } x.report("no-freeze") { number_of_objects_reduced.times { " " } } end ``` We get the results ``` Calculating ------------------------------------- freeze 1.428k i/100ms no-freeze 609.000 i/100ms ------------------------------------------------- freeze 14.363k (± 8.5%) i/s - 71.400k no-freeze 6.084k (± 8.1%) i/s - 30.450k ``` Now we can do some maths: ```ruby ips = 6_226k # iterations / 1 second call_time_before = 1.0 / ips # seconds per iteration ips = 15_254 # iterations / 1 second call_time_after = 1.0 / ips # seconds per iteration diff = call_time_before - call_time_after number_of_objects_reduced * diff * 100 # => 0.4530373333993266 miliseconds saved per request ``` So we're shaving off 1 second of execution time for every 220 requests. Is this going to be an insane speed boost to any Rails app: nope. Should we merge it: yep. p.s. If you know of a method call that doesn't modify a string input such as [String#gsub](https://github.com/schneems/let_it_go/blob/b0e2da69f0cca87ab581022baa43291cdf48638c/lib/let_it_go/core_ext/string.rb#L37) please [give me a pull request to the appropriate file](https://github.com/schneems/let_it_go/blob/b0e2da69f0cca87ab581022baa43291cdf48638c/lib/let_it_go/core_ext/string.rb#L37), or open an issue in LetItGo so we can track and freeze more strings. Keep those strings Frozen ![](https://www.dropbox.com/s/z4dj9fdsv213r4v/let-it-go.gif?dl=1)
-
由 Sean Griffin 提交于
Fix exception overwritten for parameters fetch method
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
Since the counter cache was properly being updated, the model became stale. Simply reloading the model before attempting to destroy is sufficient for this case. I believe this is enough of an edge case to be a valid change to the tests, even though it represents a potential breaking change.
-
由 Stefan Kanev 提交于
Also removes a false positive test that depends on the fixed bug: At this time, counter_cache does not work with polymorphic relationships (which is a bug). The test was added to make sure that no StaleObjectError is raised when the car is destroyed. No such error is currently raised because the lock version is not incremented by appending a wheel to the car. Furthermore, `assert_difference` succeeds because `car.wheels.count` does not check the counter cache, but the collection size. The test will fail if it is replaced with `car.wheels_count || 0`.
-
由 Kasper Timm Hansen 提交于
Fix `TimeWithZone#eql?` to handle `TimeWithZone` created from `DateTime`
-
- 19 7月, 2015 10 次提交
-
-
由 Roque Pinel 提交于
Before: ```ruby twz = DateTime.now.in_time_zone twz.eql?(twz.dup) => false ``` Now: ```ruby twz = DateTime.now.in_time_zone twz.eql?(twz.dup) => true ``` Please notice that this fix the `TimeWithZone` comparison to itself, not to `DateTime`. Based on #3725, `DateTime` should not be equal to `TimeWithZone`.
-
由 Kasper Timm Hansen 提交于
Fix formatting of force_ssl options documentation [ci skip]
-
由 Eliot Sykes 提交于
-
由 Abdelkader Boudih 提交于
[ci skip] Fix typo in #any? RDoc
-
由 Sean Griffin 提交于
Added examples to DateAndTime::Calculations [ci skip]
-
由 Roque Pinel 提交于
When executing an `ActionController::Parameters#fetch` with a block that raises a `KeyError` the raised `KeyError` will be rescued and converted to an `ActionController::ParameterMissing` exception, covering up the original exception. [Jonas Schubert Erlandsson & Roque Pinel]
-
由 Julio Lopez 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Avoid computing the same fragment digest many times when looping over templates. The cache is cleared on every request so template changes are still picked up.
-
由 Sean Griffin 提交于
Ensure that 'ActionController::Parameters' can still be passed to AR …
-
- 18 7月, 2015 16 次提交
-
-
由 Thomas Walpole 提交于
-
由 Sean Griffin 提交于
This code is so fucked. Things that cause this bug not to replicate: - Defining the validation before the association (we end up calling `uniq!` on the errors in the autosave validation) - Adding `accepts_nested_attributes_for` (I have no clue why. The only thing it does that should affect this is adds `autosave: true` to the inverse reflection, and doing that manually doesn't fix this). This solution is a hack, and I'm almost certain there's a better way to go about it, but this shouldn't cause a huge hit on validation times, and is the simplest way to get it done. Fixes #20874.
-
由 Sean Griffin 提交于
Add a note about default_scope and create records [ci skip]
-
由 Sean Griffin 提交于
Since nested hashes are also instances of `ActionController::Parameters`, and we're explicitly looking to work with a hash for nested attributes, this caused breakage in several points. This is the minimum viable fix for the issue (and one that I'm not terribly fond of). I can't think of a better place to handle this at the moment. I'd prefer to use some sort of solution that doesn't special case AC::Parameters, but we can't use something like `to_h` or `to_a` since `Enumerable` adds both. While I've added a trivial test case for verifying this fix in isolation, we really need better integration coverage to prevent regressions like this in the future. We don't actually have a lot of great places for integration coverage at the moment, so I'm deferring it for now. Fixes #20922.
-
由 Sean Griffin 提交于
Replaced render :text with render :plain in AC gem bug report template
-
由 Prathamesh Sonpatki 提交于
- Followup of https://github.com/rails/rails/pull/20929. [ci skip]
-
由 Kasper Timm Hansen 提交于
use `plain` option instead of deprecated `text` option
-
由 yuuji.yaginuma 提交于
this will silence deprecation warnings
-
由 Matthew Draper 提交于
Stop using deprecated `render :text` in test
-
由 Prem Sichanugrist 提交于
This will silence deprecation warnings. Most of the test can be changed from `render :text` to render `:plain` or `render :body` right away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned from `render :body`.
-
由 Jeremy Daer (Kemper) 提交于
Add deprecation warning for `render :text`
-
由 Prem Sichanugrist 提交于
We've started on discouraging the usage of `render :text` in #12374. This is a follow-up commit to make sure that we print out the deprecation warning.
-
由 Andrii Ponomarov 提交于
-
由 Aaron Patterson 提交于
this way we don't need to call `to_unsafe_h` to get access to ask questions about the underlying hash
-
由 Sean Griffin 提交于
Silence deprecation warning from force reload
-
由 Aaron Patterson 提交于
now `hash_filter` doesn't need to know about the `Parameters` class
-