- 30 10月, 2018 7 次提交
-
-
由 Ryuta Kamizono 提交于
Avoid violating key constraints in fixture HABTM associations
-
由 Eileen M. Uchitelle 提交于
Add support for hash and url configs to be used in connected_to
-
由 Ryuta Kamizono 提交于
-
由 Akira Matsuda 提交于
or they would be listed in `action_methods`
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
- 29 10月, 2018 11 次提交
-
-
由 Ryuta Kamizono 提交于
Document exception from restrict_with_exception [ci skip]
-
由 James Le Cuirot 提交于
When loading fixtures, Ruby 1.9's hash key ordering means that HABTM join table rows are always loaded before the parent table rows, violating foreign key constraints that may be in place. This very simple change ensures that the parent table's key appears first in the hash. Violations may still occur if fixtures are loaded in the wrong order but those instances can be avoided unlike this one.
-
由 Malcolm Locke 提交于
-
由 Ryuta Kamizono 提交于
Update bug report templates
-
由 Ryuta Kamizono 提交于
Privatize and add # :nodoc: to constants
-
由 Xavier Noria 提交于
References #34253.
-
由 Robin Dupret 提交于
Fix grammar in changed? docs [ci skip]
-
由 Robin Dupret 提交于
Given that Bundler 1.10 was released back in 2015, we can assume that people are at least on this version or a higher one so there is no need to ask people to upgrade. Also, given that Rails 5.0 supports Ruby 2.2+ and given that this version come with Minitest 5.4.3 bundled, we don't need to ensure backward compatibility with Minitest 4.
-
由 Alberto Almagro 提交于
Both `UTC_OFFSET_WITH_COLON` and `UTC_OFFSET_WITHOUT_COLON` are only used within `ActiveSupport::TimeZone` and in my opinion they do not provide relevant information that should appear in the docs.
-
由 Xavier Noria 提交于
Fix autoloading issue with ActiveStorage::Downloader
-
- 28 10月, 2018 1 次提交
-
-
由 Jan Habermann 提交于
If you require `nokogiri` from `app/models/user.rb`, dependencies.rb does not mark `Nokogiri` as an autoloaded constant, as expected. But the logic to detect these non-autoloaded constants is incomplete. See the tests defined in the patch for some cases incorrectly handled.
-
- 27 10月, 2018 6 次提交
-
-
由 Olivier Lacan 提交于
We repeat the phrase "Release Notes" even though release note are listed under a... "Release Notes" category already. With this change, instead of repeating ourselves, we can give people a sense of the recency of each release by simply listing the month and year of each release. This is a follow-up to #34265 as suggested by @jeremy. [ci skip]
-
由 Ryuta Kamizono 提交于
Any type can be a primary key, so blank string is also valid value. Closes #26356.
-
由 Ryuta Kamizono 提交于
Use column definition with `primary_key: true` instead.
-
由 Ryuta Kamizono 提交于
Ignore empty condition on #construct_relation_for_exists
-
由 r7kamura 提交于
At https://github.com/rails/rails/commit/fc0e3354af7e7878bdd905a95ce4c1491113af9a, ```rb relation = relation.where(conditions) ``` was rewritten to: ```rb relation.where!(condition) ``` This change accidentally changed the result of `Topic.exists?({})` from true to false. To fix this regression, first I moved the blank check logic (`opts.blank?`) from `#where` to `#where!`, because I thought `#where!` should be identical to `#where`, except that instead of returning a new relation, it adds the condition to the existing relation. But on second thought after some discussion on https://github.com/rails/rails/pull/34329, I started to think that just fixing `#construct_relation_for_exists` is more preferable than changing `#where` and `#where!`.
-
由 Gannon McGibbon 提交于
Add support for hash and url configs in database hash of `ActiveRecord::Base.connected_to`.
-
- 26 10月, 2018 9 次提交
-
-
由 Eileen M. Uchitelle 提交于
Improve no-response file wording
-
由 Ryuta Kamizono 提交于
Implement AR#inspect using ParameterFilter
-
由 Ryuta Kamizono 提交于
Support default expression and expression indexes for MySQL
-
由 Ryuta Kamizono 提交于
Partly revert #31819
-
由 bogdanvlviv 提交于
The PR#31819 changed `#preloaders_on` and added some test, then #33938 reverted changes that were added to the method in #31819. Since changes in the method were reverted and as mentioned in the comment https://github.com/rails/rails/pull/31819#discussion_r221847481 that titles of the tests added in #31819 don't reflect implementation I think we can remove those test for now.
-
由 Gannon McGibbon 提交于
Add maxlength attribute usage example to Text Field Api documentation
-
由 Rafael França 提交于
`assert_called_with` should require `args` argument
-
由 Raghu Kamat 提交于
The usage of maxlength in the text_field helper adds a size attribute to the generated text_field input with the same value as the maxlength. This implicit addition of size attribute by the method gives a false impression that it may be bug. By adding the implementation of the maxlength to the api docs, we explicitly tell the reader referring the api doc that addition of size along with maxlength is the expected behaviour. [ci skip]
-
由 bogdanvlviv 提交于
There are two main reasons why `assert_called_with` should require `args` argument: 1) If we want to assert that some method should be called and we don't need to check with which arguments it should be called then we should use `assert_called`. 2) `assert_called_with` without `args` argument doesn't assert anything! ```ruby assert_called_with(@object, :increment) do @object.decrement end ``` It causes false assertions in tests that could cause regressions in the project. I found this bug by working on [minitest-mock_expectations](https://github.com/bogdanvlviv/minitest-mock_expectations) gem. This gem is an extension for minitest that provides almost the same method call assertions. I was wondering whether you would consider adding "minitest-mock_expectations" to `rails/rails` instead of private `ActiveSupport::Testing::MethodCallAssertions` module. If yes, I'll send a patch - https://github.com/bogdanvlviv/rails/commit/a970ecc42c3a9637947599f2c13e3762e4b59208
-
- 25 10月, 2018 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
Document `deep_interpolation` parameter for bulk lookups
-
由 Ryuta Kamizono 提交于
MySQL 8.0.13 and higher supports default value to be a function or expression. https://dev.mysql.com/doc/refman/8.0/en/create-table.html
-
由 Ryuta Kamizono 提交于
MySQL 8.0.13 and higher supports functional key parts that index expression values rather than column or column prefix values. https://dev.mysql.com/doc/refman/8.0/en/create-index.html
-
由 Oliver Günther 提交于
Bulk lookups are sort of an edge case, I have not heard of them until a colleague of mine decided to dynamically iterate over a growing set of translations and receiving them in bulk as a hash with `I18n.t 'welcome'` as in the example above. When passing an interpolation to these bulk lookups, they will only be performed when also passing `deep_interpolation: true`. **Without passing `deep_interpolation` flag:** ```ruby I18n.t 'welcome', app_name: 'book store' # => {:title=>"Welcome!", :content=>"Welcome to the %{app_name}"} **With passing `deep_interpolation`:** I18n.t 'welcome', deep_interpolation: true, app_name: 'book store' # => {:title=>"Welcome!", :content=>"Welcome to the book store"} ``` I found this digging in the I18n lookup backend, the flag is listed on [I18n's Rubydoc](https://www.rubydoc.info/github/svenfuchs/i18n/master/I18n) but not otherwise listed. Since bulk lookups are mentioned here, I suggest to add a note with this flag along with it.
-
由 Ryuta Kamizono 提交于
The default collation for utf8mb4 is changed to utf8mb4_0900_ai_ci in MySQL 8.0, so `test_mysql_connection_collation_is_configured` is affected by MySQL version and/or default_collation_for_utf8mb4 system variable. https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_default_collation_for_utf8mb4 ``` % ARCONN=mysql2 be ruby -w -Itest test/cases/adapters/mysql2/connection_test.rb -n test_mysql_connection_collation_is_configured Using mysql2 Run options: -n test_mysql_connection_collation_is_configured --seed 10421 # Running: F Failure: Mysql2ConnectionTest#test_mysql_connection_collation_is_configured [test/cases/adapters/mysql2/connection_test.rb:108]: Expected: "utf8mb4_general_ci" Actual: "utf8mb4_0900_ai_ci" rails test test/cases/adapters/mysql2/connection_test.rb:106 Finished in 0.013842s, 72.2450 runs/s, 144.4900 assertions/s. 1 runs, 2 assertions, 1 failures, 0 errors, 0 skips ```
-
由 Rafael França 提交于
Include deserialized arguments in jobs returned by AJ test helpers
-