- 02 4月, 2014 4 次提交
-
-
由 Jeremy Kemper 提交于
* Clarify what the situation is and what to do. * Advise loading schema using `rake db:setup` instead of migrating. * Use a rescue in the initializer rather than extending the error message in-place. * Preserve the original backtrace of other errors by using `raise` rather than raising again with `raise error`. References 0ec45cd1
-
由 Yves Senn 提交于
-
- 01 4月, 2014 2 次提交
-
-
由 Yves Senn 提交于
I ran the whole test suite and compared the old to the new types. Following is the list of types that did change with this patch: ``` DIFFERENT TYPE FOR mood: NEW: enum, BEFORE: DIFFERENT TYPE FOR floatrange: NEW: floatrange, BEFORE: float ``` The `floatrange` is a custom type. The old type `float` was simply a coincidence form the name `floatrange` and our type-guessing.
-
由 eileencodes 提交于
When delete_all is run on a CollectionProxy and has a dependency of delete_all the SQL that is produced has an IN statement. (DELETE FROM `associated_model` where `associated_model` .`parent_id` = 1 AND `associated_model`.`id` IN (1, 2, 3...)). This only happens if the association is not loaded (both loaded and non-loaded delete_all should behave the same. This is a huge problem when it comes to deleting many records because the query becomes very slow. Instead the SQL produced should be (DELETE FROM `assoicated_model` where `associated_model`.`parent_model_id`=1). I fixed this by making sure the check for loaded and destroy also makes sure that the dependent is not delete_all, so the conditional goes to the else and deletes the records directly without the IN statement.
-
- 31 3月, 2014 6 次提交
-
-
由 Yves Senn 提交于
We have `connection_adapters/column.rb` so it's easier to remember that the column in in a separate file.
-
由 thedarkone 提交于
The new method relies on AR::Associations::Association knowing about both reflection and a model class. AR::Base#association now raises a descriptive error when trying to access non-existent associations. Previously it would blow up with a confusing NoMethodError: undefined method `association_class' for nil:NilClass.
-
由 thedarkone 提交于
Defer to Association#klass instead of having a custom/duplicate code.
-
由 Luke Steensen 提交于
-
由 Luke Steensen 提交于
fixes #10613
-
由 Rafael Mendonça França 提交于
It is already called inside type_to_sql method.
-
- 29 3月, 2014 2 次提交
-
-
由 Godfrey Chan 提交于
460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases, this ensures we always return a boolean value. Also fixed a similar problem in AR reflections.
-
由 Kelley Reynolds 提交于
-
- 28 3月, 2014 3 次提交
-
-
由 Rafael Mendonça França 提交于
Swap Timestamp/Callbacks order in ActiveRecord::Base
-
由 chrisfinne 提交于
custom primary_key that didn't save due to validation error
-
由 Henrik Nyh 提交于
It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
-
- 27 3月, 2014 7 次提交
-
-
由 Rafael Mendonça França 提交于
This method is not being called anywhere in our code and a GitHub search show it is not being used in any project.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
* cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call
-
由 Rafael Mendonça França 提交于
These comments will likely be outdated with time and doesn't include any information that can't be found in the adapters
-
由 Rafael Mendonça França 提交于
Also improve some of the code conventions
-
- 26 3月, 2014 3 次提交
-
-
由 Steve Rice 提交于
Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
-
由 Cody Cutrer 提交于
This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
This reverts commit 6e3ab3e1, reversing changes made to 39e07b64. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
-
- 25 3月, 2014 1 次提交
-
-
由 Kuldeep Aggarwal 提交于
ActiveRecord::Base.pluralize_table_names = false. Previously, generation a migration like this: rails g migration add_column_name_to_user name would not generating the correct table name. Fixes #13426.
-
- 20 3月, 2014 4 次提交
-
-
由 Josh Williams 提交于
The pk_an_sequence_for query previously joined against pg_class's oid for rows in pg_depend, but pg_depend's objid may point to other system tables, such as pg_attrdef. If a row in one of those other tables coincidentally has the same oid as an (unrelated) sequence, that sequence name may be returned instead of the real one. This ensures that only the pg_depend entries pointing to pg_class are considered.
-
由 Carlos Antonio da Silva 提交于
-
由 Yves Senn 提交于
-
由 Thiago Pinto 提交于
-
- 18 3月, 2014 3 次提交
-
-
由 Matthew Draper 提交于
.. not a general timeout. Now, if a thread checks out a connection then dies, we can immediately recover that connection and re-use it. This should alleviate the pool exhaustion discussed in #12867. More importantly, it entirely avoids the potential issues of the reaper attempting to check whether connections are still active: as long as the owning thread is alive, the connection is its business alone. As a no-op reap is now trivial (only entails checking a thread status per connection), we can also perform one in-line any time we decide to sleep for a connection.
-
由 Matthew Draper 提交于
It wasn't doing anything beyond clearing the statement cache.
-
由 Earl St Sauver 提交于
The group method also takes an array, however this isn't immediately clear by reading the source since it delegates this method. If you trace it back to the AREL building you can see that it does support an array. Shoutout to @betovelandia for pointing this out.
-
- 17 3月, 2014 1 次提交
-
-
由 Yves Senn 提交于
Closes #14406.
-
- 16 3月, 2014 1 次提交
-
-
由 Eric Steele 提交于
Allows fixtures to use their $LABEL as part of a string instead of limiting use to the entire value. mark: first_name: $LABEL username: $LABEL1973 email: $LABEL@$LABELmail.com users(:mark).first_name # => mark users(:mark).username # => mark1973 users(:mark).email # => mark@markmail.com
-
- 15 3月, 2014 3 次提交
-
-
由 Washington Luiz 提交于
Prior to Rails 4.0.4 when touching a object which doesn't have timestamp attributes (updated_at / updated_on) rails would still touch all associations. After 73ba2c14 it updates associations but rollsback because `touch` would return nil since there's no timestamp attribute
-
由 Carlos Antonio da Silva 提交于
Fixes #14383.
-
由 Washington Luiz 提交于
As of https://github.com/rails/rails/pull/12031 after_commit and after_rollback are also executed
-