- 06 3月, 2017 3 次提交
-
-
由 Jon Moss 提交于
Fix `direct` with params example [ci skip]
-
由 yuuji.yaginuma 提交于
Since `ActionController:Parameters` does not inherit `Hash`, need to explicitly convert it to `Hash`. Also, `Parameters#to_h` returns `Hash` whose key is `String`. Therefore, if merge as it is, the value will not be overwritten as expected.
-
由 Jon Moss 提交于
Fix CI failure due to contain <U+2028>
-
- 05 3月, 2017 14 次提交
-
-
由 Ryuta Kamizono 提交于
```diff diff --git a/actionpack/lib/action_controller/metal/redirecting.rb b/actionpack/lib/action_controller/metal/redirecting.rb index a3159c29dd..1836a07d4e 100644 --- a/actionpack/lib/action_controller/metal/redirecting.rb +++ b/actionpack/lib/action_controller/metal/redirecting.rb @@ -50,8 +50,8 @@ module Redirecting # redirect_to post_url(@post), status: 301, flash: { updated_post_id: @post.id } # redirect_to({ action: 'atom' }, alert: "Something serious happened") # - # Statements after redirect_to in our controller get executed, so redirect_to doesn't stop the execution of the function. - <U+2028># To terminate the execution of the function immediately after the redirect_to, use return. + # Statements after +redirect_to+ in our controller get executed, so +redirect_to+ doesn't stop the execution of the function. + # To terminate the execution of the function immediately after the +redirect_to+, use return. # redirect_to post_url(@post) and return def redirect_to(options = {}, response_status = {}) raise ActionControllerError.new("Cannot redirect to nil!") unless options ``` https://travis-ci.org/rails/rails/jobs/207908041#L549
-
由 Eileen M. Uchitelle 提交于
Remove useless `Migrator.schema_migrations_table_name`
-
由 Vipul A M 提交于
[ci skip] Use return with redirect_to
-
由 Eileen M. Uchitelle 提交于
Do not take screenshot if driver does not support screenshot
-
由 eileencodes 提交于
This reverts commit 84c1b107. Reverted #28283 so reverted it's changelog update as well.
-
由 eileencodes 提交于
This reverts commit 0d73f911, reversing changes made to 21ff8a49. We don't want to silence Puma because it's start up messages can be useful (to see threads, port etc). #28109 was instead fixed by not running system tests by defaul with `bin/rails test` in #28286.
-
由 Eileen M. Uchitelle 提交于
Avoid running system tests by default
-
由 Robin Dupret 提交于
These tests may be expansive so let's only allow users to run them through `bin/rails test:system` or by passing a path to the `test` command. The same applies for `bin/rake test`. Refs #28109.
-
由 Ryuta Kamizono 提交于
Simply use `SchemaMigration.table_name` instead.
-
由 Vijay Dev 提交于
-
由 Andrew White 提交于
-
由 Robin Dupret 提交于
[ci skip] Fix ParameterMissing exception name in docs
-
由 Andrew White 提交于
Fix `rake db:schema:load` with subdirectories
-
由 Tejas Bubane 提交于
Should be `ActionController::ParameterMissing` and not `ActionController::MissingParameter`. Corresponding change was done in guides in https://github.com/rails/rails/pull/9816.
-
- 04 3月, 2017 23 次提交
-
-
由 Ryuta Kamizono 提交于
Related #25174. `db:schema:load` doesn't work with subdirectories like previous `db:migrate:status`. `Migrator.migration_files` should be used in `assume_migrated_upto_version` to fix the issue.
-
由 Robin Dupret 提交于
-
由 Robin Dupret 提交于
-
由 Andrew White 提交于
Fix `rake db:migrate:status` with subdirectories.
-
由 Ryuta Kamizono 提交于
`db:migrate` supports subdirectories and have a test. https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/test/cases/migrator_test.rb#L78-L85 But `db:migrate:status` doesn't work with subdirectories. It is due to `Dir.foreach(path)` is not the same with `Dir["#{path}/**/[0-9]*_*.rb"]`. I extracted `migration_files` and sharing it in the both to fix the issue. And added tests for `db:migrate:status`.
-
由 Andrew White 提交于
Silence puma startup messages in system test
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Don't share `options` with a reference type column
-
由 Robin Dupret 提交于
Fx system test example [ci skip]
-
由 yuuji.yaginuma 提交于
Since test suffix is automatically granted, it is not necessary to specify it in generator. Also, updated the generated file to contents actually generated.
-
由 yuuji.yaginuma 提交于
Fixes #28109
-
由 yuuji.yaginuma 提交于
`Capybara::RackTest::Driver` does not support taking screenshots. If call `#save_screenshot` on `Capybara::RackTest::Driver` will raise the error. ```ruby Error: UsersTest#test_visiting_the_index: Capybara::NotSupportedByDriverError: Capybara::Driver::Base#save_screenshot ``` To prevent errors, if driver does not support screenshot, do not call it.
-
由 Ryuta Kamizono 提交于
Sharing `options` causes some unexpected behavior. If `limit: 2` is specified, this means that 2 bytes integer for a reference id column and 2 chars string for a reference type column. Another example, if `unsigned: true` is specified, this means that unsigned integer for a reference id column, but a invalid option for a reference type column. So `options` should not be shared with a reference type column.
-
由 ChakreshwarSharma 提交于
-
由 Vipul A M 提交于
-
由 Vipul A M 提交于
-
由 Akira Matsuda 提交于
So calling `filename_with_extensions` omitting the second argument like this https://github.com/slim-template/slim-rails/blob/8dbc1fbf859ebfa95b0884a0196a6ad9f0ca9cd5/lib/generators/slim/scaffold/scaffold_generator.rb#L10 causes NoMethodError. fixes #28275
-
由 Ryuta Kamizono 提交于
passing unique parameter to belongs_to wrongly
-
由 Aaron Patterson 提交于
Various refactoring to association scopes and joins
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Reflections only use their own information to create a `join_keys` object. This means that we can call `join_keys` on a reflection object and have it be context-free.
-
由 Andrew White 提交于
Add iso8601 and rfc3339 parsing to timezones
-
由 Aaron Patterson 提交于
-