1. 20 7月, 2017 1 次提交
  2. 19 7月, 2017 1 次提交
    • Y
      Fix `warning: circular argument reference` · 2966f959
      yuuji.yaginuma 提交于
      This fixes the following warnings:
      
      ```
      rails/activejob/lib/active_job/test_helper.rb:119: warning: circular argument reference - except
      rails/activejob/lib/active_job/test_helper.rb:166: warning: circular argument reference - except
      ```
      2966f959
  3. 18 7月, 2017 1 次提交
  4. 11 7月, 2017 1 次提交
  5. 10 7月, 2017 1 次提交
  6. 02 7月, 2017 1 次提交
  7. 01 7月, 2017 2 次提交
  8. 27 6月, 2017 1 次提交
  9. 03 6月, 2017 1 次提交
  10. 30 5月, 2017 1 次提交
  11. 26 5月, 2017 2 次提交
  12. 22 5月, 2017 1 次提交
  13. 28 3月, 2017 1 次提交
    • S
      Add error logging to Active Job · 452f9ee0
      Steven Bull 提交于
      Active Job logging instrumentation is changed to log errors (with
      backtrace) when a job raises an exception in #perform. This improves
      debugging during development and test with the default configuration.
      
      Prior to Rails 5, the default development configuration ran jobs with
      InlineAdapter, which would raise exceptions to the caller and be
      shown in the development log. In Rails 5, the default adapter was
      changed to AsyncAdapter, which would silently swallow exceptions
      and log a "Performed SomeJob from Async..." info message. This could
      be confusing to a developer, as it would seem that the job was
      performed successfully.
      
      This patch removes the "Performed..." info message from the log
      and adds an error-level "Error performing SomeJob..." log message
      which includes the exception backtrace for jobs that raise an
      exception within the #perform method. It provides this behavior for
      all adapters.
      452f9ee0
  14. 22 3月, 2017 1 次提交
  15. 16 3月, 2017 1 次提交
  16. 24 2月, 2017 1 次提交
  17. 23 2月, 2017 1 次提交
    • B
      Include JobID in all ActiveJob info logs · 85c62a2c
      Bolek Kurowski 提交于
      Currently we provide the Job ID in logs only related to enqueuing a job.
      
      This adds the job id to the remaining ActiveJob logs when:
       - a job started performing
       - a job ended performing
      
      Providing the job id in those logs will ease searching logs by job id.
      85c62a2c
  18. 01 2月, 2017 1 次提交
    • Y
      correctly set test adapter when configure the queue adapter on a per job (#26690) · 80dc3098
      Yuji Yaginuma 提交于
      The `ActiveJob::TestHelper` replace the adapter to test adapter in
      `before_setup`. It gets the target class using the `descendants`, but if
      the test target job class is not loaded, will not be a replacement of
      the adapter.
      Therefore, instead of replacing with `before_setup`, modified to
      replace when setting adapter.
      
      Fixes #26360
      80dc3098
  19. 31 1月, 2017 1 次提交
  20. 18 1月, 2017 1 次提交
  21. 17 1月, 2017 1 次提交
  22. 15 1月, 2017 1 次提交
  23. 24 12月, 2016 2 次提交
  24. 18 11月, 2016 1 次提交
    • Y
      remove Ruby warning from Active Job test helper methods · 5b825c55
      yuuji.yaginuma 提交于
      This removes the following warnings.
      
      ```
      /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:241: warning: shadowing outer local variable - job
      /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:265: warning: shadowing outer local variable - job
      ```
      5b825c55
  25. 17 11月, 2016 1 次提交
  26. 29 10月, 2016 1 次提交
  27. 27 10月, 2016 1 次提交
  28. 21 10月, 2016 1 次提交
  29. 14 10月, 2016 1 次提交
  30. 11 10月, 2016 2 次提交
  31. 08 10月, 2016 1 次提交
  32. 20 9月, 2016 1 次提交
  33. 05 9月, 2016 1 次提交
  34. 02 9月, 2016 1 次提交
  35. 25 8月, 2016 1 次提交
    • R
      Add load hooks to all tests classes · 0510208d
      Rafael Mendonça França 提交于
      Usually users extends tests classes doing something like:
      
          ActionView::TestCase.include MyCustomTestHelpers
      
      This is bad because it will load the ActionView::TestCase right aways
      and this will load ActionController::Base making its on_load hooks to
      execute early than it should.
      
      One way to fix this is using the on_load hooks of the components like:
      
          ActiveSupport.on_load(:action_view) do
            ActionView::TestCase.include MyCustomTestHelpers
          end
      
      The problem with this approach is that the test extension will be only
      load when ActionView::Base is loaded and this may happen too late in the
      test.
      
      To fix this we are adding hooks to people extend the test classes that
      will be loaded exactly when the test classes are needed.
      0510208d
  36. 20 8月, 2016 1 次提交