- 16 10月, 2017 4 次提交
-
-
由 bogdanvlviv 提交于
Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create wrong ar_internal_metadata's data for a test database. Before: ``` $ RAILS_ENV=test rails dbconsole > SELECT * FROM ar_internal_metadata; key|value|created_at|updated_at environment|development|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679 ``` After: ``` $ RAILS_ENV=test rails dbconsole > SELECT * FROM ar_internal_metadata; key|value|created_at|updated_at environment|test|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679 ``` Fixes #26731.
-
由 Ryuta Kamizono 提交于
Follow up of #30862.
-
由 Eileen M. Uchitelle 提交于
Remove a needless space in Action View Guide [ci skip]
-
由 Eileen M. Uchitelle 提交于
Capitalize "sprockets" in Engine guide [ci skip]
-
- 15 10月, 2017 8 次提交
-
-
由 Ryuta Kamizono 提交于
This test covers the case of 02da8aea. Previously `exists?` was always eager-loading the includes values. But now it is eager-loaded only when necessary since 07a611e0. So the case of the eager-loading had not covered in the test.
-
由 Ryuta Kamizono 提交于
We already found the longer sequence name, but we could not consider whether it was the sequence name created by serial type due to missed a max identifier length limitation. I've addressed the sequence name consideration to respect the max identifier length. Fixes #28332.
-
由 Eileen M. Uchitelle 提交于
Update Gemfile with comment for Active Storage group
-
由 Ryuta Kamizono 提交于
Currently `AUTO_INCREMENT` is implicitly used in the default primary key definition. But `AUTO_INCREMENT` is not only used for single column primary key, but also for composite primary key. In that case, `auto_increment: true` should be dumped explicitly in the `db/schema.rb`. Fixes #30894.
-
由 Ryuta Kamizono 提交于
Remove unused `before_filters`
-
由 yuuji.yaginuma 提交于
This method added by 10085114. It is unnecessary because it is no longer called by 19c3495a.
-
由 Ryuta Kamizono 提交于
Add accept-charset to the output of form_with in JS guide [ci skip]
-
由 Yoshiyuki Hirano 提交于
-
- 14 10月, 2017 12 次提交
-
-
由 Ryuta Kamizono 提交于
This is the fix for the regression of #29848. In #29848, I've kept existing select list in the subquery for the count if ORDER BY is given. But it had accidentally affect to GROUP BY queries also. It should keep the previous behavior in that case. Fixes #30886.
-
由 Ryuta Kamizono 提交于
For investigating the cause of failure. https://travis-ci.org/rails/rails/jobs/287474883#L797-L799
-
由 Ryuta Kamizono 提交于
Add unpermitted_parameters hook to instrumentation guide [ci skip]
-
由 George Claghorn 提交于
Fix test name for daemon option test
-
由 Yoshiyuki Hirano 提交于
-
由 yuuji.yaginuma 提交于
In this test file, "server option" refers to the server used to start Rails(e.g. `puma`, `thin`). But this test, "server option" is not specified. Therefore, I think that it is incorrect that `server_option` is included in the test name.
-
由 Ryuta Kamizono 提交于
Remove unsued `jquery-rails`
-
由 Ryuta Kamizono 提交于
Use __dir__ in activestorage/
-
由 Ryuta Kamizono 提交于
Added test case for starting rails with daemon option
-
由 Ryuta Kamizono 提交于
Add Action Cable notifications to instrument guide [ci skip]
-
由 bogdanvlviv 提交于
Related to #29417
-
由 bogdanvlviv 提交于
Related to #29176
-
- 13 10月, 2017 12 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
由 Ryuta Kamizono 提交于
Add process.action_mailer notification to Instrument guide [ci skip]
-
由 Yoshiyuki Hirano 提交于
-
由 Pierre Hedkvist 提交于
Added test case for starting rails with daemon option, this should set the option[:daemonize] to true, otherwise the option[:daemonize] will be set to false
-
由 George Claghorn 提交于
-
由 yuuji.yaginuma 提交于
This has been added by 8f8cb1ba. But now it is unnecessary because it is not used in the test.
-
由 Ryuta Kamizono 提交于
Bump RuboCop 0.50.0
-
由 Ryuta Kamizono 提交于
Yield with an error instance instead of error class
-
由 Koichi ITO 提交于
RuboCop 0.50.0 was released. https://github.com/bbatsov/rubocop/releases/tag/v0.50.0 And `rubocop-0-50` channel is available in Code Climate. https://github.com/codeclimate/codeclimate-rubocop/issues/107#issuecomment-336234260 This commit will bump RuboCop to 0.50.0. There are no new offences in this change. ```console % bundle exec rubocop --version 0.50.0 % bundle exec rubocop Inspecting 2350 files (snip) 2350 files inspected, no offenses detected ```
-
由 Kazunori Kajihiro 提交于
-
由 Yoshiyuki Hirano 提交于
-
由 George Claghorn 提交于
-
- 12 10月, 2017 4 次提交
-
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
fix the description for the `select_all` [ci skip]
-
由 Aditya Kapoor 提交于
-
由 Ryuta Kamizono 提交于
[ci skip]Enable link to ActionDispatch::Integration::Session#process in rdoc
-