- 10 12月, 2019 3 次提交
-
-
由 Rafael França 提交于
Don't run AJ after_enqueue / after_perform when chain is halted:
-
由 Edouard CHIN 提交于
- ### Problem ```ruby MyJob < ApplicationJob before_enqueue { throw(:abort) } after_enqueue { # enters here } end ``` I find AJ behaviour on after_enqueue and after_perform callbacks weird as they get run even when the callback chain is halted. It's counter intuitive to run the after_enqueue callbacks even though the job wasn't event enqueued. ### Solution In Rails 6.2, I propose to make the new behaviour the default and stop running after callbacks when the chain is halted. For application that wants this behaviour now or in 6.1 they can do so by adding the `config.active_job.skip_after_callbacks_if_terminated = true` in their configuration file.
-
由 Rafael França 提交于
Fix ActiveJob logging when callback chain is halted:
-
- 09 12月, 2019 6 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Edouard CHIN 提交于
- ### Problem ActiveJob will always log "Enqueued MyJob (Job ID) ..." even if the job doesn't get enqueued through the adapter. Same problem happens when performing a Job, "Performed MyJob (Job ID) ..." will be logged even when job wasn't performed at all. This situation can happen either if the callback chain is terminated (before_enqueue throwing an `abort`) or if an exception is raised. ### Solution Check if the callback chain is aborted/exception is raised, and log accordingly.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit 4e105385, reversing changes made to 62b43839. The change in Ruby that made those changes required was reverted in https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisions/8852fa876039ed177fd5e867f36177d8a9ff411c
-
由 Rafael França 提交于
Rails::Application#config_for merges shared configuration deeply
-
由 kirikiriyamama 提交于
-
- 08 12月, 2019 3 次提交
-
-
由 kirikiriyamama 提交于
-
由 Dalto Curvelano 提交于
[ci skip]
-
由 finn 提交于
Add a yellow "NOTE" block to see if the guide looks better.
-
- 07 12月, 2019 10 次提交
-
-
由 Shu Fujita 提交于
-
由 Peter Zhu 提交于
-
由 Gannon McGibbon 提交于
Remove unused query params in DiskService
-
由 Peter Zhu 提交于
-
由 Gannon McGibbon 提交于
Use DiskController for both public and private files
-
由 Peter Zhu 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
- 06 12月, 2019 14 次提交
-
-
由 Rafael França 提交于
Bring back feature that allows loading external route files:
-
由 Carlos Antonio da Silva 提交于
-
由 Edouard CHIN 提交于
= This feature existed back in 2012 https://github.com/rails/rails/commit/5e7d6bba79393de0279917f93b82f3b7b176f4b5 but got reverted with the incentive that there was a better approach. After discussions, we agreed that it's a useful feature for apps that have a really large set of routes. Co-authored-by: NYehuda Katz <wycats@gmail.com>
-
由 Xavier Noria 提交于
I added myself links to the Ruby on Rails Tutorial years ago, after meeting Michael in a RailsConf. By then, the book was a commercial product, but had a free online version and I thought it could be a good resource complementing the official documentation. Nowadays, only a few sample chapters are available for free, and I don't consider these links to be fair with the rest of commercial books about Rails anymore.
-
由 Ryuta Kamizono 提交于
Revert "Use `app.config.file_watcher` for watcher in `RoutesReloader`"
-
由 Alan Tan 提交于
This reverts commit 28e44f47. A limitation of Listen is that it currently only supports watching directories. Therefore, watching `config/routes.rb` will end up watching the entire `config` directory if we use the evented file watcher. This causes problems especially if symlinks are present in the `config` directory.
-
由 Ryuta Kamizono 提交于
system tests: properly set driver options for non-headless drivers
-
由 Ryuta Kamizono 提交于
Use `app.config.file_watcher` for watcher in `RoutesReloader`
-
由 Ryuta Kamizono 提交于
Upgrade listen to 3.2.1 for darwin fixes
-
由 George Claghorn 提交于
-
由 Alan Tan 提交于
Pulls in a fix where the darwin adapter no longers create a `fsevent_watch` process for each directory that Listen has been asked to watch.
-
由 Kasper Timm Hansen 提交于
Closes #37666
-
由 Santiago Bartesaghi 提交于
-
由 George Claghorn 提交于
-
- 05 12月, 2019 4 次提交
-
-
由 Ryuta Kamizono 提交于
Don't parse DB specific locking docs as code [ci skip]
-
由 Ryuta Kamizono 提交于
Add guide for inline around_action
-
由 George Claghorn 提交于
-
由 Ryo Nakamura 提交于
-