1. 16 10月, 2013 1 次提交
  2. 15 10月, 2013 2 次提交
  3. 14 10月, 2013 1 次提交
  4. 11 10月, 2013 1 次提交
  5. 09 10月, 2013 1 次提交
  6. 05 10月, 2013 1 次提交
  7. 25 9月, 2013 1 次提交
  8. 24 9月, 2013 2 次提交
  9. 23 9月, 2013 1 次提交
    • S
      Only output Server logs in Development · 5f98bb40
      schneems 提交于
      Right now when you start a server via `rails s`, the logger gets extended so that it logs to the file system and also to stdout. This extension behavior is not "intelligent" and if the default logger is already set to output to stdout, then the contents will be received twice.
      
      To capture logs in accordance with http://www.12factor.net/logs some platforms require the logs to be sent to standard out. If a logger is set to stdout, and the server is started using `rails server` instead of another method (i.e. `thin start` etc.) then the app will produce double logs.
      
      This PR fixes the issue by only extending the logger to standard out in the development environment. So that in production you don't get double logs like this:
      
      ```
      ActionView::Template::Error (wrong number of arguments (5 for 4)):
          1: <% lang_index = 0 %>
          2: <div class="row">
          3:   <ul class="nav nav-tabs nav-stacked span2" data-tabs="tabs" id="repo-tabs">
          4:     <% repos.group_by(&:language).each do |lang, repos| %>
          5:       <% unless lang == nil %>
          6:         <li><a href="#<%= "#{lang.parameterize}#{lang.hash}" %>" data-toggle="tab"><%= lang %></a></li>
          7:       <% end -%>
        app/views/shared/_repos.html.erb:4:in `_app_views_shared__repos_html_erb___1685450633638247395_70300668607000'
        app/views/pages/index.html.erb:13:in `_app_views_pages_index_html_erb__2084723628308867770_70300687584880'
      
      ActionView::Template::Error (wrong number of arguments (5 for 4)):
          1: <% lang_index = 0 %>
          2: <div class="row">
          3:   <ul class="nav nav-tabs nav-stacked span2" data-tabs="tabs" id="repo-tabs">
          4:     <% repos.group_by(&:language).each do |lang, repos| %>
          5:       <% unless lang == nil %>
          6:         <li><a href="#<%= "#{lang.parameterize}#{lang.hash}" %>" data-toggle="tab"><%= lang %></a></li>
          7:       <% end -%>
        app/views/shared/_repos.html.erb:4:in `_app_views_shared__repos_html_erb___1685450633638247395_70300668607000'
        app/views/pages/index.html.erb:13:in `_app_views_pages_index_html_erb__2084723628308867770_70300687584880'
      ```
      
      ATP Railties. Opened against master in favor of #10999
      5f98bb40
  10. 22 9月, 2013 1 次提交
  11. 14 9月, 2013 1 次提交
    • P
      Don't require using application_name before options · 47ac67b8
      Piotr Sarnacki 提交于
      Before this commit options for `rails new` and `rails plugin new` had to
      be passed in a strict order, trying to execute a following command:
      
          rails new -J path/to/app
      
      resulted in an error.
      
      This commit fixes the situation and allows to pass path to app anywhere
      after `new`
      47ac67b8
  12. 13 9月, 2013 2 次提交
  13. 12 9月, 2013 1 次提交
  14. 11 9月, 2013 2 次提交
  15. 10 9月, 2013 1 次提交
  16. 09 9月, 2013 2 次提交
  17. 01 9月, 2013 1 次提交
  18. 31 8月, 2013 1 次提交
  19. 30 8月, 2013 1 次提交
  20. 29 8月, 2013 2 次提交
    • W
      Small refactoring changes to generators. · 21e68853
      wangjohn 提交于
      Made a method name clearer (added a bang to the end to show that it
      mutates arguments) and extracted indentation into its own method.
      21e68853
    • W
      Refactoring Generators::Base. · ecd4e70a
      wangjohn 提交于
      The defaults hash isn't used unless the +class_options+ hash has a
      particular key, so we don't need to compute it unless this is true.
      
      Also moving some code for extracting a module into its own method.
      ecd4e70a
  21. 28 8月, 2013 1 次提交
    • T
      Comply with current umask when generating new app: · 1cb50949
      Thibault Jouan 提交于
        When creating a new application using the default rails generator
      (`rails new my_app`), it will apply some permissions bypassing the
      current process umask. The `bin' directory and any files inside it will
      always be set a mode of 0755.
      
        This change removes the current umask bits from the mode applied by
      the generator on the `bin' directory and its content.
      1cb50949
  22. 25 8月, 2013 8 次提交
  23. 23 8月, 2013 1 次提交
  24. 19 8月, 2013 1 次提交
  25. 18 8月, 2013 1 次提交
  26. 16 8月, 2013 1 次提交
  27. 15 8月, 2013 1 次提交