1. 25 5月, 2014 1 次提交
  2. 24 5月, 2014 4 次提交
  3. 23 5月, 2014 2 次提交
  4. 22 5月, 2014 4 次提交
  5. 21 5月, 2014 3 次提交
  6. 15 5月, 2014 2 次提交
  7. 14 5月, 2014 11 次提交
  8. 13 5月, 2014 6 次提交
  9. 20 4月, 2014 1 次提交
    • A
      Make URL escaping more consistent · 5460591f
      Andrew White 提交于
      1. Escape '%' characters in URLs - only unescaped data
         should be passed to URL helpers
      
      2. Add an `escape_segment` helper to `Router::Utils`
         that escapes '/' characters
      
      3. Use `escape_segment` rather than `escape_fragment`
         in optimized URL generation
      
      4. Use `escape_segment` rather than `escape_path`
         in URL generation
      
      For point 4 there are two exceptions. Firstly, when a route uses wildcard
      segments (e.g. *foo) then we use `escape_path` as the value may contain '/'
      characters. This means that wildcard routes can't be optimized. Secondly,
      if a `:controller` segment is used in the path then this uses `escape_path`
      as the controller may be namespaced.
      
      Fixes #14629, #14636 and #14070.
      5460591f
  10. 05 1月, 2014 4 次提交
    • A
      Unique the segment keys array for non-optimized url helpers · 6b548830
      Andrew White 提交于
      In Rails 3.2 you only needed pass an argument for dynamic segment once so
      unique the segment keys array to match the number of args. Since the number
      of args is less than required parts the non-optimized code path is selected.
      This means to benefit from optimized url generation the arg needs to be
      specified as many times as it appears in the path.
      
      Fixes #12808
      6b548830
    • A
      Show full route constraints in error message · 892c5395
      Andrew White 提交于
      When an optimized helper fails to generate, show the full route constraints
      in the error message. Previously it would only show the contraints that were
      required as part of the path.
      
      Fixes #13592
      892c5395
    • A
      Simplify arg parameterization · b9efc74f
      Andrew White 提交于
      b9efc74f
    • A
      Use a custom route vistor for optimized route generation · d017e92e
      Andrew White 提交于
      Using a Regexp to replace dynamic segments in a path string is fraught
      with difficulty and can lead to odd edge cases like #13349. Since we
      already have a parsed representation of the path it makes sense to use
      that to generate an array of segments that can be used to build an
      optimized route's path quickly.
      
      Tests on a simple route (e.g. /posts/:id) show a speedup of 35%:
      https://gist.github.com/pixeltrix/8261932
      
      Calculating -------------------------------------
          Current Helper:       5274 i/100ms
          New Helper:           8050 i/100ms
      -------------------------------------------------
          Current Helper:     79263.6 (±3.7%) i/s -     395550 in   4.997252s
          New Helper:        153464.5 (±4.9%) i/s -     772800 in   5.047834s
      
      Tests on a more complex route show even an greater performance boost:
      https://gist.github.com/pixeltrix/8261957
      
      Calculating -------------------------------------
          Current Helper:       2367 i/100ms
          New Helper:           5382 i/100ms
      -------------------------------------------------
          Current Helper:     29506.0 (±3.2%) i/s -     149121 in   5.059294s
          New Helper:         78815.5 (±4.1%) i/s -     398268 in   5.062161s
      
      It also has the added benefit of fixing the edge cases described above.
      
      Fixes #13349
      d017e92e
  11. 12 12月, 2013 1 次提交
  12. 13 9月, 2013 1 次提交