- 25 5月, 2014 1 次提交
-
-
由 Aaron Patterson 提交于
Unwrap Constraints objects. I don't actually think it's possible to pass a Constraints object to this constructor, but there were multiple places that kept testing children of this object. I *think* they were just being defensive, but I have no idea.
-
- 24 5月, 2014 4 次提交
-
-
由 Aaron Patterson 提交于
this also changes the constructor. We don't need to pass more options than "defaults" (whatever defaults are, ugh. probably another hash of stupid stuff).
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 23 5月, 2014 2 次提交
-
-
由 Aaron Patterson 提交于
this decouples our code from the env hash a bit.
-
由 Aaron Patterson 提交于
-
- 22 5月, 2014 4 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
The optimized and non-optimized path share more code now without significant performance degretation
-
由 Aaron Patterson 提交于
Example: x = [1,2,3,4] y = [3,2,1] def test x, y hash = {} x.zip(y) { |k,v| hash[k] = v } hash end def test2 x, y Hash[x.zip(y)] end def test3 x, y x.zip(y).each_with_object({}) { |(k,v),hash| hash[k] = v } end def stat num start = GC.stat(:total_allocated_object) num.times { yield } total_obj_count = GC.stat(:total_allocated_object) - start puts "#{total_obj_count / num} allocations per call" end stat(100) { test(x,y) } stat(100) { test2(x,y) } stat(100) { test3(x,y) } __END__ 2 allocations per call 7 allocations per call 8 allocations per call
-
- 21 5月, 2014 3 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 15 5月, 2014 2 次提交
-
-
由 Andrew White 提交于
The bit of URL generation that is optimized is the generation of the path so things like :host, :port, etc. are irrelevant.
-
由 Andrew White 提交于
-
- 14 5月, 2014 11 次提交
-
-
由 Aaron Patterson 提交于
Then we can avoid nil checks
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 13 5月, 2014 6 次提交
-
-
由 Carlos Antonio da Silva 提交于
It's usage has been removed in 325c9d5e.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
This reverts commit 9df60693.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
this way we can stop checking respond_to on every call.
-
由 Aaron Patterson 提交于
-
- 20 4月, 2014 1 次提交
-
-
由 Andrew White 提交于
1. Escape '%' characters in URLs - only unescaped data should be passed to URL helpers 2. Add an `escape_segment` helper to `Router::Utils` that escapes '/' characters 3. Use `escape_segment` rather than `escape_fragment` in optimized URL generation 4. Use `escape_segment` rather than `escape_path` in URL generation For point 4 there are two exceptions. Firstly, when a route uses wildcard segments (e.g. *foo) then we use `escape_path` as the value may contain '/' characters. This means that wildcard routes can't be optimized. Secondly, if a `:controller` segment is used in the path then this uses `escape_path` as the controller may be namespaced. Fixes #14629, #14636 and #14070.
-
- 05 1月, 2014 4 次提交
-
-
由 Andrew White 提交于
In Rails 3.2 you only needed pass an argument for dynamic segment once so unique the segment keys array to match the number of args. Since the number of args is less than required parts the non-optimized code path is selected. This means to benefit from optimized url generation the arg needs to be specified as many times as it appears in the path. Fixes #12808
-
由 Andrew White 提交于
When an optimized helper fails to generate, show the full route constraints in the error message. Previously it would only show the contraints that were required as part of the path. Fixes #13592
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Using a Regexp to replace dynamic segments in a path string is fraught with difficulty and can lead to odd edge cases like #13349. Since we already have a parsed representation of the path it makes sense to use that to generate an array of segments that can be used to build an optimized route's path quickly. Tests on a simple route (e.g. /posts/:id) show a speedup of 35%: https://gist.github.com/pixeltrix/8261932 Calculating ------------------------------------- Current Helper: 5274 i/100ms New Helper: 8050 i/100ms ------------------------------------------------- Current Helper: 79263.6 (±3.7%) i/s - 395550 in 4.997252s New Helper: 153464.5 (±4.9%) i/s - 772800 in 5.047834s Tests on a more complex route show even an greater performance boost: https://gist.github.com/pixeltrix/8261957 Calculating ------------------------------------- Current Helper: 2367 i/100ms New Helper: 5382 i/100ms ------------------------------------------------- Current Helper: 29506.0 (±3.2%) i/s - 149121 in 5.059294s New Helper: 78815.5 (±4.1%) i/s - 398268 in 5.062161s It also has the added benefit of fixing the edge cases described above. Fixes #13349
-
- 12 12月, 2013 1 次提交
-
-
由 Akshay Vishnoi 提交于
-
- 13 9月, 2013 1 次提交
-
-
由 SUGINO Yasuhiro 提交于
-