- 06 5月, 2020 13 次提交
-
-
由 Ryuta Kamizono 提交于
Any missing thing would be found such like #39159.
-
由 Eugene Kenny 提交于
Accept multiple arguments in Symbol#start_with? and Symbol#end_with?
-
由 Eugene Kenny 提交于
Followup to 62a20c2a, for consistency with the upstream implementation.
-
由 Rafael França 提交于
Ensure sqlite3_mem transaction tests run in memory
-
由 Jonathan Hefner 提交于
SQLite3 does not recognize paths as file URIs unless the `SQLite3::Constants::Open::URI` flag is set. Therefore, without this flag, a path like "file::memory:" is interpreted as a filename, causing a "file::memory:" file to be created and used as the database. Most tests in `SQLite3TransactionTest` picked up this flag from `shared_cache_flags`, but a few did not. Because those tests were creating a file, the path was changed in #38620 such that it no longer pointed to an in-memory database. This commit restores the database path as "file::memory:" and ensures the URI flag is set whenever `in_memory_db?` is true.
-
由 Godfrey Chan 提交于
add additional instrumentation block for ActionView layout rendering
-
由 Gannon McGibbon 提交于
Use the `file_fixture_path` for fixture_file_upload:
-
由 Ryuta Kamizono 提交于
Ensure array passed to preloader has no duplicate records by object_id
-
由 Ryuta Kamizono 提交于
Add 3rd person aliases of `Symbol#start_with?` and `Symbol#end_with?`
-
由 Bogdan Gusiev 提交于
Fixes #39073
-
由 Ryuta Kamizono 提交于
This is the opposite direction of #39152.
-
由 eileencodes 提交于
-
由 eileencodes 提交于
This reverts commit 9817d74f, reversing changes made to d326b029. Just making this easier to merge our PR in. Otherwise there's tons of conflicts and our PR is faster.
-
- 05 5月, 2020 27 次提交
-
-
由 Sébastien Dubois 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
This reverts commit 55e038cf, reversing changes made to 8b900a71.
-
由 Ryuta Kamizono 提交于
Deprecate `starts_with?` and `ends_with?` for String core extensions
-
由 Edouard CHIN 提交于
- We used the `fixture_path` before `file_fixture_path` was a thing, but now that we have the latter we should use it. `fixture_path` is solely used by Active Record so it seems wrong to be using that in ActionPack.
-
由 Ryuta Kamizono 提交于
Follow up to 257d8f97.
-
由 Ryuta Kamizono 提交于
3cfd6d1d added lots of `**` and then 3f27aa8c has reverted unnecessary changes. `save_block_result_to_cache` is also unnecessary to take keyword arguments.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Some commits adds `**` to address kwargs warnings in Ruby 2.7, but `save` and `save!` are originally doesn't take positional arguments, so maintain both `*` and `**` is redundant. https://github.com/rails/rails/commit/6d68bb5f695414b1801c1c3952ef955a5b0b6c6a https://github.com/rails/rails/commit/09d7ce79750d08b6b9c64fd038eee285d0cbfd44 https://github.com/rails/rails/commit/51a7422c9f10cc75a3ef6bf9177324fc771d7ba4
-
由 Ryuta Kamizono 提交于
In the past, we sometimes hit missing `Symbol#start_with?` and `Symbol#end_with?`. https://github.com/rails/rails/commit/63256bc5d7dd77b2cce82df46c53249dab2dc2a8 https://github.com/rails/rails/commit/a8e812964d711fa03843e76ae50f5ff81cdc9e00 So I proposed `Symbol#start_with?` and `Symbol#end_with?` to allow duck typing that methods for String and Symbol, then now it is available in Ruby 2.7. https://bugs.ruby-lang.org/issues/16348 Using `String#starts_with?` and `String#ends_with?` could not be gained that conveniency, so it is preferable to not use these in the future.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Ryuta Kamizono 提交于
PERF: Improve performance of where when using an array of values
-
由 Ryuta Kamizono 提交于
More concise Arel `Or` ast and make `Or` visitor non recursive
-
由 Ryuta Kamizono 提交于
Fix `rewhere` to truly overwrite collided where clause by new where clause
-
由 Ryuta Kamizono 提交于
```ruby steve = Person.find_by(name: "Steve") david = Author.find_by(name: "David") relation = Essay.where(writer: steve) # Before relation.rewhere(writer: david).to_a # => [] # After relation.rewhere(writer: david).to_a # => [david] ``` For now `rewhere` only works for truly column names, doesn't work for alias attributes, nested conditions, associations. To fix that, need to build new where clause first, and then get attribute names from new where clause.
-
由 Eugene Kenny 提交于
Include parallelize :threads option in template when fork not available
-
由 Brandon Fish 提交于
-
由 Eugene Kenny 提交于
This is a remnant of the auto-explain feature, which was removed in d3688e02.
-
由 Eugene Kenny 提交于
Fix flakey destroyed_by_association tests
-
由 Eugene Kenny 提交于
Inspect time attributes with subsec
-
由 Jonathan Hefner 提交于
Example failure: https://buildkite.com/rails/rails/builds/68661#84f8790a-fc9e-42ef-a7fb-5bd15a489de8/1002-1012 The failing `destroyed_by_association` tests create an author (a DestroyByParentAuthor) and a book (a DestroyByParentBook) that belongs to that author. If the database already contains books that refer to that author's ID from previous tests (i.e. tests that disabled `use_transactional_tests`), then one of those books will be loaded and destroyed instead of the intended DestroyByParentBook book. By loading the `:books` fixtures, we ensure the database does not contain such unexpected books. Co-authored-by: NEugene Kenny <elkenny@gmail.com> Co-authored-by: NRyuta Kamizono <kamipo@gmail.com>
-
由 akinomaeni 提交于
before ``` p Knot.create => #<Knot id: 1, created_at: "2016-05-05 01:29:47"> ``` after ``` p Knot.create => #<Knot id: 1, created_at: "2016-05-05 01:29:47.116928000"> ```
-