Warning looked like this:

```
/Users/senny/Projects/rails/activerecord/lib/active_record/associations/association_scope.rb:142: warning: shadowing outer local variable - reflection
```

* Renames _handle_render_options to _render_to_body_with_renderer, which is more
  intention-revealing.

* The name of the dynamically generated method for a renderer with key :js was
  "_render_option_js".

  That name is too weak. :js is an option if you see the render argument as just
  a generic options hash, but in the context of renderers that's the renderer
  key, is what identifies the renderer.

  Now "_render_with_renderer_js" is generated instead, which is crystal clear.

* The name of the dynamically generated method for the renderer was constructed
  using string literals in a few places. That is now encapsulated in a method.

* Since we were on it, also removed a couple of redundant selfs.

Add support for ARIA attributes in tags

Methods are not duplicable.

[Active Job] Try to deserialize with GlobalID only strings and globalids

Ship with rails-html-sanitizer instead.

Dont mess with default order engines load (4.1.6.rc1 regression)

[Joshua Cody & Yves Senn]

Closes #16757.

Prior to this patch schema loading rake tasks had the potential to leak a
connection to a different database. This had side-effects when rake tasks
operating on the current connection (like `db:seed`) were chained.

Fix for double ActiveJob::DeserializationErorr

reset_column_infomation shouldn't be part of the assertion.

use correct operator in query based on JSON document [ci skip]

Move column option handling to new_column_definition

When copying migrations some engines might depend on schema from other
engine so we can't blindly reverse all railties collection as that would
affect the order they were originally loaded. This patch helps to only
apply the order from engines specified in `railties_order`

TableDefinition#column is not called from `add_column`.
Use TableDefinition#new_column_definition for column option handling.

Fix failing tests in ActiveJob Adapter

Remove 'if exists' from drop table statement then use `table_exists?`

Since 'drop table if exists' statement does not always work with
some databases such as Oracle.

Is this a thing we want?

Note current duplication between the `assert_select` section here, and
the corresponding release note entry... does this detail *move* from
there to here?

[ci skip]

Refactor add_constraints complex loop conditional

Shorten ActionView::Base doc summary line. [ci skip]

Clarify Rails uses erubis not stdlin ERB. [ci skip]

Remove '*' which doesn't belong [ci skip]

I found an * does not work in Markdown notation. It should be removed.

Add and Remove string/strip require

Method .strip_heredoc is defined in
active_support/core_ext/string/strip.rb so we need to require it.

[fixes #16677]

[ActiveJob] TestCase