We added a comparison to "id", and call to `self.class.primary_key` a
*lot*. We also have performance hits from `&block` all over the place.
We skip the check in a new method, in order to avoid breaking the
behavior of `read_attribute`

We don't have the check the range when the value is coming from the DB,
so override type_cast_from_database to short-circuit the extra work.
The difference is huge but the absolute gain is quite small. That being
said this is a hotspot and it showed up on the radar when benchmarking
discourse.

This reverts commit f93df528, reversing
changes made to a455e3f4.

Conflicts:
	actionpack/lib/action_controller/test_case.rb
	actionview/lib/action_view/test_case.rb

This appears to be a performance hotspot, see #17655.

Performance improvement, as well as improved code clarity

Ruby on Rails 3.0 Release Notes: fix broken link

fixed minor typos in RELEASE doc [ci skip]

PERF: stop allocating the string "id" over and over

This reverts commit 6f7910ae and 52c70d49.

Query params are type cased through the same method, so this approach doesn't work.

See comment on 6f7910ae

We don't have the check the range when the value is coming from the DB, so
override type_cast_from_database to short-circuit the extra work.

type_cast_from_database (small)  3437507.5 (±29.2%) i/s -   14223135 in   4.996973s
type_cast_from_database (large)  3158588.7 (±28.3%) i/s -   13265628 in   4.992121s
type_cast (small)                 481984.8 (±14.2%) i/s -    2352012 in   5.005694s
type_cast (large)                 477331.8 (±14.2%) i/s -    2332824 in   5.012365s

Comparison:
type_cast_from_database (small):  3437507.5 i/s
type_cast_from_database (large):  3158588.7 i/s - 1.09x slower
type_cast (small):                 481984.8 i/s - 7.13x slower
type_cast (large):                 477331.8 i/s - 7.20x slower

The difference is huge but the absolute gain is quite small. That being said
this is a hotspot and it showed up on the radar when benchmarking discourse.

Oh hey, we got to remove some code because of that!

Arel handles this for us automatically. Updated tests, as BindParam is
no longer a subclass of SqlLiteral. We should remove the second argument
to substitute_at entirely, as it's no longer used

If something causes the teardown block to not get run (errors,
interrupting test runs), we have to manually delete them, which is a
pain.

Fix typo. [ci skip]

This caused a pretty major performance regression for 4.2, as this is a
hotspot for query construction. We're still slightly slower than 4.1,
but it's much less significant.

Makes life easier for people profiling on master.

This class no longer has any private methods

PERF: optimise type lookup to avoid invoking procs

Skip spring install in Cygwin due to fork() bad support.

Fix for assigns(:..) resetting template assertions

Update to Unicode 7.0.0

Minor English fixes in docs [ci skip]

This is a more conservative approach to 2602a49a. Also changed the comment to be
more inline with everything else in the file (describing what the config value
is doing and why). People should just read the docs for alternatives.

This reverts commit 2602a49a, reversing
changes made to 5d7c1057.

The explicit default was introduced in 21f6d723, so apps created with Rails < 4
have the commented out version, which means that this change would break those
apps.

When calling assigns(:...) or cookies(:...), template assertions would be reset, which they obviously shouldn't be.