- 28 8月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
eventually we will refactor this to not know about header hashes
-
- 27 8月, 2015 27 次提交
-
-
由 Yves Senn 提交于
Follow up to #21384.
-
由 Yves Senn 提交于
Merge pull request #21384 from jeremyf/updating-ActionController-TestSession-to-behave-as-a-hash-with-indifferent Updating TestSession to access with indifference
-
由 Yves Senn 提交于
remove require of files under support that do not use
-
由 Yves Senn 提交于
no more require minitest mock here
-
由 Aaron Patterson 提交于
Rack::Response::Helpers implements this method, so we can safely remove it
-
由 Aaron Patterson 提交于
If the response method is defined, then calling `response` will return a response.
-
由 yuuji.yaginuma 提交于
I do not know why files under the support has been require. However, under the support even rails application does not use. In addition, since the default under the support file nor is generated, it requires I think not necessary
-
由 Aaron Patterson 提交于
If AV::Rendering is mixed in, then `rendered_format` will be calculated based on the current `lookup_context`, but calling `_process_format` will set the `rendered_format` back on to the same lookup context where we got the information in the first place! Instead of getting information from an object, then setting the same information back on to that object, lets just do nothing instead!
-
由 Aaron Patterson 提交于
Apparently the AbstractController (whatever "abstract" means) is expected to work without a request and response.
-
由 Aaron Patterson 提交于
`render` is the only possible source for the `plain` option. Pulling the conditional up to the `render` method removes far away conditionals
-
由 Aaron Patterson 提交于
We don't need to pass the full hash just to pull one value out. It's better to just pass the value that the method needs to know about so that we can abstract it away from "options"
-
由 Gaurav Sharma 提交于
-
由 Aaron Patterson 提交于
Since all controller instances are required to have a request and response object, RackDelegation is no longer needed (we always have to delegate to the response)
-
由 Aaron Patterson 提交于
the subclass sets the body on the response object, so we don't need the superclass doing it too
-
由 Aaron Patterson 提交于
without this module, the content type is not set correctly
-
由 Kasper Timm Hansen 提交于
Removed duplicate require 'minitest/mock'
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Now that `Controller#status=` just delegates to the response object, we don't need to set the response on the controller and the response. We can just set it in one place.
-
由 Aaron Patterson 提交于
we always have a response object, so there is no reason to test it
-
由 Aaron Patterson 提交于
these ivars don't exist anymore, so we can remove them from the list
-
由 Aaron Patterson 提交于
since the controller always has a request on it, we can just ask the request for the content type.
-
由 Aaron Patterson 提交于
The controller instance always has an instance of a response object. We should store the status code on the response object so that it's only store in one place.
-
由 Aaron Patterson 提交于
We always have a response object in controller instances, so we can remove this conditional
-
由 Aaron Patterson 提交于
controller instances always have a response object, so we don't need to test to see if there is one, just always call to_a on the response.
-
由 Rafael Mendonça França 提交于
Removed duplicate requires
-
由 Rafael Mendonça França 提交于
Use `ActiveRecord::Migration#connection` instead of `@connection`
-
由 Ronak Jangir 提交于
-
- 26 8月, 2015 12 次提交
-
-
由 Ronak Jangir 提交于
-
由 Yves Senn 提交于
Fix the unused variable warning
-
由 akihiro17 提交于
This fixes the following warning. ```ruby warning: assigned but unused variable - index_definition ```
-
由 Jeremy Friesen 提交于
The following Rails code failed (with a `KeyError` exception) under test: ```ruby class ApplicationController < ActionController::Base def user_strategy # At this point: # ```ruby # session == { # "user_strategy"=>"email", # "user_identifying_value"=>"hello@world.com" # } # ``` if session.key?(:user_strategy) session.fetch(:user_strategy) end end end ``` When I checked the session's keys (`session.keys`), I got an array of strings. If I accessed `session[:user_strategy]` I got the expected `'email'` value. However if I used `session.fetch(:user_strategy)` I got a `KeyError` exception. This appears to be a Rails 4.2.4 regression (as the code works under Rails 4.2.3). Closes #21383
-
由 Yves Senn 提交于
Fixed to_datetime docs [ci skip]
-
由 Ronak Jangir 提交于
-
由 Aaron Patterson 提交于
Controllers should always have a request and response when responding. Since we make this The Rule(tm), then controllers don't need to be somewhere in limbo between "asking a response object for a rack response" or "I, myself contain a rack response". This duality leads to conditionals spread through the codebase that we can delete: * https://github.com/rails/rails/blob/85a78d9358aa728298cd020cdc842b55c16f9549/actionpack/lib/action_controller/metal.rb#L221-L223
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
collect the body and make assert against the collected body
-
由 Aaron Patterson 提交于
we don't need an instance to figure out what type of response to allocate. Later we'll pull this up the stack and pass the response object down
-
由 Aaron Patterson 提交于
This saves a lambda and request allocation on each request.
-