1. 17 5月, 2013 4 次提交
    • J
      Fix detection of engine in rake db:load_config · 97a4a771
      Joel Cogen 提交于
      Broken by d1d7c86d
      97a4a771
    • S
      Fix named routing regression from 3.2.13 · 6167d76d
      schneems 提交于
      When named route that is nested is used in 3.2.13
      
      Example `routes.rb`:
      
      ```
      resources :nested do
        resources :builder, :controller => 'nested/builder'
      end
      ```
      
      In 3.2.12 and 3.2.12 this named route would work:
      
      ```
      nested_builder_path(:last_step, :nested_id => "foo")
      ```
      
      Generating a url that looks like `/nested/foo/builder/last_step`. This PR fixes the regression when building urls via the optimized helper. Any explicit keys set in the options are removed from the list of implicitly mapped keys.
      
      Not sure if this is exactly how the original version worked, but this fixes this use case regression.
      6167d76d
    • R
      Revert "Integration tests support the OPTIONS http method" · 14f90868
      Rafael Mendonça França 提交于
      This reverts commit ad46884a.
      
      Conflicts:
      	actionpack/CHANGELOG.md
      	actionpack/lib/action_dispatch/testing/integration.rb
      	actionpack/test/controller/integration_test.rb
      
      Reason: It will conflict with a lot of test cases. Better to call
      `process` directly since this is a very uncommon HTTP method.
      
      Fixes #10638.
      14f90868
    • R
      Merge pull request #10645 from rubys/consistent_gemfile_spacing · 807bcfa9
      Rafael Mendonça França 提交于
      restore whitespace in Gemfile between sqlite3 and sprockets
      807bcfa9
  2. 16 5月, 2013 3 次提交
  3. 15 5月, 2013 1 次提交
  4. 13 5月, 2013 7 次提交
  5. 12 5月, 2013 2 次提交
  6. 10 5月, 2013 1 次提交
  7. 09 5月, 2013 2 次提交
  8. 08 5月, 2013 1 次提交
  9. 07 5月, 2013 1 次提交
  10. 04 5月, 2013 8 次提交
  11. 03 5月, 2013 7 次提交
    • C
      Fix failures in AS with minitest 4.7.4 · 8ffba84b
      Carlos Antonio da Silva 提交于
      8ffba84b
    • J
      Work around change in how MiniTest detects SIGINFO · 1a910987
      Jon Leighton 提交于
      MiniTest 4.7.3 detects the presence of SIGINFO and stores the answer in
      a constant.
      
      It seems that MiniTest 4.7.4 changes this, and instead relies on an
      info_signal method being implemented on the runner object.
      
      In ActiveSupport::Testing::Isolation, we use ProxyTestResult to stand in
      for the runner object. This object implements `method_missing`, and as
      such its #info_signal method has a truthy return value. This results in
      MiniTest trying to install the SIGINFO handler on platforms where
      SIGINFO does not exists.
      
      To fix, I am simply defining an explicit ProxyTestResult#info_signal
      method.
      1a910987
    • J
      Fix broken mysql test · 3652e4e6
      Jon Leighton 提交于
      test_mysql_integer_not_null_defaults in test/cases/defaults_test.rb was
      failing. This test relies on the connection being in strict mode. By
      default a new connection is not in strict mode, but Active Record
      automatically places it in strict mode.
      
      ActiveSchemaTest overwrites the connection's #execute method in order to
      prevent SQL statements from actually being executed. One of the
      operations which is performed in ActiveSchema test is a #recreate_database.
      
      Since 2088bf27, recreate_database on
      mysql or mysql2 will trigger a reconnect.
      
      Due to the implementation of the hacking of #execute in
      ActiveSchemaTest, this reconnect would take place, but the connection
      would *not* be placed in strict mode because #execute had been
      overridden to prevent SQL queries hitting the database.
      
      Therefore, after ActiveSchemaTest, the connection would no longer be in
      strict mode, causing test_mysql_integer_not_null_defaults to fail.
      
      I don't think that the way that ActiveSchemaTest is implemented is
      particularly nice or clean, but I have taken steps to make its hacks
      more isolated - it now create a separate connection object which is
      thrown away after the test, and the hacks are applied on the singleton
      class of this object.
      3652e4e6
    • R
      Merge pull request #10424 from markevich/fix_test_prepare · 57584e4f
      Rafael Mendonça França 提交于
      Restore ActiveRecord connection to original environment after rake:db:test:prepare task.
      57584e4f
    • R
      Merge pull request #10431 from larskanis/add_note_about_libpq_params_in_changelog · c1781776
      Rafael Mendonça França 提交于
      Add note about new database parameters for PostgreSQL adapter in CHANGELOG
      c1781776
    • L
      Add note about libpq connection params in CHANGELOG · 0fa3f3ea
      Lars Kanis 提交于
      0fa3f3ea
    • C
      Merge pull request #10426 from tkrajcar/rescue-h1-fix · 417bdbbf
      Carlos Antonio da Silva 提交于
      Add styling to h1 for default rescue layout
      417bdbbf
  12. 02 5月, 2013 3 次提交