- 23 11月, 2013 6 次提交
-
-
由 Arun Agrawal 提交于
-
由 Jeremy Kemper 提交于
Don't call #as_json on children of Array and Hash with nil when no arguments are passed
-
由 Yves Senn 提交于
Fix validation on uniqueness
-
由 Godfrey Chan 提交于
should also call #as_json on the children without options (instead of nil)
-
由 Evgeny Li 提交于
-
由 Rafael Mendonça França 提交于
Since we are using assert_no_match, if we change the code before changing the tests, the tests will still pass and the assertion will become useless
-
- 22 11月, 2013 22 次提交
-
-
由 Rafael Mendonça França 提交于
Fix the assertion for not inclusion of turbolinks on application.js.
-
由 Lauro Caetano 提交于
We were asserting if `//= turbolinks` was not present while the correct is asserting that `//= require turbolinks` is not present.
-
由 Carlos Antonio da Silva 提交于
Also make Action Mailer changelog format more consistent with the others [ci skip]
-
由 Yves Senn 提交于
Build fix for new routing inspector changes
-
由 Arun Agrawal 提交于
Broken by 6701b4cf
-
由 Guillermo Iguaran 提交于
Added a missing close parenthesis to i18n.md
-
由 Jacob Evan Shreve 提交于
-
由 Rafael Mendonça França 提交于
Option to skip turbolinks
-
由 Lauro Caetano 提交于
that skips it. It can be skipped adding `add_gem_entry_filter { |gem| gem.name != "turbolinks" }` to the template.
-
由 Rafael Mendonça França 提交于
Fix for titles of info pages
-
由 Sıtkı Bağdat 提交于
Both `rails/info/properties` and `rails/info/routes` have same html title attribute as *Routes*. This commit includes a fix for the titles.
-
由 Rafael Mendonça França 提交于
Build fix for Routing Inspector
-
由 Arun Agrawal 提交于
Broken by 6701b4cf
-
由 Rafael Mendonça França 提交于
This reverts commit 5a19346d, reversing changes made to d82588ee. This argument is being used in the view https://github.com/rails/rails/blob/5a19346d2855ecb1c791cdef3af92589566d00db/actionpack/lib/action_dispatch/journey/visualizer/index.html.erb#L4 It is being set using the binding https://github.com/rails/rails/blob/5a19346d2855ecb1c791cdef3af92589566d00db/actionpack/lib/action_dispatch/journey/gtg/transition_table.rb#L108
-
由 Rafael Mendonça França 提交于
Remove unused param `title`to `TransitionTable#visualizer`
-
由 Vipul A M 提交于
-
由 Xavier Noria 提交于
Use `SchemaStatements#initialize_schema_migrations_table` instead of `ActiveRecord::SchemaMigration.create_table`.
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Fix for routes task
-
由 Yves Senn 提交于
-
由 Sıtkı Bağdat 提交于
This commit fixes formatting issue for `rake routes` task, when a section is shorter than a header.
-
由 Yves Senn 提交于
-
- 21 11月, 2013 7 次提交
-
-
由 Carlos Antonio da Silva 提交于
Add positional information to eval call so that this information will be used in printing correct location where the exception occurred. Closes #12885.
-
由 Carlos Antonio da Silva 提交于
replace U+00A0 with whitespace, Fixes #12985
-
由 Dmitriy Budnik 提交于
-
由 Xavier Noria 提交于
Faster String#blank?
-
由 Aman Gupta 提交于
-
由 Jon Leighton 提交于
I'm pretty confused about the addition of this method. The documentation says that it was intended to allow the removal of values from the default scope (in contrast to #except). However it behaves exactly the same as except: https://gist.github.com/jonleighton/7537008 (other than having a slightly enhanced syntax). The removal of the default scope is allowed by 94924dc3, which was not a change we could make until 4.1 due to the need to deprecate things. However after that change #unscope still gives us nothing that #except doesn't already give us. However there *is* a desire to be able to unscope stuff in a way that persists across merges, which would allow associations to be defined which unscope stuff from the default scope of the associated model. E.g. has_many :comments, -> { unscope where: :trashed } So that's what this change implements. I've also corrected the documentation. I removed the guide references to #except as I think unscope really supercedes #except now. While we're here, there's also a potential desire to be able to write this: has_many :comments, -> { unscoped } However, it doesn't make sense and would not be straightforward to implement. While with #unscope we're specifying exactly what we want to be removed from the relation, with "unscoped" we're just saying that we want it to not have some things which were added earlier on by the default scope. However in the case of an association, we surely don't want *all* conditions to be removed, otherwise the above would just become "SELECT * FROM comments" with no foreign key constraint. To make the above work, we'd have to somehow tag the relation values which get added when evaluating the default scope in order to differentiate them from other relation values. Which is way too much complexity and therefore not worth it when most use cases can be satisfied with unscope. Closes #10643, #11061.
-
由 Prathamesh Sonpatki 提交于
be used in printing correct location where the exception occurred. Closes #12885 - Without this the location of exception is always the line on which 'eval' is called - But if the exception occurs in a gem outside of Rails, then that location is not printed in stacktrace
-
- 20 11月, 2013 5 次提交
-
-
由 Yves Senn 提交于
-
由 Xavier Noria 提交于
Add `#travel` and `#travel_to` to `ActiveSupport::TestCase`
-
由 Prem Sichanugrist 提交于
Add `ActiveSupport::Testing::TimeHelpers#travel` and `#travel_to`. These methods change current time to the given time or time difference by stubbing `Time.now` and `Date.today` to return the time or date after the difference calculation, or the time or date that got passed into the method respectively. These methods also accept a block, which will return current time back to its original state at the end of the block. Example for `#travel`: Time.now # => 2013-11-09 15:34:49 -05:00 travel 1.day Time.now # => 2013-11-10 15:34:49 -05:00 Date.today # => Sun, 10 Nov 2013 Example for `#travel_to`: Time.now # => 2013-11-09 15:34:49 -05:00 travel_to Time.new(2004, 11, 24, 01, 04, 44) Time.now # => 2004-11-24 01:04:44 -05:00 Date.today # => Wed, 24 Nov 2004 Both of these methods also accept a block, which will return the current time back to its original state at the end of the block: Time.now # => 2013-11-09 15:34:49 -05:00 travel 1.day do User.create.created_at # => Sun, 10 Nov 2013 15:34:49 EST -05:00 end travel_to Time.new(2004, 11, 24, 01, 04, 44) do User.create.created_at # => Wed, 24 Nov 2004 01:04:44 EST -05:00 end Time.now # => 2013-11-09 15:34:49 -05:00 This module is included in `ActiveSupport::TestCase` automatically.
-
由 Ryuta Kamizono 提交于
Use `SchemaStatements#initialize_schema_migrations_table` instead of `ActiveRecord::SchemaMigration.create_table`.
-
由 Rafael Mendonça França 提交于
Update caching guide with respect to :namespace
-