1. 07 3月, 2016 2 次提交
  2. 05 3月, 2016 1 次提交
  3. 04 3月, 2016 2 次提交
    • K
      [ci skip] Fix constrain_to documentation. · daeaac70
      Kasper Timm Hansen 提交于
      Forgot to update the documentation on the line just above the one
      I was changing in 49331322. Well done, Kasper 👍
      daeaac70
    • K
      Rename constrain_to to exclude. · 49331322
      Kasper Timm Hansen 提交于
      `ActionDispatch::SSL` redirects all HTTP requests to HTTPS, not just some.
      The `constrain_to` option inverts this, so it sounds like the middleware
      only handles a few requests, rather than the majority with a few routes to
      opt out of the redirect.
      
      Renaming to `exclude` matches this intent more closely.
      49331322
  4. 03 3月, 2016 3 次提交
  5. 02 3月, 2016 1 次提交
    • M
      Fix typo in implicit_render · 9cb7a228
      Max Woolf 提交于
      When trying to make a request and the request doesn't have a suitable template, the new error messages are really helpful but there's a small (and I mean, VERY small) typo that has been bugging me for the last few days. This adds the space and restores order to the universe. 
      9cb7a228
  6. 01 3月, 2016 3 次提交
  7. 29 2月, 2016 3 次提交
  8. 26 2月, 2016 3 次提交
  9. 25 2月, 2016 6 次提交
    • K
      Additional review of 6b317617. · 46cb45df
      Kasper Timm Hansen 提交于
      * Fixes typos in error message and release notes.
      * Removes unused template test file.
      46cb45df
    • G
      Lock down new `ImplicitRender` behavior for 5.0 RC · 73b1efc5
      Godfrey Chan 提交于
      1. Conceptually revert #20276
      
         The feature was implemented for the `responders` gem. In the end,
         they did not need that feature, and have found a better fix (see
         plataformatec/responders#131).
      
         `ImplicitRender` is the place where Rails specifies our default
         policies for the case where the user did not explicitly tell us
         what to render, essentially describing a set of heuristics. If
         the gem (or the user) knows exactly what they want, they could
         just perform the correct `render` to avoid falling through to
         here, as `responders` did (the user called `respond_with`).
      
         Reverting the patch allows us to avoid exploding the complexity
         and defining “the fallback for a fallback” policies.
      
      2. `respond_to` and templates are considered exhaustive enumerations
      
         If the user specified a list of formats/variants in a `respond_to`
         block, anything that is not explicitly included should result
         in an `UnknownFormat` error (which is then caught upstream to
         mean “406 Not Acceptable” by default). This is already how it
         works before this commit.
      
         Same goes for templates – if the user defined a set of templates
         (usually in the file system), that set is now considered exhaustive,
         which means that “missing” templates are considered `UnknownFormat`
         errors (406).
      
      3. To keep API endpoints simple, the implicit render behavior for
         actions with no templates defined at all (regardless of formats,
         locales, variants, etc) are defaulted to “204 No Content”. This
         is a strictly narrower version of the feature landed in #19036 and
         #19377.
      
      4. To avoid confusion when interacting in the browser, these actions
         will raise an `UnknownFormat` error for “interactive” requests
         instead. (The precise definition of “interactive” requests might
         change – the spirit here is to give helpful messages and avoid
         confusions.)
      
      Closes #20666, #23062, #23077, #23564
      
      [Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]
      73b1efc5
    • P
      Update documentation and deprecation message · 4e92fb20
      Prathamesh Sonpatki 提交于
      4e92fb20
    • P
      Added deprecation for older apps · 31cf0f55
      Prathamesh Sonpatki 提交于
      - For old apps which are not setting any value for hsts[:subdomains],
        a deprecation warning will be shown saying that hsts[:subdomains] will
        be turned on by default in Rails 5.1. Currently it will be set to
        false for backward compatibility.
      - Adjusted tests to reflect this change.
      31cf0f55
    • E
      HSTS without IncludeSubdomains is often useless · 6eb3a1b0
      Egor Homakov 提交于
      1) Because if you forget to add Secure; to the session cookie, it will leak to http:// subdomain in some cases
      2) Because http:// subdomain can Cookie Bomb/cookie force main domain or be used for phishing.
      
      That's why *by default* it must include subdomains as it's much more common scenario. Very few websites *intend* to leave their blog.app.com working over http:// while having everything else encrypted. 
      
      Yes, many developers forget to add subdomains=true by default, believe me :)
      6eb3a1b0
    • A
      a39e195a
  10. 24 2月, 2016 10 次提交
  11. 23 2月, 2016 3 次提交
    • J
      Add `internal` attribute to routes · cd8bb8b6
      Jon Moss 提交于
      This is meant to provide a way for Action Cable, Sprockets, and possibly
      other Rack applications to mark themselves as internal, and to exclude
      themselves from the routing inspector, and thus `rails routes` / `rake
      routes`.
      
      I think this is the only way to have mounted Rack apps be marked as
      internal, within AD/Journey. Another option would be to create an array
      of regexes for internal apps, and then to iterate over that everytime a
      request comes through. Also, I only had the first `add_route` method set
      `internal`'s default to false, to avoid littering it all over the
      codebase.
      cd8bb8b6
    • R
      Transform the mime object to symbol when registering the parsers · a087cf43
      Rafael Mendonça França 提交于
      This will keep our current API working without having the users to
      change their codebases.
      a087cf43
    • M
      Use symbol of mime type instead of object to get correct parser · 97ed810c
      Mehmet Emin İNAÇ 提交于
      After registering new `:json` mime type `parsers.fetch` can't find the mime type because new mime type is not equal to old one. Using symbol of the mime type as key on parsers hash solves the problem.
      
      Closes #23766
      97ed810c
  12. 22 2月, 2016 1 次提交
  13. 19 2月, 2016 2 次提交