- 05 12月, 2014 18 次提交
-
-
由 Santiago Pastorino 提交于
Fix typo in "Hello World" template in German
-
由 Tu Hoang 提交于
-
由 Sean Griffin 提交于
Remove deprecated behavior allowing nested arrays as query values
-
由 Sean Griffin 提交于
Active Record defines `attribute_method_suffix :?`. That suffix will match any predicate method when the lookup occurs in Active Model. This will make it incorrectly decide that `id_changed?` should not exist, because it attempts to determine if the attribute `id_changed` is present, rather than `id` with the `_changed?` suffix. Instead, we will look for any correct match.
-
由 Sean Griffin 提交于
Remove environment dependency for db:schema:load
-
由 Melanie Gilman 提交于
-
由 Caleb Thompson 提交于
All of the behavior :environment was giving (that db:schema:load needed) was provided as well with :load_config. This will address an issue introduced in https://github.com/rails/rails/pull/15394. The fact that db:schema:load now drops and creates the database causes the Octopus gem to have [an issue](https://github.com/tchandy/octopus/issues/273) during the drop step for the test database (which wasn't happening in db:schema:load before). The error looks like: ActiveRecord::StatementInvalid: PG::ObjectInUse: ERROR: cannot drop the currently open database : DROP DATABASE IF EXISTS "app_test" Because of the timing, this issue is present in master, 4-2-*, and 4.1.8. A note to forlorn developers who might see this: "Additionally" in a commit message means you should have a separate commit, with a separate justification for changes. Small commits with big messages are your friends.
-
由 Sean Griffin 提交于
Deprecate `Class` handler in `PredicateBuilder`
-
由 Rafael Mendonça França 提交于
Don't remove mailer layouts files
-
由 Rafael Mendonça França 提交于
Fix Sidekiq ActiveJob integration setup Conflicts: activejob/test/support/integration/adapters/sidekiq.rb
-
由 Melanie Gilman 提交于
Users should pass strings to queries instead of classes
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
allow 'all' for :domain option in addition to :all
-
由 Rafael Mendonça França 提交于
Add documentation to six AS::TimeWithZone methods [ci skip]
-
由 Rafael Mendonça França 提交于
Fix MessageVerifier's #verified in CHANGELOG
-
由 claudiob 提交于
[ci skip] As confirmed by @lleger (the author of `verified`) [in this comment](https://github.com/rails/rails/pull/17727#issuecomment-65488743): > Actually, it no longer returns false explicitly (bc8cc56a), so I guess the CHANGELOG isn't totally accurate. It returns nil instead (but the functionality isn't practically different).
-
由 claudiob 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
-
- 04 12月, 2014 21 次提交
-
-
由 Rafael Mendonça França 提交于
remove unused #await_close
-
由 Rafael Mendonça França 提交于
Add documentation to MessageVerifier
-
由 Rafael Mendonça França 提交于
Prevent Symbol GC
-
由 Richard Schneeman 提交于
remove misleading class [ci skip]
-
由 Sergey Alekseev 提交于
The method was added in https://github.com/rails/rails/commit/30d21dfcb7fafe49b3805b8249454485a90097b6#diff-5055d9f16b442adb1d2f0f65903a196bR141. With the method call in https://github.com/rails/rails/commit/30d21dfcb7fafe49b3805b8249454485a90097b6#diff-cc7bb557df2247c0a42bc180fdb6eb05R47. Later one more method call was added in https://github.com/rails/rails/commit/401787db4bc428dce88b04e343a64c6a6c3b681c#diff-cc7bb557df2247c0a42bc180fdb6eb05R183. And both method calls were deleted in https://github.com/rails/rails/commit/3df07d093a1e4207caa63fd2e3b67599211f5800#diff-cc7bb557df2247c0a42bc180fdb6eb05L47 and https://github.com/rails/rails/commit/3df07d093a1e4207caa63fd2e3b67599211f5800#diff-cc7bb557df2247c0a42bc180fdb6eb05L189. Just do `grep -nr 'await_close' .`.
-
由 Sergey Alekseev 提交于
-
由 Santiago Pastorino 提交于
Remove "rescue" clause around "require 'openssl'"
-
由 Yves Senn 提交于
This `# :nodoc:` had the effect of hiding every method that follows. This meant that the API page for `ActiveRecord::Core` only contained `configurations` and none of the following methods. Furthermore this `# :nodoc:` had no effect on `maintain_test_schema`. Those `mattr_accessor` inside the `included` block are not picked up by rdoc. /cc @zzak
-
由 Yves Senn 提交于
Correct docs for ActiveRecord batching methods [ci skip]
-
由 claudiob 提交于
Some `require 'openssl'` statements were surrounded by `rescue` blocks to deal with Ruby versions that did not support `OpenSSL::Digest::SHA1` or `OpenSSL::PKCS5`. [As @jeremy explains](https://github.com/rails/rails/commit/a6a0904fcb12b876469c48b1c885aadafe9188cf#commitcomment-8826666) in the original commit: > If jruby didn't have jruby-openssl gem, the require wouldn't work. Not sure whether either of these are still relevant today. According to the [release notes for JRuby 1.7.13](http://www.jruby.org/2014/06/24/jruby-1-7-13.html): > jruby-openssl 0.9.5 bundled which means the above `rescue` block is not needed anymore. All the Ruby versions supported by the current version of Rails provide those OpenSSL libraries, so Travis CI should also be happy by removing the `rescue` blocks. --- Just to confirm, with JRuby: $ ruby --version #=> jruby 1.7.16.1 (1.9.3p392) 2014-10-28 4e93f31 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_20-b26 +jit [darwin-x86_64] $ irb irb(main):001:0> require 'openssl' #=> true irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1 irb(main):003:0> OpenSSL::PKCS5 # => OpenSSL::PKCS5 And with Ruby 2.1: $ ruby --version #=> ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0] $ irb irb(main):001:0> require 'openssl' #=> true irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1 irb(main):003:0> OpenSSL::PKCS5 #=> OpenSSL::PKCS5
-
由 Ryuta Kamizono 提交于
-
由 Isaac Seymour 提交于
Clarify that batching methods can be used with any orderable type primary key, not just integer ones, as per @a58cafeb
-
由 Guillermo Iguaran 提交于
Removed use of mocha in the info_controller tests
-
由 Sean Griffin 提交于
Move PredicateBuilder instantiation to constructor
-
由 Yves Senn 提交于
[ci skp]
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Failure to rollback t.timestamps when within a change_table migration
-
由 Melanie Gilman 提交于
In order to maintain thread safety and prevent race condition from memoization.
-
由 noam 提交于
When running the following migration: change_table(:table_name) { |t| t/timestamps } The following error was produced: wrong number of arguments (2 for 1) .... /connection_adapters/abstract/schema_statements.rb:851:in `remove_timestamps' This is due to `arguments` containing an empty hash as its second argument.
-
由 Yves Senn 提交于
[ci skip] This is due to the fact that `.delete` is directly translated to SQL. It tries to follow the same rules as `.delete_all` which is not able to verify that records are `#readonly?`.
-
- 03 12月, 2014 1 次提交
-
-
由 Yves Senn 提交于
-