- 22 8月, 2015 15 次提交
-
-
由 Jon Atack 提交于
- Fixes: "we want go deep" -> "we won't go deep" "to next next line" -> "to the next line" - Minor improvements in clarity and grammar. Cheers :)
-
由 Akira Matsuda 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
we want to go through methods to access `env` because in the future that ivar may not be available, or may be calculated lazily
-
由 Aaron Patterson 提交于
now the parameter filter doesn't need to know about the env hash in these two methds.
-
由 Aaron Patterson 提交于
Now the Headers internals don't depend on the env hash.
-
由 Aaron Patterson 提交于
This prevents external mutations from impacting the internals of the request or the Header object.
-
由 Aaron Patterson 提交于
this reduces the API footprint for the env hash so that we can be more flexible when changing API in the future
-
由 Aaron Patterson 提交于
This allows us to avoid calling `env_name` twice.
-
由 Aaron Patterson 提交于
duping the request will dup it's underlying env hash.
-
由 Sean Griffin 提交于
Several changes were made in #21110 which I am strongly opposed to. (this is what I get for going on vacation. :trollface:) No type should be introduced into the generic `ActiveRecord::Type` namespace, and *certainly* should not be registered into the registry unconstrained unless it is supported by *all* adapters (which basically means that it was specified in the ANSI SQL standard). I do not think `# :nodoc:` ing the type is sufficient, as it still makes the code of Rails itself very unclear as to what the role of that class is. While I would argue that this shouldn't even be a super class, and that MySql and PG's JSON types are only superficially duplicated (they might look the same but will change for different reasons in the future). However, I don't feel strongly enough about it as a point of contention (and the biggest cost of harming the blameability has already occured), so I simply moved the superclass into a namespace where its role is absolutely clear. After this change, `attribute :foo, :json` will once again work with MySQL and PG, but not with Sqlite3 or any third party adapters. Unresolved questions -------------------- The types that and adapter publishes (at least those are unique to that adapter, and not adding additional behavior like `MysqlString` should probably be part of the adapter's public API. Should we standardize the namespace for these, and document them?
-
由 Godfrey Chan 提交于
-
由 eileencodes 提交于
`ActiveSupport::Dependencies.constantize(const_name)` calls `Reference.new` which is defined as `ActiveSupport::Dependencies.constantize(const_name)` meaning this call is already cached and we're doing caching that isn't necessary.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
I'm going to change the constructor, so it's easier to do it in one place.
-
- 21 8月, 2015 13 次提交
-
-
由 Andrew White 提交于
Remove duplicity in tests
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Small fixes [ci skip]
-
由 Alexey Markov 提交于
-
由 Yves Senn 提交于
Fix Punctuation in `AutosaveAssociation` RDoc [ci skip]
-
由 Aaron Patterson 提交于
This way we can make the Route object a read-only data structure.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Robert Eshleman 提交于
[ci skip]
-
由 Kasper Timm Hansen 提交于
Removed mocha from ActionMailer
-
由 Alexey Markov 提交于
-
由 Matthew Draper 提交于
File renaming should be the last operation of an atomic write
-
- 20 8月, 2015 11 次提交
-
-
由 Jean Boussier 提交于
-
由 Yves Senn 提交于
fix path of annotations.rake [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Yves Senn 提交于
Closes #21304. While we can validate uniqueness for record without primary key on creation, there is no way to exclude the current record when updating. (The update itself will need a primary key to work correctly).
-
由 Yves Senn 提交于
Correct cache store superclass in comment [ci skip]
-
由 Ronak Jangir 提交于
-
由 Kasper Timm Hansen 提交于
Cleaned up generators tests using internal assertion helper
-
由 Ronak Jangir 提交于
-
由 Rafael Mendonça França 提交于
Migrate to Sprockets 4.
-
由 Jonah Burke 提交于
-
由 Andrei Istratii 提交于
-
- 19 8月, 2015 1 次提交
-
-
由 Guillermo Iguaran 提交于
Add code of conduct info to README.md and to contributing guide
-