- 15 4月, 2020 12 次提交
-
-
由 Ryuta Kamizono 提交于
Remove unused Arel visitors in the code base
-
由 Ryuta Kamizono 提交于
This removes ibm_db, informix, mssql, oracle, and oracle12 Arel visitors which are not used in the code base. Actually oracle and oracle12 visitors are used at oracle-enhanced adapter, but now I think that those visitors should be in the adapter's repo like sqlserver adapter and the dedicated Arel visitor (https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/master/lib/arel/visitors/sqlserver.rb), otherwise it is hard to find a bug and review PRs for the oracle visitors (e.g. #35838, #37646), since we don't have knowledge and environment enough for Oracle.
-
由 Kasper Timm Hansen 提交于
use number instead of string in application.rb in Rails guide
-
由 brchristian 提交于
-
由 Rafael França 提交于
Raise template errors on correct line with annotations enabled
-
由 Joel Hawksley 提交于
Co-authored-by: NAaron Patterson <tenderlove@github.com>
-
由 Joel Hawksley 提交于
-
由 Eugene Kenny 提交于
Correct ruby-pg repo link in rdocs
-
由 John Hawthorn 提交于
Avoid ActionView rendering instrumentation indirection
-
由 Navneet Pandey 提交于
-
由 John Hawthorn 提交于
Improve ActiveSupport Parallelization error logging
-
由 Rafael França 提交于
Prevent has_one from touching parent record unless persisted
-
- 14 4月, 2020 15 次提交
-
-
由 Ryuta Kamizono 提交于
Update SchemaCacheTest#schema_dump_path
-
由 Ryuta Kamizono 提交于
Remove dead test code for unsupported adapters
-
由 Ali Ibrahim 提交于
* Use ASSETS_ROOT (defined in activerecord/test/config.rb) to guarantee a valid path to schema_dump_5_1.yml.
-
由 Josh 提交于
Previously, if `build_association` was called multiple times for a `has_one` association but never committed to the database, the first newly-associated record would trigger `touch` during the attempted removal of the record. For example: class Post < ActiveRecord::Base has_one :comment, inverse_of: :post, dependent: :destroy end class Comment < ActiveRecord::Base belongs_to :post, inverse_of: :comment, touch: true end post = Post.create! comment_1 = post.build_comment comment_2 = post.build_comment When `comment_2` is initialized, the `has_one` would attempt to destroy `comment_1`, triggering a `touch` on `post` from an association record that hasn't been committed to the database. This removes the attempt to delete an associated `has_one` unless it’s persisted.
-
由 Rafael Mendonça França 提交于
This deprecation is useless since the result is still an Error object and there is no way to fix the code to remove the deprecation. Let's just accept as a breaking change.
-
由 David Heinemeier Hansson 提交于
-
由 Eugene Kenny 提交于
Followup to e7514dc6.
-
由 Lee Quarella 提交于
-
由 Rafael França 提交于
Ignore Errno::ENOTEMPTY when calling AS::Cache::FileStore#clear with race conditions
-
由 Rafael França 提交于
Load XML Builder if it is not available
-
由 Derek Hammer 提交于
-
由 Rafael França 提交于
Document update for ActiveModel#errors
-
由 Rafael França 提交于
Fix perform_enqueued_jobs without a block inside other helpers
-
由 Étienne Barrié 提交于
assert_enqueued_with with a block ignores all the jobs enqueued before the block for its assertions by counting the number of jobs and dropping the n first elements from the Array, but since we're now mutating the Array in perform_enqueued_jobs without a block, it's broken. This uses another implementation which is correct when the array is mutated, by getting a duplicated array of jobs, then removing them from the original array. Similarly assert_enqueued_jobs with a block was using counts only, now keeps track of the specific jobs to count them at the end.
-
由 Rafael França 提交于
Reduce calls to get path info when finding routes
-
- 13 4月, 2020 3 次提交
-
-
由 Lee Quarella 提交于
-
由 Lee Quarella 提交于
-
由 Eugene Kenny 提交于
Followup to b94efe9f.
-
- 12 4月, 2020 10 次提交
-
-
由 Ryuta Kamizono 提交于
Fix random CI fail due to non-deterministic order
-
由 Jonathan Hefner 提交于
Example failure: https://buildkite.com/rails/rails/builds/68187#333e3624-ac0d-4b23-95b9-f068d9901093/1016-1028 These tests expect the 2nd Account fixture (with a NULL `firm_id`) to be in the first four rows of the result set, but that behavior is not guaranteed without an `order`.
-
由 Ryuta Kamizono 提交于
FrontBase and IBM_DB adapters do not work for Rails 5.2. https://rubygems.org/gems/ruby-frontbase https://rubygems.org/gems/ibm_db
-
由 Eugene Kenny 提交于
Remove reference to global rails command
-
由 Ryuta Kamizono 提交于
Related #15137. Firebird related code is already removed in #15137. We have two `current_adapter?(:DB2Adapter)` in tests, but the adapter is no longer maintained (last release is November 15, 2012). https://rubygems.org/gems/db2 Yet another (latest) DB2 adapter (`IBM_DBAdapter`) might support Rails 5.0.7, but apparently do not work for Rails 5.2. https://rubygems.org/gems/ibm_db We have few lines mention about DB2 in the doc, but now there is no worth for almost all current users.
-
由 Ryuta Kamizono 提交于
Do not expose association relation in the API doc [ci skip]
-
由 Ryuta Kamizono 提交于
Allow extra scoping in callbacks when create on association relation
-
由 Ryuta Kamizono 提交于
Remove dead code in tests
-
由 Kir Shatrov 提交于
-
由 Haroon Ahmed 提交于
-