Just noticed this on the [edge API].

[ci skip]

[edge API]: http://edgeapi.rubyonrails.org/classes/ActiveRecord/Transactions/ClassMethods.html

This reverts commit 5d1b7c3b.

The change here didn't actually fix the issue it was trying to fix, and
this isn't the correct way to fix either issue. The problem is switching
from the builder to grouping with find_all/regex is now very dependent
on how you structure your path pattern.

Changed html_safe to raw in AV

html_safe is not supposed to be public API for AV. This change removes usage of html_safe in favour of raw() in AV helpers.
Also changed usage of html_safe to make use of raw() instead so that the intended behaviour is verified with raw()

Pluralize counter_cache column name in example [ci skip]

Adapterize storage for ActionCable

Update CHANEGLOG for https://github.com/rails/rails/pull/20005 [ci skip]

Revert "Its ideal to set Vary: Accept-Encoding, irrespective of whether gzipped version exists or not. This is helpful for CDN's to later distinguish assets, based on previous, current copies and introduced gzip version if any."

This reverts commit 067c52f6.

Conversation: https://github.com/rails/rails/pull/23120#issuecomment-173007011

We want this method to be the single canonical source of information
about type metadata related to a model. This is the method I've been
continuously recommending people use if they need this sort of access,
as I have no plans to remove or change it at any point in the future.

We can do ourselves a favor and get people to use this instead of
relying on some other part of the internals that they shouldn't be by
making this method public.

Its ideal to set Vary: Accept-Encoding, irrespective of whether gzipped or not

[ci skip] update guide for Puma web server instead of Webrick

Rails 5.0 default server puma web server. following commit - https://github.com/rails/rails/commit/ae48ea69

- Changed from bin/rake to bin/rails at more application places. [ci skip]

- Only ones left are from the upgrading guide, and command line guide explicit section about rake

Follow up of https://github.com/rails/rails/pull/23119
[ci skip]

[close #23084] Deprecated StrongParameters

use bin/rails default instead of rake commands [ci skip]

Its ideal to set Vary: Accept-Encoding, irrespective of whether gzipped version exists or not. This is helpful for CDN's to later distinguish assets, based on previous, current copies and introduced gzip version if any.

For ref: https://www.fastly.com/blog/best-practices-for-using-the-vary-header

This change sets `Vary` header always, to be on safer side

I go through the `http://edgeguides.rubyonrails.org/` and found `rake` commands in various files that are in RAILS 5.0 implement by `bin/rails` command. I try to change all that can be directly use `bin/rails …`

It's reasonable to expose different value readers.

We can provide a more flexible upgrade experience by warning users they are using unsafe methods instead of forcing the safe API by deprecating before removal. This PR provides this functionality.

Guides header changes

- Add new logo for guides header
[ci skip]

Fix test failure on PostgreSQL by sorting the result before comparison

Closes #21986.

This makes it possible to write custom types that define a different
mapping for STI columns.

Mention that halting chain does not re-raise  `ActiveRecord::RecordIn…

Make text about render :html option clearer to state, text will get e…

Mention that halting chain does not re-raise  `ActiveRecord::RecordInvalid` exception as well, similar to `ActiveRecord::Rollback`

Fixes #22297

[ci skip]

Make text about render :html option clearer to state, text will get escaped if not marked as safe by using html_safe

Fixes #22648
[ci skip]

refer to rails command instead of rake in environment error

It has been to use an overall rails command in ea4f0e2b, in order to unify.

Fix discrepancies in associations guide [ci skip]

- Followup of https://github.com/rails/rails/commit/71ff088a09d429657877ddfb58985d30df63fc8a

`ApplicationRecord` instead of  `ActiveRecord::Base` in Association G…

- adapter -> pubsub (re)rename internally
- Change variable names to match method names
- Add EventMachine `~> 1.0` as a runtime dependency of ActionCable
- Refactor dependency loading for adapters