1. 04 1月, 2020 9 次提交
  2. 03 1月, 2020 10 次提交
  3. 02 1月, 2020 8 次提交
  4. 01 1月, 2020 1 次提交
  5. 31 12月, 2019 8 次提交
    • C
      3c28e79b
    • C
      745265ab
    • C
    • K
      Merge pull request #38126 from yahonda/diag_38094 · 4dfe7c71
      Kasper Timm Hansen 提交于
      Address StarStarMimeControllerTest#test_javascript_with_no_format_only_star_star failure
      4dfe7c71
    • K
      Merge pull request #35256 from sponomarev/feature/cable-postgres-identity · bb5ac162
      Kasper Timm Hansen 提交于
      Add ActionCable subscription connection identifier to PostgreSQL adapter
      bb5ac162
    • C
      Fix markup and improve Action Text guide a bit [ci skip] · 95eb9cfd
      Carlos Antonio da Silva 提交于
      * The last html block wasn't formatting properly, it needed a blank line
        between the paragraph and the text.
      * The ordered list wasn't generating the sequence, but always showing 1.,
        the inner content/examples needed to be indented for that to work.
      * Mark some pieces as inline code for highlighting.
      * Tweak a couple sentences.
      95eb9cfd
    • S
      Add ActionCable subscription connection identificator to PostgreSQL adapter · 72337514
      Sergey Ponomarev 提交于
        * You can distinguish connection among others with specific `application_name`
      
          ```sql
          SELECT application_name FROM pg_stat_activity;
          /*
              application_name
          ------------------------
          psql
          ActionCable-PID-42
          (2 rows)
          */
           ```
      
        * It's possible to customize connection identification with `id` option in `cable.yml`
      
          `ActionCable-PID-#{$$}` is the default value
      
        * Related tests refactoring
      
        * `ActionCable::Server#config.cable` is no mutated anymore inside Redis subscription adapter
      72337514
    • Y
      Address StarStarMimeControllerTest#test_javascript_with_no_format_only_star_star failure · b0714b5f
      Yasuo Honda 提交于
      Fix #38094
      
      * Steps to reproduce:
      
      ```ruby
      % cd actionpack
      % MT_CPU=0 bundle exec ruby -w -Itest test/controller/mime/accept_format_test.rb -n "/^(?:MimeControllerLayoutsTest#(?:test_missing_layout_renders_properly)|StarStarMimeControllerTest#(?:test_javascript_with_no_format_only_star_star))$/" --verbose --seed 15759
      ```
      
      * Actual result without this commit:
      
      ```ruby
      % cd actionpack
      % MT_CPU=0 bundle exec ruby -w -Itest test/controller/mime/accept_format_test.rb -n "/^(?:MimeControllerLayoutsTest#(?:test_missing_layout_renders_properly)|StarStarMimeControllerTest#(?:test_javascript_with_no_format_only_star_star))$/" --verbose --seed 15759
      Run options: -n "/^(?:MimeControllerLayoutsTest#(?:test_missing_layout_renders_properly)|StarStarMimeControllerTest#(?:test_javascript_with_no_format_only_star_star))$/" --verbose --seed 15759
      
      MimeControllerLayoutsTest#test_missing_layout_renders_properly = 0.18 s = .
      StarStarMimeControllerTest#test_javascript_with_no_format_only_star_star = 0.00 s = E
      
      Error:
      StarStarMimeControllerTest#test_javascript_with_no_format_only_star_star:
      ArgumentError: Invalid formats: :iphone
          /Users/yahonda/src/github.com/yahonda/rails/actionview/lib/action_view/lookup_context.rb:287:in `formats='
          /Users/yahonda/src/github.com/yahonda/rails/actionview/lib/action_view/view_paths.rb:11:in `formats='
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/rendering.rb:29:in `process_action'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
          /Users/yahonda/src/github.com/yahonda/rails/activesupport/lib/active_support/callbacks.rb:98:in `run_callbacks'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/abstract_controller/callbacks.rb:41:in `process_action'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/rescue.rb:22:in `process_action'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
          /Users/yahonda/src/github.com/yahonda/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument'
          /Users/yahonda/src/github.com/yahonda/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
          /Users/yahonda/src/github.com/yahonda/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/instrumentation.rb:33:in `process_action'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/abstract_controller/base.rb:136:in `process'
          /Users/yahonda/src/github.com/yahonda/rails/actionview/lib/action_view/rendering.rb:39:in `process'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal.rb:190:in `dispatch'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/test_case.rb:512:in `process'
          /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/test_case.rb:390:in `get'
          test/controller/mime/accept_format_test.rb:28:in `test_javascript_with_no_format_only_star_star'
      
      rails test test/controller/mime/accept_format_test.rb:26
      
      Finished in 0.180610s, 11.0736 runs/s, 11.0736 assertions/s.
      2 runs, 2 assertions, 0 failures, 1 errors, 0 skips
      %
      ```
      
      * How to diagnose this error:
      
      At first Restore `require "action_view/base"` to `actionpack/lib/action_dispatch/middleware/debug_exceptions.rb` addresses this error,
      then isolated which lines are required then found this line is required.
      
      https://github.com/rails/rails/blob/22483b86a6c779743b30e2f23bb46accfbf96b28/actionpack/lib/action_dispatch.rb#L117
      
      ```ruby
        ActionView::Base.default_formats ||= Mime::SET.symbols
      ```
      b0714b5f
  6. 30 12月, 2019 2 次提交
  7. 29 12月, 2019 2 次提交