I'm going to change the constructor, so it's easier to do it in one
place.

nobody should be touching the routes hash without going through the
NamedRouteCollection object.

I want to change the real constructor to take a particular parameter for
matching the request method

The string we create is almost always the same, so rather than joining
all the time, lets join once, then reuse that string everywhere.

We should build the routes using the user facing API which is `Mapper`.
This frees up the library internals to change as we see fit. IOW we
shouldn't be testing internals.

The outer router object already keeps a hash of named routes, so we
should just use that.

refactor the tests with a backwards compatible method call so we can rm
add_route2 from the journey router

then we can let the mapping object derive stuff that the Route object
needs.

now that we aren't doing options manipulations, we can just pass the
mapping object down and read values from it.

now we don't need to add it to a hash and delete it from the hash later
just to pass it around

`add_route` needs the AST, so rather than shove it in a hash and delete
later, lets move parsing up the stack so we can pass down later

also change the feeler to subclass AD::Request so that it has all the
methods that Request has

Eventually I want to eliminate the FakeSet test class

I'm going to reimplement this using route objects, so it will be easier
if we just change ast access to go through a method rather than hashes

we don't need to keep adding it and deleting if from hashes.

This was a useless object.  We can just directly construct a
Path::Pattern object without a Strexp object.

the caller already has it, there is no reason to pack it in to an object
and just throw that object away.

the caller already has access to `as`, so we can stop passing it around.

the same value that is extracted from the options hash earlier is
returned, so we don't need to pass it in in the first place.  The caller
already has the data, so stop passing it around.

this way we don't have to mutate the options hash so far away from where
the user passed it in

The `anchor` parameter [is overridden](https://github.com/rails/rails/blob/b4b4a611d0eb9aa1c640c5f521c6a43bf2a65bab/actionpack/lib/action_dispatch/routing/mapper.rb#L1528) unless it
is directly passed to `match`, so setting it in a scope must be a
mistake.

this reduces the number of times we have to mutate the options hash.

This just ensures that `format` is applied to things inside the scope

Eventually we don't want to expose the "options" hash from scope, only
read values from it.  Lets start by adding a reader method.

We're going to try pulling this up further, and check `via` validity
sooner.  This way we don't have to do a bunch of processing on `options`
hashes only to find out that the route is incorrect

this way we don't have to insert / delete it from the options hash so
many times.

I think we can find the original place where `action` is added to the
options hash now.

we want to try to pull this logic up to where the user actually passed
in "controller" so that it's close to the related call.  That way when
we're down the stack, we don't need to wonder "why are we doing this?"