- 28 1月, 2019 1 次提交
-
-
由 Javan Makhmali 提交于
-
- 26 1月, 2019 1 次提交
-
-
由 Mark Edmondson 提交于
-
- 19 1月, 2019 2 次提交
- 18 1月, 2019 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 27 12月, 2018 1 次提交
-
-
由 Genadi Samokovarov 提交于
The `#csrf_meta_tags` and `#token_tag` Action View helper methods are expecting the class in which are included to explicitly define the method `#protect_against_forgery?` or else they will fail with `NoMethodError`. This is a problem if you want to use Action View outside of Rails applications. For example, in #34788 I used the `#button_to` helper inside of the error pages templates that have a custom `ActionView::Base` subclass, which did not defined `#protect_against_forgery?` and trying to call the button failed. I had to dig inside of Action View to find-out what's was going on. I think we should either set a default method implementation in the helpers or check for the method definition, but don't explicitly require the presence of `#protect_against_forgery?` in every `ActionViews::Base` subclass as the errors are hard to figure out.
-
- 20 12月, 2018 1 次提交
-
-
由 Kasper Timm Hansen 提交于
Generally followed the pattern for https://github.com/rails/rails/pull/32034 * Removes needless CI configs for 2.4 * Targets 2.5 in rubocop * Updates existing CHANGELOG entries for fewer merge conflicts * Removes Hash#slice extension as that's inlined on Ruby 2.5. * Removes the need for send on define_method in MethodCallAssertions.
-
- 06 12月, 2018 1 次提交
-
-
由 WoH 提交于
-
- 05 12月, 2018 1 次提交
-
-
由 WoH 提交于
Firefox fires click events on left-, right- and scroll-wheel (any non-primary mouse key) clicks while other browsers don't.
-
- 20 11月, 2018 1 次提交
-
-
由 Lyle Mullican 提交于
side of long lines; Fixes #34487
-
- 08 11月, 2018 1 次提交
-
-
由 Ryuta Kamizono 提交于
And remove trailing spaces.
-
- 10 10月, 2018 1 次提交
-
-
由 Eileen Uchitelle 提交于
This PR adds the allocations to the instrumentation for template and partial rendering. Before: ``` Rendering posts/new.html.erb within layouts/application Rendered posts/_form.html.erb (9.7ms) Rendered posts/new.html.erb within layouts/application (10.9ms) Completed 200 OK in 902ms (Views: 890.8ms | ActiveRecord: 0.8ms) ``` After: ``` Rendering posts/new.html.erb within layouts/application Rendered posts/_form.html.erb (Duration: 7.1ms | Allocations: 6004) Rendered posts/new.html.erb within layouts/application (Duration: 8.3ms | Allocations: 6654) Completed 200 OK in 858ms (Views: 848.4ms | ActiveRecord: 0.4ms | Allocations: 1539564) ```
-
- 02 10月, 2018 1 次提交
-
-
由 Joel Ambass 提交于
The url_for method is now extracting the path_only option in order to determine if polymorphic_path or polymorphic_url should be called. If the path_only option is not set it will be set to true unless the host option is set. This behaviour is the same as when a Hash or Params object is passed. To support this unifying the code responsible for setting this default value has been extracted into a private method
-
- 07 9月, 2018 1 次提交
-
-
由 Ryuta Kamizono 提交于
Fixing code block rendering, indentation, backticks, etc.
-
- 08 8月, 2018 2 次提交
-
-
由 Ana María Martínez Gómez 提交于
Instead of dropping it completely in case someone is relying (probably inadvertenly) on it.
-
由 Ana María Martínez Gómez 提交于
-
- 07 8月, 2018 1 次提交
-
-
由 Ana María Martínez Gómez 提交于
Avoid exposing private methods in view's helpers. Fixes https://github.com/rails/rails/issues/33546
-
- 16 7月, 2018 1 次提交
-
-
由 Georgi Georgiev 提交于
`button_to` was throwing exception when invoked with `params` hash that contains symbol and string keys. The reason for the exception was that `to_form_params` was comparing the given symbol and string keys. The issue is fixed by turning all keys to strings inside `to_form_params` before comparing them.
-
- 04 7月, 2018 1 次提交
-
-
由 Juan Broullon 提交于
-
- 10 6月, 2018 1 次提交
-
-
由 Koki Ryu 提交于
names. Lambda should be passed to use this option. Example: date_select('user_birthday', '', start_year: 1998, end_year: 2000, year_format: ->year { "Heisei #{year - 1988}" }) The HTML produced: <select id="user_birthday__1i" name="user_birthday[(1i)]"> <option value="1998">Heisei 10</option> <option value="1999">Heisei 11</option> <option value="2000">Heisei 12</option> </select> /* The rest is omitted */
-
- 20 4月, 2018 1 次提交
-
-
由 yuuji.yaginuma 提交于
As of now, `HTMLElement.nonce` seems to work only in Chrome. So, it should not be used now. https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/nonce#Browser_compatibility Fixes #32577.
-
- 18 4月, 2018 1 次提交
-
-
由 Yaroslav Markin 提交于
-
- 07 4月, 2018 2 次提交
-
-
由 bogdanvlviv 提交于
- Add missing dots at the end of sentences. - Wrap RecordTagHelper into `. - `RecordTagHelper` => `ActionView::Helpers::RecordTagHelper`. [ci skip]
-
由 Yoshiyuki Hirano 提交于
* Since #18411, we started to inform about extracted gem (record_tag_helper) to developers who use `ActionView::Helpers::RecordTagHelper` 's methods. * Currently, it seems no problem that we don't have to support no longer.
-
- 03 4月, 2018 1 次提交
-
-
由 Simon Coffey 提交于
ActionView::Template instances compile their source to methods on the ActionView::CompiledTemplates module. To prevent leaks in development mode, where templates can frequently change, a finalizer is added that undefines these methods[1] when the templates are garbage-collected. This is undesirable in the test environment, however, as templates don't change during the life of the test. Moreover, the cost of undefining a method is proportional to the number of descendants a class or module has, since the method cache must be cleared for all descendant classes. As ActionView::CompiledTemplates is mixed into every ActionView::TestCase (or in RSpec suites, every view spec example group), it can end up with a very large number of descendants, and undefining its methods can become very expensive. In large test suites, this results in a long delay at the end of the test suite as all template finalizers are run, only for the process to then exit. To avoid this unnecessary cost, this change adds a config option, `action_view.finalize_compiled_template_methods`, defaulting to true, and sets it to false in the test environment only. [1] https://github.com/rails/rails/blob/09b2348f7fc8d4e7191e70e06608c5909067e2aa/actionview/lib/action_view/template.rb#L118-L126
-
- 01 4月, 2018 1 次提交
-
-
由 Mathieu 提交于
-
- 14 3月, 2018 1 次提交
-
-
由 Rafael Mendonça França 提交于
We only add the header when releasing to avoid some conflicts. [ci skip]
-
- 12 3月, 2018 1 次提交
-
-
由 bogdanvlviv 提交于
- Add missing dots. - Remove reference to itself on GitHub. Usually, we add references to fixed issues only in a changelog. Follow up #32223
-
- 28 2月, 2018 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Serj Prikhodko 提交于
-
- 27 2月, 2018 2 次提交
-
-
由 Andrew White 提交于
With the disabling of TLS 1.0 by most major websites, continuing to run IE8 or lower becomes increasingly difficult so default to not enforcing UTF-8 encoding as it's not relevant to other browsers.
-
由 Rui Onodera 提交于
Currently submit_tag value translation does not support i18n key style locale key. It confuses me a bit because many other components support i18n key style locale key. I added i18n key style locale key support to submit tag.
-
- 18 2月, 2018 1 次提交
-
-
由 Jeremy Daer 提交于
Skipping over 2.4.0 to sidestep the `"symbol_from_string".to_sym.dup` bug. References #32028
-
- 31 1月, 2018 1 次提交
-
-
由 Rafael Mendonça França 提交于
:tada::tada::tada:
-
- 28 12月, 2017 1 次提交
-
-
由 Jérémie Bonal 提交于
Replaced the uses of `group.send(...)` in `option_groups_from_collection_for_select` by calls to `value_for_collection(group, ...)`, allowing the use of procs, lambdas and other callable objects as parameters.
-
- 01 12月, 2017 1 次提交
-
-
由 Ryuta Kamizono 提交于
-
- 29 11月, 2017 2 次提交
-
-
由 Guillermo Iguaran 提交于
This helper creates a link tag with preload keyword that allows to browser to initiate early fetch of resources. Additionally this send Early Hints if supported. See https://github.com/rails/rails/pull/30744/commits/59a02fb7bcbe68f26e1e7fdcec45c00c66e4a065 for more details about Early Hints. Preload spec: https://w3c.github.io/preload/
-
由 Rafael Mendonça França 提交于
-
- 28 11月, 2017 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 26 11月, 2017 1 次提交
-
-
由 npezza93 提交于
When `form_with` was introduced we disabled the automatic generation of ids that was enabled in `form_for`. This usually is not an good idea since labels don't work when the input doesn't have an id and it made harder to test with Capybara. You can still disable the automatic generation of ids setting `config.action_view.form_with_generates_ids` to `false.`
-