- 12 9月, 2015 1 次提交
-
-
由 Ronak Jangir 提交于
`restrict_with_error` message will now respect owner’s human name in any locale [kuboon & Ronak Jangir]
-
- 09 9月, 2015 39 次提交
-
-
由 Eileen M. Uchitelle 提交于
Improve the AR querying docs
-
由 Tim Wade 提交于
Bumps to 5.7
-
由 Tim Wade 提交于
* rewords a few awkwardly worded sentences * adds some punctuation * adds a few missing words
-
由 eileencodes 提交于
`Rack::Session::Abstract::ID` is now deprecated and `Rack::Session::Abstract::Persisted` should be used instead.
-
由 eileencodes 提交于
In c546a2b0 this was changed to mimic how the browser behaves in a real situation but left out types that were registered. When this was changed it didn't take `text/plain` or `text/html` content types into account. This is a problem if you're manipulating the `Content-Type` headers in your controller tests, and expect a certain result. The reason I changed this to use `to_sym` is because if the `Content-Type` is not registered then the symbol will not exist. If it's one of the special types we handle that specifically (:json, :xml, or :url_encoded_form). If it's any registered type we handle it by setting the `path_parameters` and then the `request_parameters`. If the `to_sym` returns nil an error will be thrown. If the controller test sets a `Content-Type` on the request that `Content-Type` should remain in the header and pass along the filename. For example: If a test sets a content type on a post ``` @request.headers['CONTENT_TYPE'] = 'text/plain' post :create, params: { name: 'foo.txt' } ``` Then `foo.txt` should be in the `request_parameters` and params related to the path should be in the `path_parameters` and the `Content-Type` header should match the one set in the `@request`. When c546a2b0 was committed `text/plain` and `text/html` types were throwing a "Unknown Content-Type" error which is misleading and incorrect. Note: this does not affect how this is handled in the browser, just how the controller tests handle setting `Content-Type`.
-
由 Eileen M. Uchitelle 提交于
HasManyAssociation: moved half of counter cache code to reflection
-
由 Yves Senn 提交于
Use `ActiveRecord::Tasks::DatabaseTasks.migrations_paths` explicit for db tasks
-
由 Yves Senn 提交于
This method is private API and never used. Let's remove it.
-
由 Yves Senn 提交于
`Schema#migrations_paths` is not supposed to be public API. In fact it's only used inside `Schema` itself, so let's make it private.
-
由 Rafael Mendonça França 提交于
It is always passed in
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Usage was removed in 5c449553
-
由 Rafael Mendonça França 提交于
This reverts commit d5ba9a42, reversing changes made to 30c50339. Reason: This generate the dynalic finders more than one time
-
由 Rafael Mendonça França 提交于
put dynamic matchers on GeneratedAssociationMethods instead of model
-
由 Rafael Mendonça França 提交于
Added nodoc tag for the methods which returns object of private apis
-
由 Rafael Mendonça França 提交于
Fix and Improve sql logging coloration in `ActiveRecord::LogSubscriber`.
-
由 Ronak Jangir 提交于
-
由 Rafael Mendonça França 提交于
Rails documentation use american english.[ci skip]
-
由 ravindra kumar kumawat 提交于
-
由 Claudio B. 提交于
Fix docs of AR::Timestamp to match #15726
-
由 claudiob 提交于
[ci skip] @sgrif can you review when you have time? Thanks!
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
This method is specifically about the content type so lets remove the parameter.
-
由 Aaron Patterson 提交于
create a singleton content type that just has nils, so that we don't have to allocate a content type object all the time.
-
由 Aaron Patterson 提交于
If someone sets just a charset, but depends on the implicit type from rendering, this will store a strange content type header that looks like this: `; charset=blah`. This is so that when the content type header is parsed again, it will return nil for the actual type.
-
由 Aaron Patterson 提交于
It turns out that the response object never really cares what the mime type object is, so just use the string.
-
由 Aaron Patterson 提交于
pull content-type setting to a private method to dry it up.
-
由 Aaron Patterson 提交于
Instead of storing content type information in an ivar and a header, lets move to just store the content type info in just the header.
-
由 Aaron Patterson 提交于
we'll use this method later to lazily parse content type headers.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
everything above metal really doesn't care about setting the content type, so lets rearrange these methods to be in metal.
-
由 Aaron Patterson 提交于
_set_content_type only does something when there is a request object, otherwise the return value of _get_content_type is always ignored. This commit moves everything to the module that has access to the request object so we'll never to_s unless there is a reason
-
由 Aaron Patterson 提交于
in the future I would like to make the header hash read only (or at least remove guarantees that mutations will do anything).
-
由 Kasper Timm Hansen 提交于
Properly log nested parameters to Active Job
-
由 Marek Pieczyk 提交于
Refactor arguments logging method for Active Job
-
由 Rafael Mendonça França 提交于
Fix typo in activemodel changelog [ci skip]
-
由 Semyon Pupkov 提交于
-