- 27 9月, 2018 8 次提交
-
-
由 Patrik Bóna 提交于
Fixes #29473.
-
由 Vladimir Dementyev 提交于
ActionCable::Channel::TestCase provides an ability to unit-test channel classes. There are several reasons to write unit/functional cable tests: - Access control (who has access to the channel? who can perform action and with which argument? - Frontend-less applications have no system tests at all–and we still need a way to test channels logic. See also #27191
-
由 Aaron Patterson 提交于
Eagerly build the routing helper module after routes are committed
-
由 Aaron Patterson 提交于
* master: Remove force parent loading when counter cache child is created/destroyed Raise an error when loading all fixtures from nil fixture_path Revert "Remove `counter_cache_target` which is no longer called" Update counter cache in memory if parent target is existed If association is a hash-like object preloading fails Use the same option for create database statements between Raketask and travis.rb Fix "warning: shadowing outer local variable - config" Remove `counter_cache_target` which is no longer called Fix more offences Change the empty block style to have space inside of the block Fix a content_for test description Stringify database configurations Improve error message when assign wrong attributes to model
-
由 Aaron Patterson 提交于
-
由 Rafael França 提交于
Improve error message when assign wrong attributes to model
-
由 Aaron Patterson 提交于
Also we want to eager load routes before anything else.
-
由 Rafael França 提交于
Raise an error when loading all fixtures from nil fixture_path
-
- 26 9月, 2018 18 次提交
-
-
由 Eileen M. Uchitelle 提交于
If association is a hash-like object preloading fails
-
由 Ryuta Kamizono 提交于
`association.increment_counters` and `association.decrement_counters` works regardless of parent target is loaded or not. Related 52e11e46.
-
由 Gannon McGibbon 提交于
[Gannon McGibbon + Max Albrecht]
-
由 Ryuta Kamizono 提交于
This reverts commit 376ffe0e. Since 38fae1f2, `association.increment_counters` is called without inflated parent target if inverse_of is disabled. In that case, that commit would cause extra queries to inflate parent.
-
由 Ryuta Kamizono 提交于
Fixes #19550.
-
由 Bohdan Pohorilets 提交于
If you pass a hash-like object to preload associations (for example ActionController::Parameters) preloader will fail with the ArgumentError. This change allows passing objects that may be converted to a Hash or String into a preloader
-
由 Ryuta Kamizono 提交于
Use the same option for create database statements
-
由 Yasuo Honda 提交于
-
由 yuuji.yaginuma 提交于
-
由 Rafael França 提交于
Stringify database configurations
-
由 Aaron Patterson 提交于
ActiveStorage::BaseController subclasses ActionController::Base. ActionController::Base has an "inherited" hook set that includes the routing helpers to any subclass of AC::Base. Since ActiveStorage::BaseController is a subclass of AC::Base, it will get routing helpers included automatically. Unfortunately, when the framework is eagerly loaded, ActiveStorage::BaseController is loaded *before* the applications routes are loaded which means it attempts to include an "in flight" module so it gets an exception. This commit allows a class that's interested in being extended with routing helpers register itself such that when the routes are finalized, it will get the helpers included. If the routes are already finalized, then the helpers get included immediately.
-
由 Rafael França 提交于
[CaptureHelperTest] Fix a content_for test description
-
由 Ryuta Kamizono 提交于
`counter_cache_target` is called only when updated counter cache in replacing target, but it was already removed at #33913.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Aaron Patterson 提交于
This commit eagerly builds the route helper module after the routes have been drawn and finalized. This allows us to cache the helper module but not have to worry about people accessing the module while route definition is "in-flight", and automatically deals with cache invalidation as the module is regenerated anytime someone redraws the routes. The restriction this commit introduces is that the url helper module can only be accessed *after* the routes are done being drawn. Refs #24554 and #32892
-
由 Aaron Patterson 提交于
This patch removes deprecated catch-all routes from AM
-
由 Aaron Patterson 提交于
Remove deprecated catch-all route in the AV tests
-
- 25 9月, 2018 11 次提交
-
-
由 Ryuta Kamizono 提交于
Abandon TOP support.
-
由 Vladimir Kochnev 提交于
Initially, `TOP` was introduced to support `limit` for MSSQL database. Unlike PostgreSQL/MySQL/SQLite, MSSQL does not have native `LIMIT`/`OFFSET` support. The commit adding `TOP` is 1a246f71. However, it figured out that `TOP` implementation was weak and it's not sufficient to also support `OFFSET`, then `TOP` was substituted with `ROW_NUMBER()` subquery in be48ed30. This is a well known trick in MSSQL - https://stackoverflow.com/questions/2135418/equivalent-of-limit-and-offset-for-sql-server. So now we don't need this `visit_Arel_Nodes_Top` at all. It does nothing useful but also adds an extra space after `SELECT` when `LIMIT` is being used for **any** database.
-
由 Juanito Fatas 提交于
-
由 Rafael França 提交于
Fix rails guides markdown.rb and renderer.rb to use custom header id
-
由 Rafael França 提交于
Improve phrasing of one sentence in the contributing guide
-
由 Aaron Patterson 提交于
It also removes a monkey patch from AM::Base
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
We should be able to remove this once the catch-all route is gone from AP
-
由 Aaron Patterson 提交于
This commit removes a deprecated catch-all route in the AV tests. It defines and includes the necessary routes for each test such that we don't need the catch-all anymore. This also helps push us toward #33970
-
由 Gannon McGibbon 提交于
-
由 Ryuta Kamizono 提交于
Eagerly define attribute methods in production
-
- 24 9月, 2018 3 次提交
-
-
由 Pascal Lamouric 提交于
-
由 Ryuta Kamizono 提交于
update mini_magick to the latest version
-
由 utilum 提交于
v 4.9.2 avoids some warnings that show in our tests. Although Gemfile.lock currently specifies 4.8.0, the CI already runs 4.9.2 so 4.8.0 warnings do not show in our CI logs.
-