- 19 9月, 2015 6 次提交
-
-
由 Aaron Patterson 提交于
This is an instance method on the request object now so we don't need it anymore
-
由 Aaron Patterson 提交于
The middleware stack is a singleton in the application (one instance is shared for the entire application) which means that there was only one opportunity to set the parameter parsers. Since there is only one set of parameter parsers in an app, lets just configure them on the request class (since that is where they are used).
-
由 Aaron Patterson 提交于
we need to be more specific about exception handling when dealing with the parse strategies. The calls to `return yield` can also raise an exception, but we don't want to handle that in *this* code.
-
由 Aaron Patterson 提交于
`normalize_encode_params` is common to all parser code paths, so we can pull that up and always apply it before assigning the request parameters
-
由 Aaron Patterson 提交于
since there is only one "default" strategy now, we can just use the block parameter for that.
-
由 Aaron Patterson 提交于
All parameter parsing should be on the request object because the request object is the object that we ask for parameters.
-
- 15 9月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
this commit removes some direct access to `env`.
-
- 05 9月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
Just include the modules necessary in the Request object to implement the things we need. This should make it easier to build delegate request objects because the API is smaller
-
- 03 9月, 2015 1 次提交
-
-
由 Anshul Sharma 提交于
-
- 30 8月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 27 8月, 2015 1 次提交
-
-
由 Marcin Olichwirowicz 提交于
Cleanup for `ActionDispatch::Http::Parameters` - no need for required libraries and remove not used private method. Apparently this method was used in `ActionDispatch::Http::Request` - fixed by calling `Request::Utils` explicitly (as was done in other parts of the codebase)
-
- 26 8月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
now the caller can just treat it like a regular controller even though it will return a 404
-
- 25 8月, 2015 3 次提交
-
-
由 Anshul Sharma 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
I want to implement this with something besides `@env` in the future, so lets stop directly referencing it.
-
- 23 8月, 2015 6 次提交
-
-
由 Aaron Patterson 提交于
This commit allows us to use one request object rather than allocating multiple request objects to deal with the session.
-
由 Aaron Patterson 提交于
We're going to implement storing env values differently in the future, so let's disconnect these methods from the instance variables
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
we're already doing this with a bunch of other header data.
-
由 Aaron Patterson 提交于
we have a method that knows how to get rack.input, so lets use that.
-
由 Aaron Patterson 提交于
We need to abstract the internals of the request object away from this instance variable so that the values for `@env` can be calculated in a different way.
-
- 22 8月, 2015 2 次提交
-
-
由 eileencodes 提交于
This refactoring moves the controller class name that was on the route set to the request. The purpose of this refactoring is for changes we need to move controller tests to integration tests, mainly being able to access the controller on the request instead of having to go through the router. [Eileen M. Uchitelle & Aaron Patterson]
-
由 Aaron Patterson 提交于
-
- 08 8月, 2015 2 次提交
-
-
由 Aaron Patterson 提交于
people should be accessing request information through the request object, not via the env hash. If they really really want at the env hash, then they can get it off the request.
-
由 Aaron Patterson 提交于
Actions are processed through `dispatch`, so they should have the request set on them before any user land code can be executed. Lets stop setting _env on the controller, and give access to it through the `env` method.
-
- 07 8月, 2015 6 次提交
-
-
由 Aaron Patterson 提交于
this is another place that we should stop directly accessing the env hash and let the request object take care of that for us
-
由 Gabriel Sobrinho 提交于
-
由 Aaron Patterson 提交于
again, we want to hide the contents of `env` from the implementation. Allocate a request object to access the contents of env, but save allocations due to string literal allocations when accessing the env hash.
-
由 Aaron Patterson 提交于
hide the env key in the request object so that other code doesn't need to know.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 06 8月, 2015 2 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
This decouples the `call` method from knowing the SCRIPT_NAME key and offloads decisions about how to access script_name
-
- 22 7月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
Now that we have encoding strategies, we can just walk the params hash once to encode as HWIA, and remove nils.
-
- 07 6月, 2015 1 次提交
-
-
由 Robin Dupret 提交于
[Robin Dupret & Shunsuke Aida]
-
- 29 5月, 2015 1 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
These methods had defined in 2004 by dhh in initial commit and `ActionDispatch::Request` class has been inherited from `Rack::Request` class in 2009 by josh. In 2014 these methods and more of them defined in `Rack::Request` class so we don't need them anymore in rails codebase.
-
- 27 5月, 2015 2 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
-
由 Mehmet Emin İNAÇ 提交于
add missing dot to end of the doc
-
- 26 5月, 2015 1 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
-
- 24 5月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
I should have deleted this earlier with 42e66fac
-