- 29 2月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
Some tests does not work for unprepared statements. Add `if ActiveRecord::Base.connection.prepared_statements` and fix a regex for fix tests failure with `prepared_statements: false`.
-
- 01 2月, 2016 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Akira Matsuda 提交于
-
- 14 1月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
Arel handles substitution for bind parameters by now.
-
- 17 12月, 2015 1 次提交
-
-
由 Sean Griffin 提交于
When this test was run on Windows, the database file would still be in use, and `File.unlink` would fail. This would cause the temp directory to be unable to be removed, and error out. By disconnecting the connection when finished, we can avoid this error.
-
- 09 11月, 2015 1 次提交
-
-
由 yui-knk 提交于
Reported on #21509, how views is treated by `#tables` are differ by each adapters. To fix this different behavior, after Rails 5.0 is released, deprecate `#tables`. And `#table_exists?` would check both tables and views. To make their behavior consistent with `#tables`, after Rails 5.0 is released, deprecate `#table_exists?`.
-
- 22 10月, 2015 1 次提交
-
-
由 Ryuta Kamizono 提交于
This issue was resolved by #21687 already. But re-add args by #18856. `#tables` extra args was only using by `#table_exists?`. This is for internal API. This commit will remove these extra args again.
-
- 20 9月, 2015 1 次提交
-
-
由 Ryuta Kamizono 提交于
`@connection` in `StatementPool` is only used for PG adapter. No need for abstract `StatementPool` class.
-
- 26 8月, 2015 1 次提交
-
-
由 Ronak Jangir 提交于
-
- 11 6月, 2015 1 次提交
-
-
由 Yves Senn 提交于
-
- 28 5月, 2015 1 次提交
-
-
由 Akshay Vishnoi 提交于
-
- 17 3月, 2015 1 次提交
-
-
由 Brandon Weiss 提交于
I’m renaming all instances of `use_transcational_fixtures` to `use_transactional_tests` and “transactional fixtures” to “transactional tests”. I’m deprecating `use_transactional_fixtures=`. So anyone who is explicitly setting this will get a warning telling them to use `use_transactional_tests=` instead. I’m maintaining backwards compatibility—both forms will work. `use_transactional_tests` will check to see if `use_transactional_fixtures` is set and use that, otherwise it will use itself. But because `use_transactional_tests` is a class attribute (created with `class_attribute`) this requires a little bit of hoop jumping. The writer method that `class_attribute` generates defines a new reader method that return the value being set. Which means we can’t set the default of `true` using `use_transactional_tests=` as was done previously because that won’t take into account anyone using `use_transactional_fixtures`. Instead I defined the reader method manually and it checks `use_transactional_fixtures`. If it was set then it should be used, otherwise it should return the default, which is `true`. If someone uses `use_transactional_tests=` then it will overwrite the backwards-compatible method with whatever they set.
-
- 18 2月, 2015 3 次提交
-
-
由 Ryuta Kamizono 提交于
Lowercase raw SQL has been replaced by 07b659ca already. This commit replaces everything else of raw SQL.
-
由 Yves Senn 提交于
/cc @yahonda This makes it easier for third party adapters to run our tests, even if that database does not support IF EXISTS.
-
由 Sean Griffin 提交于
-
- 03 2月, 2015 1 次提交
-
-
由 Vipul A M 提交于
-
- 29 1月, 2015 1 次提交
-
-
由 Sean Griffin 提交于
All columns which would map to a string primitive need this behavior. Binary has it's own marker type, so it won't go through this conversion. String and text, which need this, will. Fixes #18585.
-
- 28 1月, 2015 1 次提交
-
-
由 Sean Griffin 提交于
`bound_attributes` is now used universally across the board, removing the need for the conversion layer. These changes are mostly mechanical, with the exception of the log subscriber. Additional, we had to implement `hash` on the attribute objects, so they could be used as a key for query caching.
-
- 11 1月, 2015 1 次提交
-
-
由 Sean Griffin 提交于
I'm planning on deprecating the column argument to mirror the deprecation in [arel]. [arel]: https://github.com/rails/arel/commit/6160bfbda1d1781c3b08a33ec4955f170e95be11
-
- 02 1月, 2015 2 次提交
-
-
由 Sean Griffin 提交于
So we can change the arity later.
-
由 Sean Griffin 提交于
The string encoding test wasn't using the types for anything. The boolean casting test included logic that should be in the tests for the types, and the string test was legitimately not testing anything useful.
-
- 31 12月, 2014 1 次提交
-
-
由 Arthur Neves 提交于
When table has a composite primary key, the `primary_key` method for sqlite3 and postgresql was only returning the first field of the key. Ensures that it will return nil instead, as AR dont support composite pks.
-
- 27 12月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
This will allow eager type casting to take place as needed. There doesn't seem to be any particular reason that the `in` statement was forced for single values, and the commit message where it was introduced gives no context. See https://github.com/rails/rails/commit/d90b4e2615e8048fdeffc6dffe3246704adee01f
-
- 29 11月, 2014 1 次提交
-
-
由 Erik Michaels-Ober 提交于
-
- 18 11月, 2014 2 次提交
-
-
由 Sean Griffin 提交于
Oh hey, we got to remove some code because of that!
-
由 Sean Griffin 提交于
Arel handles this for us automatically. Updated tests, as BindParam is no longer a subclass of SqlLiteral. We should remove the second argument to substitute_at entirely, as it's no longer used
-
- 14 11月, 2014 1 次提交
-
-
由 Arun Agrawal 提交于
`Computer` class needs to be require See #17217 for more details
-
- 11 7月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
-
- 07 7月, 2014 1 次提交
-
-
由 Zachary Scott 提交于
adapter, fixed from #16057 [ci skip]
-
- 06 7月, 2014 1 次提交
-
-
由 Akshay Vishnoi 提交于
-
- 29 6月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
The only case where we got a column that was not `nil`, but did not respond to `cast_type` was when type casting the default value during schema creation. We can look up the cast type, and add that object to the column definition. Will allow us to consistently rely on the type objects for type casting in all directions.
-
- 18 6月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
If we want to have type decorators mess with the attribute, but not the column, we need to stop type casting on the column. Where possible, we changed the tests to test the value of `column_defaults`, which is public API. `Column#default` is not.
-
- 28 5月, 2014 1 次提交
-
-
由 Akshay Vishnoi 提交于
-
- 27 5月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
The intention is to eventually remove `column` from the arguments list both for `quote` and for `type_cast` entirely. This is the first step to that end.
-
- 24 5月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
It appears to have been used at some point in the past, but is no longer used in any meaningful way. Whether a column is considered primary is a property of the model, not the schema/column. This also removes the need for yet another layer of caching of the model's schema, and we can leave that to the schema cache.
-
- 19 5月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
The decision to wrap type registrations in a proc was made for two reasons. 1. Some cases need to make an additional decision based on the type (e.g. a `Decimal` with a 0 scale) 2. Aliased types are automatically updated if they type they point to is updated later. If a user or another adapter decides to change the object used for `decimal` columns, `numeric`, and `number` will automatically point to the new type, without having to track what types are aliased explicitly. Everything else here should be pretty straightforward. PostgreSQL ranges had to change slightly, since the `simplified_type` method is gone.
-
- 18 5月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
Part of #15134. In order to perform typecasting polymorphically, we need to add another argument to the constructor. The order was chosen to match the `oid_type` on `PostgreSQLColumn`.
-
- 03 5月, 2014 1 次提交
-
-
由 Akshay Vishnoi 提交于
-
- 10 4月, 2014 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 02 4月, 2014 1 次提交
-
-
由 Matthew Draper 提交于
Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll change to the absolute-path interpretation in 4.2. The current "correct" spellings for in-memory, relative, and absolute URLs, respectively, are: sqlite3::memory: sqlite3:relative/path sqlite3:/full/path Substantially reverses/defers fbb79b51. Uncovered by @guilleiguaran while investigating #14495, though that sounds like a different issue.
-