- 10 8月, 2015 8 次提交
-
-
由 Rafael Mendonça França 提交于
This method raises conditionally not always so we should not documment as it always raise.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
We should return when the contoller key is not present or if the controller doesn't exist and we didn't raised an error.
-
由 Rafael Mendonça França 提交于
Related with dc1b937d
-
由 Rafael Mendonça França 提交于
-
由 Aaron Patterson 提交于
eliminates calling `scope` in one method, pushes the other calls up one frame. This goes a little way towards eliminating the internal calls to `scope`.
-
由 Claudio B. 提交于
[ci skip] Note that each action maps to a specific CRUD operation
-
由 Brooks Reese 提交于
-
- 09 8月, 2015 18 次提交
-
-
由 Aaron Patterson 提交于
we don't really need this hash.
-
由 Aaron Patterson 提交于
we need to get a grip on what `scope` actually does. This commit removes some of the internal calls to `scope`. Eventually we should add public facing methods that provide the API that `scope` is trying to accomplish.
-
由 Aaron Patterson 提交于
`prepare_params!` would raise an exception if `params` wasn't initialized, so it must always be available. Remove the existence conditional from the `controller` method.
-
由 Aaron Patterson 提交于
The method we called already has the conditional we need. Just add an else block so that we don't need two tests.
-
由 Aaron Patterson 提交于
`Dispatcher` doesn't need to hold on to the defaults hash. It only used the hash to determine whether or not it should raise an exception if there is a name error. We can pass that in further up the stack and alleviate Dispatcher from knowing about that hash.
-
由 Aaron Patterson 提交于
We know in advance whether the object is a dispatcher or not, so we can configure the Constraints object with a strategy that will call the right method.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
it isn't used.
-
由 Richard Schneeman 提交于
Reference actual classes
-
由 Claudio B. 提交于
[ci skip] Fix the AS::Callbacks terminator docs
-
由 Claudio B. 提交于
[ci skip] Give in-depth explanation of migrations vs. seeds.rb
-
由 Miles Starkenburg 提交于
-
由 Brooks Reese 提交于
-
由 Rafael Mendonça França 提交于
[ci skip] Adding a note to Action Mailer Basics documentation that Google increased its security measures
-
由 melissawahnish 提交于
security measures so using the example for Gmail will return a “Password Incorrect” error, and you will receive an email from Google that they blocked a sign-in attempt. You can change your Gmail settings or use another ESP. I discovered this when I was testing a simple mailer example app and was just going to use my personal Gmail account for the test. I think it would be best to note this change since now Gmail may not be the best option for a quick test. I hope this saves time for other Rails developers. The Gmail example does show a good example of how to configure the smpt settings.
-
由 Roque Pinel 提交于
The second argument of the terminator lambda is no longer the result of the callback, but the result lambda. https://github.com/rails/rails/blob/3a7609e2bafee4b071fe35136274e6ccbae8cacd/activesupport/test/callbacks_test.rb#L553
-
由 Kasper Timm Hansen 提交于
replace each with each_key when only the key is needed
-
由 Aaron Lasseigne 提交于
Using each_key is faster and more intention revealing. Calculating ------------------------------------- each 31.378k i/100ms each_key 33.790k i/100ms ------------------------------------------------- each 450.225k (± 7.0%) i/s - 2.259M each_key 494.459k (± 6.3%) i/s - 2.467M Comparison: each_key: 494459.4 i/s each: 450225.1 i/s - 1.10x slower
-
- 08 8月, 2015 14 次提交
-
-
由 eileencodes 提交于
The tests and methods were hard to read with `options[:options]` all over the place. This refactoring makes the code easier to understand. The change came out of work for moving the underlying code of controller tests to integraiton tests.
-
由 Rafael Mendonça França 提交于
Allow a custom dispatcher to be provided to routing.
-
由 eileencodes 提交于
Using the string version of the class reference is now deprecated when referencing middleware. This should be written as a class not as a string. Deprecation warning that this change fixes: ``` DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change them to actual class references. For example: "ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions ```
-
由 eileencodes 提交于
`extra_keys` is a confusing variable name because it's not clear what is "extra". This renames it to `query_string_keys` so it's clear that the "extra" is just the query string.
-
由 eileencodes 提交于
We were doing extra work that could be pushed off to Integration test and SharedRoutes. Creating an extra module isn't necessary when those are created by their respective classes.
-
由 Abdelkader Boudih 提交于
use uuid method to define the UUID type [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Richard Schneeman 提交于
[ci skip] Add an explanation for `status` option
-
由 yui-knk 提交于
-
由 Xavier Shay 提交于
-
由 Xavier Shay 提交于
scope so that they are available to subclasses.
-
由 Aaron Patterson 提交于
people should be accessing request information through the request object, not via the env hash. If they really really want at the env hash, then they can get it off the request.
-
由 Aaron Patterson 提交于
remove the setter. The request object manages the env hash, so any mutations need to go through it
-
由 Aaron Patterson 提交于
Looks like this was left over from converting Rails to Rack. I think it's safe to remove now.
-