- 02 8月, 2014 4 次提交
-
-
由 Aaron Patterson 提交于
this allows us to avoid nil checks on the return value
-
由 Rafael Mendonça França 提交于
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
- 01 8月, 2014 23 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
Ruby generally does not use the is_* prefix on predicate methods.
-
由 Aaron Patterson 提交于
-
由 Rafael Mendonça França 提交于
Null transaction
-
由 Arthur Neves 提交于
-
由 Arthur Neves 提交于
-
由 Rafael Mendonça França 提交于
Transactions refactoring - 2
-
由 Arthur Neves 提交于
-
由 Arthur Neves 提交于
-
由 Arthur Neves 提交于
-
由 Aaron Patterson 提交于
there's no reason to to_sym the string if it doesn't match the regexp anyway
-
由 Aaron Patterson 提交于
hash lookup should be faster than searching an array.
-
由 Rafael Mendonça França 提交于
Add ActiveRecord::Tasks::DatabaseTasks.migrate
-
由 Rafael Mendonça França 提交于
[doc] Clarify how the ConnectionHandler works
-
由 Jack Danger Canty 提交于
This makes the implicit description of how connection pooling works a little more explicit. It converts the examples of a model hierarchy into actual Ruby code and demonstrates how the key structure of the database.yml relates to the `establish_connection` method.
-
由 Jack Danger Canty 提交于
This extracts the logic that was embedded in a Rake task into a static method. Bonus: the first test for `rake db:migrate`
-
由 Rafael Mendonça França 提交于
Refactor join_keys to remove complex conditionals
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
These methods mutate the path variable/argument so there is no need to reassign it every time.
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
- 31 7月, 2014 13 次提交
-
-
由 eileencodes 提交于
Pushing conditionals down to through reflection Only the through association needs the part of this conditional that deals with belongs to and polymorphic? so that can be pushed down into the ThroughReflection reducing the conditionals. Remove conditional because we can delegate join keys to source reflection Remove need for source_macro checking By adding join_id_for to the other reflections we remove the need to cehck against the source_macro and can reduce the conditioanl from the original join_id_for(owner) Using polymorphism instead of testing the source_macro This case statement in join_association is almost exactly the same as the original join_keys code. Testing taht theory by creating a new join_dependency_keys(assoc_klass) method. Refactor join_keys further to be more concise Fixed format of "#:nodoc:" to "# :nodoc:" where I added them to this file.
-
由 Rafael Mendonça França 提交于
Merge pull request #16351 from eileencodes/finish-refactoring-macro-to-eliminate-checking-against-symbols Redefine macro checks for reflections
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
This is not storying the RouteSet instance anywhere as the other examples in the file, so no need to use #tap.
-
由 Yves Senn 提交于
Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block
-
由 Gordon Chan 提交于
Add tests to ensure default proc is used when `HashWithIndifferentAccess' is initialized with a block
-
由 Aaron Patterson 提交于
Raise a descriptive error if non-positive integer passed to in_groups_of
-
由 Xavier Shay 提交于
This is more consistent than the current behaviour of raising a `ZeroDivisionError: divided by 0` error when 0 is given, which can be non-obvious especially if `in_groups_of` is part of a longer chain of methods. The negative case was ok - "ArgumentError: invalid slice size" - but this error is clearer still.
-
由 Carlos Antonio da Silva 提交于
The message passed to Minitest's assert_raise is used as output in case the assertion fails, but we can test against the exact message by using the actual exception object that is returned from the assert_raise call.
-
由 Carlos Antonio da Silva 提交于
-