- 13 3月, 2019 14 次提交
-
-
由 Chris Salzberg 提交于
Currently GeneratedAttributeMethods is a module builder class, an instance of which is included in every AR class. OTOH, GeneratedAssociatedMethods is assigned to a constant under the model namespace. This is inconsistent and looks strange in the list of ancestors. There is no particular reason *not* to assign a constant for this (very important) module under the model namespace, so that's what this commit does. Previous to this change, ancestors for an AR class looked like this: ``` => [User (call 'User.connection' to establish a connection), User::GeneratedAssociationMethods, #<ActiveRecord::AttributeMethods::GeneratedAttributeMethods:0x000055ace0f05b08>, ApplicationRecord(abstract), ApplicationRecord::GeneratedAssociationMethods, #<ActiveRecord::AttributeMethods::GeneratedAttributeMethods:0x000055ace093c460>, ActiveRecord::Base, ... ``` With this change, they look like this: ``` => [User (call 'User.connection' to establish a connection), User::GeneratedAssociationMethods, User::GeneratedAttributeMethods, ApplicationRecord(abstract), ApplicationRecord::GeneratedAssociationMethods, ApplicationRecord::GeneratedAttributeMethods, ActiveRecord::Base, ... ``` The previously named `GeneratedAttributeMethods` module builder class is renamed `GeneratedAttributeMethodsBuilder` to emphasize that this is not a module but a class.
-
由 Kasper Timm Hansen 提交于
Schema Cache: cache table indexes
-
由 Kasper Timm Hansen 提交于
Useful to not query for indexes when an application uses schema cache. Ref https://github.com/rails/rails/pull/35546
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Not looking for other contributions like this, but I took the liberty since I was already working on this.
-
由 Ryuta Kamizono 提交于
Update URL in RELEASING_RAILS.md [ci skip]
-
由 Kasper Timm Hansen 提交于
YAML has been used to serialize the schema cache ever since 2016 with Rails 5.1: 4c00c6ed
-
由 nisusam 提交于
* Update valid link for `signing release tag` from `git-scm` book * Use `en`(English) instead of `tr`(Turkish) documentation link
-
由 Ryuta Kamizono 提交于
The `Row` class is no longer used since d956772b.
-
由 Ryuta Kamizono 提交于
Staled `@default_timezone` would cause an error on `reconnect!` after `disconnect!`. https://buildkite.com/rails/rails/builds/59495#23be8079-3a4f-4375-9991-0a6f874554f2 Steps to reproduce: ``` % ARCONN=postgresql bin/test test/cases/adapter_test.rb test/cases/base_test.rb -n "/(?:test_attributes_on_dummy_time|test_reconnect_after_a_disconnect)$/" --seed 15849 Using postgresql Run options: -n "/(?:test_attributes_on_dummy_time|test_reconnect_after_a_disconnect)$/" --seed 15849 # Running: . E Error: ActiveRecord::AdapterTestWithoutTransaction#test_reconnect_after_a_disconnect: NoMethodError: undefined method `add_coder' for #<PG::TypeMapAllStrings:0x00007f85ab9dd5b8> /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:866:in `update_typemap_for_default_timezone' /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:652:in `exec_no_cache' /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:636:in `execute_and_clear' /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:894:in `add_pg_decoders' /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:744:in `connect' /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:285:in `rescue in block in reconnect!' /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:281:in `block in reconnect!' /Users/kamipo/.rbenv/versions/2.6.1/lib/ruby/2.6.0/monitor.rb:230:in `mon_synchronize' /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:280:in `reconnect!' /Users/kamipo/src/github.com/rails/rails/activerecord/test/cases/adapter_test.rb:465:in `block in <class:AdapterTestWithoutTransaction>' ```
-
由 Rafael França 提交于
Edit a changelog entry [ci skip]
-
由 Eileen M. Uchitelle 提交于
Add additional ERB DummyCompiler tests
-
由 Vipul A M 提交于
Change wording of some instances of 'opt out' [ci skip]
-
由 Ryuta Kamizono 提交于
Update small typo in documentation.
-
- 12 3月, 2019 24 次提交
-
-
由 Kurt Mueller 提交于
-
由 Sharang Dashputre 提交于
-
由 Sharang Dashputre 提交于
-
由 Cliff Pruitt 提交于
This adds a few additional tests to the commits by eileencodes (https://github.com/rails/rails/pull/35497) and rafaelfranca (https://github.com/rails/rails/commit/cfa22f1a4b5e8b95ee01a432168de2f831b3f788). The additional tests cover several more ERB tag formatting cases such as multiline tags, conditional statements that result in duplicate keys, and multiple erb statements on a single line.
-
由 Kasper Timm Hansen 提交于
Show friendly message to install action mailbox if the related table does not exist
-
由 Prathamesh Sonpatki 提交于
- This is similar to the work done in https://github.com/rails/rails/pull/31534
-
由 Kasper Timm Hansen 提交于
Fix warnings from Guides generation
-
https://github.com/rails/rails/pull/35281由 Vipul A M 提交于
After https://github.com/rails/rails/pull/35281 and https://github.com/rails/rails/pull/35036 AV warns about not having the compiled container. Use the suggested with_empty_template_cache to overcome warning
-
由 Vipul A M 提交于
Add note about has_many associations callbacks [ci skip]
-
由 Rodrigo 提交于
Add a note explaining when the has_many associations callbacks will be called or not.
-
由 Ryuta Kamizono 提交于
Add changelog entry for transliterate/parameterize accepting `locale` [ci skip]
-
由 Sharang Dashputre 提交于
-
由 Rafael França 提交于
Fall back to parent locale before falling back to the :errors namespace
-
由 Xavier Noria 提交于
-
由 Vipul A M 提交于
overriden -> overridden [ci skip]
-
由 Sharang Dashputre 提交于
-
由 Rafael Mendonça França 提交于
-
由 Kasper Timm Hansen 提交于
Add test for 'ActiveSupport::Inflector.transliterate'
-
由 Sharang Dashputre 提交于
Also add tests for parametrize and transliterate
-
由 Kasper Timm Hansen 提交于
Add `config.credentials.content_path` and `config.credentials.key_path` to the guide
-
由 Kasper Timm Hansen 提交于
This streamlines the lovely foundation Bogdan added. Mainly to add guidance around encryption keys and remove some backticks. Finally it adds some mention of how to access these files from Ruby in apps. [ Kasper Timm Hansen & bogdanvlviv ]
-
由 Hugo Vacher 提交于
-
由 Kasper Timm Hansen 提交于
Improve output of `rails encrypted(:edit/:show) --help`
-
由 Rafael França 提交于
Add locale option to #parameterize
-
- 11 3月, 2019 2 次提交
-
-
由 Kaan Ozkan 提交于
Parameterize is triggering I18n#transliterate. This method already accepts a locale. It would be cleaner if similar to other string inflection methods #parameterize also accepted 'locale' as a parameter.
-
由 Javan Makhmali 提交于
Adds default trix content attachmment partial path
-