1. 05 4月, 2019 26 次提交
  2. 04 4月, 2019 14 次提交
    • R
      Fix rubocop offence for `Style/FrozenStringLiteralComment` · 9e6f9bc7
      Ryuta Kamizono 提交于
      ```
      % be rubocop -a
      Inspecting 2777 files
      ..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
      
      Offenses:
      
      tools/test_common.rb:1:1: C: [Corrected] Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
      if ENV["BUILDKITE"]
      ^
      
      2777 files inspected, 1 offense detected, 1 offense corrected
      ```
      9e6f9bc7
    • K
      Merge pull request #35856 from prathamesh-sonpatki/fix-dep-warning · 4c4cc7e3
      Kasper Timm Hansen 提交于
      Fix deprecation warning about variants and formats
      4c4cc7e3
    • P
      Fix deprecation warning about variants and formats · 6a4bf486
      Prathamesh Sonpatki 提交于
      - After https://github.com/rails/rails/pull/35408 and
        https://github.com/rails/rails/pull/35406, the `formats` and
        `variants` methods are deprecated in favor of `format` and `variant`.
      6a4bf486
    • M
      Merge pull request #35698 from mtsmfm/output-test-report · fd81e83b
      Matthew Draper 提交于
      Output junit format test report
      fd81e83b
    • R
      Merge pull request #35850 from kamipo/fix_count_all_with_eager_loading_and_select_and_order · c9981ae6
      Ryuta Kamizono 提交于
      Fix `count(:all)` with eager loading and explicit select and order
      c9981ae6
    • R
      Fix `count(:all)` with eager loading and explicit select and order · 060e09df
      Ryuta Kamizono 提交于
      This follows up ebc09ed9.
      
      We've still experienced a regression for `size` (`count(:all)`) with
      eager loading and explicit select and order when upgrading Rails to 5.1.
      
      In that case, the eager loading enforces `distinct` to subselect but
      still keep the custom select, it would cause the ORDER BY with DISTINCT
      issue.
      
      ```
      % ARCONN=postgresql bundle exec ruby -w -Itest test/cases/relations_test.rb -n test_size_with_eager_loading_and_custom_select_and_order
      Using postgresql
      Run options: -n test_size_with_eager_loading_and_custom_select_and_order --seed 8356
      
      # Running:
      
      E
      
      Error:
      RelationTest#test_size_with_eager_loading_and_custom_select_and_order:
      ActiveRecord::StatementInvalid: PG::InvalidColumnReference: ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list
      LINE 1: ..." ON "comments"."post_id" = "posts"."id" ORDER BY comments.i...
                                                                   ^
      ```
      
      As another problem on `distinct` is enforced, the result of `count`
      becomes fewer than expected if `select` is given explicitly.
      
      e.g.
      
      ```ruby
      Post.select(:type).count
      # => 11
      
      Post.select(:type).distinct.count
      # => 3
      ```
      
      As long as `distinct` is enforced, we need to care to keep the result of
      `count`.
      
      This fixes both the `count` with eager loading problems.
      060e09df
    • F
      Output junit format test report · 61c4be47
      Fumiaki MATSUSHIMA 提交于
      61c4be47
    • S
    • R
      Merge pull request #35848 from kamipo/refactor_collection_cache_key · 39d42dbd
      Ryuta Kamizono 提交于
      Refactor `Relation#cache_key` is moved from `CollectionCacheKey#collection_cache_key`
      39d42dbd
    • R
      Refactor `Relation#cache_key` is moved from `CollectionCacheKey#collection_cache_key` · 10919bfe
      Ryuta Kamizono 提交于
      The implementation of `Relation#cache_key` depends on some internal
      relation methods (e.g. `apply_join_dependency`, `build_subquery`), but
      somehow that implementation exists on the model class
      (`collection_cache_key`), it sometimes bothers to me.
      
      This refactors that implementation moves to `Relation#cache_key`, then
      we can avoid `send` to call internal methods.
      10919bfe
    • R
      Merge pull request #35847 from kamipo/optimizer_hints_with_count_subquery · d49761cd
      Ryuta Kamizono 提交于
      Optimizer hints should be applied on Top level query as much as possible
      d49761cd
    • R
      Merge pull request #35145 from st0012/fix-35114 · eda2d7d7
      Rafael França 提交于
      Fix partial caching ignore repeated items issue
      eda2d7d7
    • R
      Optimizer hints should be applied on Top level query as much as possible · 7fb2ba5e
      Ryuta Kamizono 提交于
      I've experienced this issue in our app, some hints only works on Top
      level query (e.g. `MAX_EXECUTION_TIME`).
      7fb2ba5e
    • S
      Fix partial caching ignore repeated items issue · e8688ddb
      st0012 提交于
      This is because we only use hash to maintain the result. So when the key
      are the same, the result would be skipped. The solution is to maintain
      an array for tracking every item's position to restructure the result.
      e8688ddb